absolutely 100% no self intersections

TODO: why is stuff black in ditt.zip

Author: devshgraphicsprogramming

examples_tests/22.RaytracedAO/raytraceCommon.glsl

@@ -191,15 +191,6 @@ nbl_glsl_xoroshiro64star_state_t load_aux_vertex_attrs(
 	return scramble_start_state;
 }
 
-// robust ray origins
-vec3 nbl_glsl_robust_ray_origin_impl(in vec3 origin, in vec3 direction, float offset, vec3 normal)
-{
-	// flip it in the correct direction
-	offset = uintBitsToFloat(floatBitsToUint(offset)^(floatBitsToUint(dot(normal,direction))&0x80000000u));
-	return origin+normal*offset;
-}
-
-
 vec3 rand3d(inout nbl_glsl_xoroshiro64star_state_t scramble_state, in int _sample, in int depth)
 {
 	uvec3 seqVal = texelFetch(sampleSequence,int(_sample)+(depth-1)*MAX_ACCUMULATED_SAMPLES).xyz;
@@ -269,8 +260,13 @@ for (uint i=1u; i!=vertex_depth; i++)
 	}
 	// TODO: investigate workgroup reductions here
 	const uint baseOutputID = atomicAdd(rayCount[pc.cummon.rayCountWriteIx],raysToAllocate);
-	
-	float ray_offset = dot(abs(normalizedN),abs(origin))*nbl_glsl_numeric_limits_float_epsilon(9u)*1.03f+nbl_glsl_numeric_limits_float_epsilon(20u); // I pulled the constants out of my @$$
+
+	// the 1.03125f adjusts for the fact that the normal might be too short (inversesqrt precision)
+	const float inversesqrt_precision = 1.03125f;
+	// TODO: investigate why we can't use `normalizedN` here
+	const vec3 ray_offset_vector = normalize(cross(dPdBary[0],dPdBary[1]))*inversesqrt_precision;
+	float origin_offset = nbl_glsl_numeric_limits_float_epsilon(44u); // I pulled the constants out of my @$$
+	origin_offset += dot(abs(ray_offset_vector),abs(origin))*nbl_glsl_numeric_limits_float_epsilon(24u);
 	// TODO: in the future run backward error analysis of
 	// dot(mat3(WorldToObj)*(origin+offset*geomNormal/length(geomNormal))+(WorldToObj-vx_pos[1]),geomNormal)
 	// where
@@ -281,15 +277,17 @@ for (uint i=1u; i!=vertex_depth; i++)
 	//const vec3 geomNormal = cross(dPdBary[0],dPdBary[1]);
 	//float ray_offset = ?;
 	//ray_offset = nbl_glsl_ieee754_next_ulp_away_from_zero(ray_offset);
-	// adjust for the fact that the normal might be too short (inversesqrt precision)
-	ray_offset *= 1.03125f;
+	const vec3 ray_offset = ray_offset_vector*origin_offset;
+	const vec3 ray_origin[2] = {origin+ray_offset,origin-ray_offset};
 	uint offset = 0u;
 	for (uint i=0u; i<maxRaysToGen; i++)
 	if (maxT[i]!=0.f)
 	{
 		nbl_glsl_ext_RadeonRays_ray newRay;
-		newRay.origin = nbl_glsl_robust_ray_origin_impl(origin,direction[i],ray_offset,normalizedN);
-		//newRay.origin = nbl_glsl_robust_ray_origin_impl(origin,direction[i],ray_offset,geomNormal);
+		if (dot(ray_offset_vector,direction[i])<0.f)
+			newRay.origin = ray_origin[1];
+		else
+			newRay.origin = ray_origin[0];
 		newRay.maxT = maxT[i];
 		newRay.direction = direction[i];
 		newRay.time = packOutPixelLocation(outPixelLocation);