Some PhysDev Feature Addition and Maintanance + Checks

Author: Erfan-Ahmadi

include/nbl/video/IPhysicalDevice.h

@@ -158,6 +158,7 @@ class IPhysicalDevice : public core::Interface, public core::Unmovable
 
             // Queries
             bool allowCommandBufferQueryCopies = false;
+            bool inheritedQueries = false;
 
             // Buffer Device Address
             bool bufferDeviceAddress = false;

src/nbl/video/COpenGLCommandBuffer.cpp

@@ -941,7 +941,14 @@ COpenGLCommandBuffer::~COpenGLCommandBuffer()
             case impl::ECT_COPY_QUERY_POOL_RESULTS:
             {
                 auto& c = cmd.get<impl::ECT_COPY_QUERY_POOL_RESULTS>();
-                
+
+                const IPhysicalDevice* physdev = getOriginDevice()->getPhysicalDevice();
+                if(!physdev->getFeatures().allowCommandBufferQueryCopies)
+                {
+                    assert(false); // allowCommandBufferQueryCopies feature not enabled -> can't write query results to buffer
+                    break;
+                }
+
                 const COpenGLBuffer* buffer = static_cast<const COpenGLBuffer*>(c.dstBuffer.get());
                 const COpenGLQueryPool* qp = IBackendObject::compatibility_cast<const COpenGLQueryPool*>(c.queryPool.get(), this);
                 auto queryPoolQueriesCount = qp->getCreationParameters().queryCount;

src/nbl/video/CVulkanPhysicalDevice.h

@@ -170,6 +170,7 @@ class CVulkanPhysicalDevice final : public IPhysicalDevice
             m_features.shaderSubgroupQuad = subgroupProperties.supportedOperations & VK_SUBGROUP_FEATURE_QUAD_BIT;
             m_features.shaderSubgroupQuadAllStages = ((subgroupProperties.supportedStages & asset::IShader::E_SHADER_STAGE::ESS_ALL)
                                                         == asset::IShader::E_SHADER_STAGE::ESS_ALL);
+            m_features.inheritedQueries = features.inheritedQueries;
 
             // RayQuery
             if (m_availableFeatureSet.find(VK_KHR_RAY_QUERY_EXTENSION_NAME) != m_availableFeatureSet.end())
@@ -434,7 +435,10 @@ class CVulkanPhysicalDevice final : public IPhysicalDevice
         VkPhysicalDeviceFeatures2 vk_deviceFeatures2 = { VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FEATURES_2 };
         vk_deviceFeatures2.pNext = firstFeatureInChain;
         vk_deviceFeatures2.features = {};
+        // Enabled Logical Device Features By Default:
+        // TODO: seperate logical and physical device features.
         vk_deviceFeatures2.features.samplerAnisotropy = m_features.samplerAnisotropy;
+        vk_deviceFeatures2.features.inheritedQueries = m_features.inheritedQueries;
 
         // Create Device
         VkDeviceCreateInfo vk_createInfo = { VK_STRUCTURE_TYPE_DEVICE_CREATE_INFO };

src/nbl/video/IOpenGL_PhysicalDeviceBase.h

@@ -334,15 +334,17 @@ class IOpenGL_PhysicalDeviceBase : public IPhysicalDevice, public IOpenGLPhysica
 		{
 			m_features.allowCommandBufferQueryCopies = true;
 		}
+		m_features.inheritedQueries = true; // We emulate secondary command buffers so enable by default
 
 		if (m_glfeatures.isFeatureAvailable(m_glfeatures.NBL_EXT_texture_filter_anisotropic))
 		{
 			GetIntegerv(GL_MAX_TEXTURE_MAX_ANISOTROPY_EXT, &num);
 			m_glfeatures.MaxAnisotropy = static_cast<uint8_t>(num);
+			m_features.samplerAnisotropy = true;
+			m_limits.maxSamplerAnisotropyLog2 = std::log2((float)m_glfeatures.MaxAnisotropy);
 		}
 		else m_glfeatures.MaxAnisotropy = 0u;
 
-
 		if (m_glfeatures.isFeatureAvailable(m_glfeatures.NBL_ARB_geometry_shader4))
 		{
 			GetIntegerv(GL_MAX_GEOMETRY_OUTPUT_VERTICES, &num);