fix getArccosSumofABC_minus_PI incorrect operator

keptsecret · keptsecret · commit 107ca8006452 · 2025-02-28T16:58:28.000+07:00
diff --git a/include/nbl/builtin/hlsl/math/functions.hlsl b/include/nbl/builtin/hlsl/math/functions.hlsl
@@ -204,7 +204,7 @@ struct trigonometry
         const bool ABltC = cosSumAB < tmp2;
         // apply triple angle formula
         const float absArccosSumABC = acos<float>(clamp<float>(cosSumAB * tmp2 - (tmp0 * tmp4 + tmp3 * tmp1) * tmp5, -1.f, 1.f));
-        return ((AltminusB ? ABltC : ABltminusC) ? (-absArccosSumABC) : absArccosSumABC) + (AltminusB | ABltminusC ? numbers::pi<float> : (-numbers::pi<float>));
+        return ((AltminusB ? ABltC : ABltminusC) ? (-absArccosSumABC) : absArccosSumABC) + ((AltminusB || ABltminusC) ? numbers::pi<float> : (-numbers::pi<float>));
     }
 
     static void combineCosForSumOfAcos(float cosA, float cosB, float biasA, float biasB, NBL_REF_ARG(float) out0, NBL_REF_ARG(float) out1)

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,7 @@ struct trigonometry`
`204`	`204`	`const bool ABltC = cosSumAB < tmp2;`
`205`	`205`	`// apply triple angle formula`
`206`	`206`	`const float absArccosSumABC = acos<float>(clamp<float>(cosSumAB * tmp2 - (tmp0 * tmp4 + tmp3 * tmp1) * tmp5, -1.f, 1.f));`
`207`		`- return ((AltminusB ? ABltC : ABltminusC) ? (-absArccosSumABC) : absArccosSumABC) + (AltminusB \| ABltminusC ? numbers::pi<float> : (-numbers::pi<float>));`
	`207`	`+ return ((AltminusB ? ABltC : ABltminusC) ? (-absArccosSumABC) : absArccosSumABC) + ((AltminusB \|\| ABltminusC) ? numbers::pi<float> : (-numbers::pi<float>));`
`208`	`208`	`}`
`209`	`209`
`210`	`210`	`static void combineCosForSumOfAcos(float cosA, float cosB, float biasA, float biasB, NBL_REF_ARG(float) out0, NBL_REF_ARG(float) out1)`