Skip to content

Commit 1403c2f

Browse files
committed
Correct CMake bugs, use Java_JAVA_EXE_BIN_LENGTH properly when compiling android with Windows as host cross compile OS, produce 43 example APK
1 parent 3e587ad commit 1403c2f

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

cmake/common.cmake

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -362,6 +362,7 @@ macro(nbl_android_create_apk _TARGET)
362362
WORKING_DIRECTORY ${NBL_GEN_DIRECTORY}/$<CONFIG>
363363
COMMAND ${ANDROID_JAVA_BIN}/keytool -genkey -keystore ${KEYSTORE_FILE} -storepass android -alias ${KEY_ENTRY_ALIAS} -keypass android -keyalg RSA -keysize 2048 -validity 10000 -dname "CN=, OU=, O=, L=, S=, C="
364364
)
365+
365366
set(D8_SCRIPT "${ANDROID_BUILD_TOOLS}/d8.bat")
366367
if(NOT EXISTS ${D8_SCRIPT})
367368
set(DEX_COMMAND ${ANDROID_BUILD_TOOLS}/d8 ./obj/eu/devsh/${TARGET_NAME}/Loader.class --output ./bin/)

cmake/toolchains/android/build.cmake

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ if(NBL_BUILD_ANDROID)
104104
endif()
105105

106106
string(LENGTH ${Java_JAVA_EXECUTABLE} Java_JAVA_EXECUTABLE_LENGTH)
107-
if(MSVC)
107+
if(WIN32)
108108
set(Java_JAVA_EXE_BIN_LENGTH 13)
109109
else()
110110
set(Java_JAVA_EXE_BIN_LENGTH 9)
@@ -159,11 +159,8 @@ if(NBL_BUILD_ANDROID)
159159
unset(__buildTools)
160160
endif()
161161
set(ANDROID_BUILD_TOOLS "${ANDROID_SDK_ROOT_PATH}/build-tools/${ANDROID_BUILD_TOOLS_VERSION}")
162-
if(MSVC)
163-
set(ANDROID_JAVA_BIN "${JAVA_HOME}")
164-
else()
162+
165163
set(ANDROID_JAVA_BIN "${JAVA_HOME}/bin")
166-
endif()
167164
set(ANDROID_JAVA_RT_JAR "${JAVA_HOME}/jre/lib/rt.jar")
168165

169166
set(ANDROID_APK_TARGET_ID "" CACHE STRING "The Target ID to build the APK for like 'android-99', use <android list targets> to choose another one.")

0 commit comments

Comments
 (0)