isCreateRequest Fix and Added TODO comments for QueryPool

Erfan-Ahmadi · Erfan-Ahmadi · commit 237389b5c212 · 2022-02-04T09:36:31.000+03:30
diff --git a/include/nbl/video/IQueryPool.h b/include/nbl/video/IQueryPool.h
@@ -16,7 +16,7 @@ class IQueryPool : public core::IReferenceCounted, public IBackendObject
             EQT_OCCLUSION = 0,
             EQT_PIPELINE_STATISTICS = 1,
             EQT_TIMESTAMP = 2,
-            EQT_PERFORMANCE_QUERY = 1000116000, // VK_KHR_performance_query
+            EQT_PERFORMANCE_QUERY = 1000116000, // VK_KHR_performance_query // TODO: We don't support this fully yet -> needs Acquire/ReleaseProfilingLock + Counters Information report from physical device
             EQT_ACCELERATION_STRUCTURE_COMPACTED_SIZE = 1000150000, // VK_KHR_acceleration_structure
             EQT_ACCELERATION_STRUCTURE_SERIALIZATION_SIZE = 1000150001, // VK_KHR_acceleration_structure
         };
diff --git a/src/nbl/video/COpenGLQueryPool.h b/src/nbl/video/COpenGLQueryPool.h
@@ -38,6 +38,7 @@ class COpenGLQueryPool final : public IQueryPool
 			}
 			else
 			{
+				// TODO: Add ARB_pipeline_statistics support: https://www.khronos.org/registry/OpenGL/extensions/ARB/ARB_pipeline_statistics_query.txt
 				assert(false && "QueryType is not supported.");
 			}
 		}
diff --git a/src/nbl/video/IOpenGL_LogicalDevice.h b/src/nbl/video/IOpenGL_LogicalDevice.h
@@ -101,7 +101,7 @@ namespace impl
         }
         constexpr static inline bool isCreationRequest(E_REQUEST_TYPE rt)
         {
-            return !isDestroyRequest(rt) && rt<=ERT_COMPUTE_PIPELINE_CREATE;
+            return !isDestroyRequest(rt) && rt<=ERT_QUERY_POOL_CREATE;
         }
         constexpr static inline bool isWaitlessRequest(E_REQUEST_TYPE rt)
         {

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,7 @@ class COpenGLQueryPool final : public IQueryPool`
`38`	`38`	`}`
`39`	`39`	`else`
`40`	`40`	`{`
	`41`	`+ // TODO: Add ARB_pipeline_statistics support: https://www.khronos.org/registry/OpenGL/extensions/ARB/ARB_pipeline_statistics_query.txt`
`41`	`42`	`assert(false && "QueryType is not supported.");`
`42`	`43`	`}`
`43`	`44`	`}`
Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ namespace impl`
`101`	`101`	`}`
`102`	`102`	`constexpr static inline bool isCreationRequest(E_REQUEST_TYPE rt)`
`103`	`103`	`{`
`104`		`- return !isDestroyRequest(rt) && rt<=ERT_COMPUTE_PIPELINE_CREATE;`
	`104`	`+ return !isDestroyRequest(rt) && rt<=ERT_QUERY_POOL_CREATE;`
`105`	`105`	`}`
`106`	`106`	`constexpr static inline bool isWaitlessRequest(E_REQUEST_TYPE rt)`
`107`	`107`	`{`