Skip to content

Commit 263ef32

Browse files
committed
Apply PR reviews
1 parent 15869a8 commit 263ef32

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

include/nbl/ui/IWindow.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,6 @@ class IWindow : public core::IReferenceCounted
3434
//! Indicates whether mouse is hovering over the window even if the window is not active
3535
ECF_MOUSE_FOCUS = 1u << 8,
3636
ECF_ALWAYS_ON_TOP = 1u << 9,
37-
//! Mobile platforms can have a window that rotates (landscape vs vertical)
38-
ECF_CAN_ROTATE = 1u << 10,
39-
ECF_LANDSCAPE_ORIENTATION = 1u << 11,
4037

4138
ECF_NONE = 0
4239
};
@@ -186,8 +183,6 @@ class IWindow : public core::IReferenceCounted
186183
inline bool hasInputFocus() { return (m_flags.value & ECF_INPUT_FOCUS); }
187184
inline bool hasMouseFocus() { return (m_flags.value & ECF_MOUSE_FOCUS); }
188185
inline bool isAlwaysOnTop() { return (m_flags.value & ECF_ALWAYS_ON_TOP); }
189-
inline bool canRotate() { return (m_flags.value & ECF_CAN_ROTATE); }
190-
inline bool isRotationLandscape() { return (m_flags.value & ECF_LANDSCAPE_ORIENTATION); }
191186

192187
inline uint32_t getWidth() const { return m_width; }
193188
inline uint32_t getHeight() const { return m_height; }

include/nbl/ui/IWindowManager.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,15 @@ class NBL_API2 IWindowManager : public core::IReferenceCounted
4848

4949
inline bool setWindowRotation(IWindow* window, const bool landscape)
5050
{
51+
// TODO
52+
/*
5153
auto cb = window->getEventCallback();
5254
if (window->getManager() != this || !window->canRotate() || landscape == window->isRotationLandscape() || cb && !cb->onWindowRotated(window))
5355
return false;
5456
5557
return setWindowRotation_impl(window, landscape);
58+
*/
59+
return false;
5660
}
5761

5862
inline bool show(IWindow* window)

0 commit comments

Comments
 (0)