Skip to content

Commit 2644822

Browse files
committed
Small improvements
1 parent 4ea28c1 commit 2644822

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

examples_tests/22.RaytracedAO/CommandLineHandler.cpp

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,6 @@ CommandLineHandler::CommandLineHandler(const std::vector<std::string>& argv)
4141
variablesHandle.end()
4242
);
4343

44-
// remove double-quotes
45-
for(auto& var : variablesHandle)
46-
{
47-
var.erase(std::remove(var.begin(), var.end(), '\"'), var.end());
48-
}
49-
5044
return variablesHandle;
5145
};
5246

@@ -110,7 +104,8 @@ CommandLineHandler::CommandLineHandler(const std::vector<std::string>& argv)
110104
if(endOfFetchedVariableName != std::string::npos)
111105
{
112106
auto value = rawFetchedCmdArgument.substr(endOfFetchedVariableName + 1);
113-
std::vector<std::string> toAdd = getSerializedValues(value);
107+
std::vector<std::string> toAdd;
108+
toAdd.push_back(value);
114109
rawVariables[arg].emplace(toAdd);
115110
}
116111
else

examples_tests/22.RaytracedAO/main.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,12 +229,16 @@ int main(int argc, char** argv)
229229
qnc->saveCacheToFile<asset::EF_A2B10G10R10_SNORM_PACK32>(fs, "../../tmp/normalCache101010.sse");
230230

231231
auto contents = meshes.getContents();
232-
if (!contents.size())
232+
if (!contents.size()) {
233+
std::cout << "[ERROR] Failed loading asset in " << filePath << ".";
233234
return 2;
235+
}
234236

235237
globalMeta = core::smart_refctd_ptr<const ext::MitsubaLoader::CMitsubaMetadata>(meshes.getMetadata()->selfCast<const ext::MitsubaLoader::CMitsubaMetadata>());
236-
if (!globalMeta)
238+
if (!globalMeta) {
239+
std::cout << "[ERROR] Couldn't get global Meta";
237240
return 3;
241+
}
238242
}
239243

240244
struct SensorData

0 commit comments

Comments
 (0)