Guard histogram.atomicAdd

nipunG314 · nipunG314 · commit 309ab591cea3 · 2024-06-01T16:46:44.000+05:30
diff --git a/include/nbl/builtin/hlsl/sort/counting.hlsl b/include/nbl/builtin/hlsl/sort/counting.hlsl
@@ -104,9 +104,10 @@ struct counting
             sdata.workgroupExecutionAndMemoryBarrier();
 
             // no aliasing anymore
-            const uint32_t val = vid < KeyBucketCount ? sdata.get(vid) : 0;
-            sum = inclusive_scan(val, sdata);
-            histogram.atomicAdd(vid, sum);
+            if (vid < KeyBucketCount) {
+                sum = inclusive_scan(sdata.get(vid), sdata);
+                histogram.atomicAdd(vid, sum);
+            }
         }
     }
                 

Original file line number	Diff line number	Diff line change
`@@ -104,9 +104,10 @@ struct counting`
`104`	`104`	`sdata.workgroupExecutionAndMemoryBarrier();`
`105`	`105`
`106`	`106`	`// no aliasing anymore`
`107`		`- const uint32_t val = vid < KeyBucketCount ? sdata.get(vid) : 0;`
`108`		`- sum = inclusive_scan(val, sdata);`
`109`		`- histogram.atomicAdd(vid, sum);`
	`107`	`+ if (vid < KeyBucketCount) {`
	`108`	`+ sum = inclusive_scan(sdata.get(vid), sdata);`
	`109`	`+ histogram.atomicAdd(vid, sum);`
	`110`	`+ }`
`110`	`111`	`}`
`111`	`112`	`}`
`112`	`113`