rgb19e7 bug

Author: Crisspl

examples_tests/22.RaytracedAO/raygen.comp

@@ -154,7 +154,7 @@ void main()
 			}
 
 			// decode vis buffer
-			vec3 emissive = vec3(0.0,0.0,0.0);
+			vec3 emissive = vec3(0.0,1.0,0.0);
 			{
 				const uint objectID = visBuffer[0]&0x7fffffffu;
 				const uint triangleID = visBuffer[1];
@@ -163,7 +163,7 @@ void main()
 				nbl_glsl_MC_oriented_material_t material = nbl_glsl_MC_material_data_t_getOriented(InstData.data[objectID].material,frontfacing);
 
 				// use loaded data
-				emissive = nbl_glsl_MC_oriented_material_t_getEmissive(material);
+				//emissive = nbl_glsl_MC_oriented_material_t_getEmissive(material);
 				gcs = nbl_glsl_MC_oriented_material_t_getGenChoiceStream(material);
 				rnps = nbl_glsl_MC_oriented_material_t_getRemAndPdfStream(material);
 

examples_tests/22.RaytracedAO/raytraceCommon.glsl

@@ -138,13 +138,13 @@ layout(set = 1, binding = 5, std430, row_major) restrict readonly buffer LightRa
 vec3 fetchAccumulation(in ivec2 coord)
 {
     const uvec2 data = imageLoad(accumulation,coord).rg;
-	return vec4(unpackHalf2x16(data[0]),unpackHalf2x16(data[1])).rgb;
-	//return nbl_glsl_decodeRGB19E7(data);
+	//return vec4(unpackHalf2x16(data[0]),unpackHalf2x16(data[1])).rgb;
+	return nbl_glsl_decodeRGB19E7(data);
 }
 void storeAccumulation(in vec3 color, in ivec2 coord)
 {
-	//const uvec2 data = nbl_glsl_encodeRGB19E7(color);
-	const uvec2 data = uvec2(packHalf2x16(color.rg),packHalf2x16(vec2(color.b,1.0)));
+	const uvec2 data = nbl_glsl_encodeRGB19E7(color);
+	//const uvec2 data = uvec2(packHalf2x16(color.rg),packHalf2x16(vec2(color.b,1.0)));
 	imageStore(accumulation,coord,uvec4(data,0u,0u));
 }
 

examples_tests/22.RaytracedAO/resolve.comp

@@ -34,7 +34,7 @@ void main()
 
 			const bool frontface = true; // TODO: how to determine frontface easily from radeon rays!? barycentrics? ray direction vs. oriented cross product?
 			nbl_glsl_MC_oriented_material_t material = nbl_glsl_MC_material_data_t_getOriented(InstData.data[hit.shapeid].material,frontface);
-			color += nbl_glsl_MC_oriented_material_t_getEmissive(material)*thoughput;
+			//color += nbl_glsl_MC_oriented_material_t_getEmissive(material)*thoughput;
 
 			// hit buffer needs clearing
 			hits[rayID].shapeid = -1;