Skip to content

Commit 35d5fb4

Browse files
make the barycentrics actually get used
and fix 3rdparty issues (SPIRV-Tools is now an alias, needed to account for that)
1 parent f91346f commit 35d5fb4

File tree

6 files changed

+8
-6
lines changed

6 files changed

+8
-6
lines changed

3rdparty/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,7 @@ set(NBL_3RDPARTY_TARGETS
471471
SPIRV
472472
Iex
473473
IexMath
474-
SPIRV-Tools
474+
SPIRV-Tools-static
475475
SPIRV-Tools-opt )
476476
#TODO insert more targets that are conditionally built
477477
if (NBL_BUILD_MITSUBA_LOADER)

examples_tests/22.RaytracedAO/fillVisBuffer.frag

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
// For conditions of distribution and use, see copyright notice in nabla.h
44
#version 430 core
55
#extension GL_EXT_shader_16bit_storage : require
6+
#include <nbl/builtin/glsl/barycentric/extensions.glsl>
67

78

89
#define _NBL_GLSL_EXT_MITSUBA_LOADER_INSTANCE_DATA_BINDING_ 0

examples_tests/41.VisibilityBuffer/fillVBuffer.frag

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#version 430 core
2+
#include <nbl/builtin/glsl/barycentric/frag.glsl>
23

34
#include "common.glsl"
45

include/nbl/builtin/glsl/barycentric/extensions.glsl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
// This file is part of the "Nabla Engine".
33
// For conditions of distribution and use, see copyright notice in nabla.h
44

5-
#ifndef _NBL_BUILTIN_GLSL_EXTENSIONS_INCLUDED_
6-
#define _NBL_BUILTIN_GLSL_EXTENSIONS_INCLUDED_
5+
#ifndef _NBL_BUILTIN_GLSL_BARYCENTRIC_EXTENSIONS_INCLUDED_
6+
#define _NBL_BUILTIN_GLSL_BARYCENTRIC_EXTENSIONS_INCLUDED_
77

88
#ifdef NBL_GL_NV_fragment_shader_barycentric
9-
#extension GL_NV_fragment_shader_barycentric : enable
9+
#extension GL_NV_fragment_shader_barycentric : require
1010
#elif defined(NBL_GL_AMD_shader_explicit_vertex_parameter)
1111
#extension GL_AMD_shader_explicit_vertex_parameter : enable
1212
#endif

src/nbl/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,7 @@ endif()
507507
nbl_install_lib(shaderc)
508508
nbl_install_lib(shaderc_util)
509509
nbl_install_lib(SPIRV)
510-
nbl_install_lib(SPIRV-Tools)
510+
nbl_install_lib(SPIRV-Tools-static) # TODO: make this function/macro work with alias target
511511
nbl_install_lib(SPIRV-Tools-opt)
512512
nbl_install_lib(OGLCompiler)
513513
nbl_install_lib(OSDependent)

0 commit comments

Comments
 (0)