fix a few compiler warnings

devshgraphicsprogramming · devshgraphicsprogramming · commit 38b8a81c2c02 · 2022-03-07T18:27:33.000+01:00
diff --git a/include/nbl/system/CColoredStdoutLoggerWin32.h b/include/nbl/system/CColoredStdoutLoggerWin32.h
@@ -54,10 +54,11 @@ class CColoredStdoutLoggerWin32 : public IThreadsafeLogger
 				}
 				case ELL_NONE: 
 				{
-					assert(false); // how did this happen?? Btw, do we even need this log level? 
-					return 0;
+					assert(false); // how did this happen?? Btw, do we even need this log level?
+					break;
 				}
 			}
+			return 0;
 		}
 };
 
diff --git a/src/nbl/asset/interchange/CGLTFLoader.h b/src/nbl/asset/interchange/CGLTFLoader.h
@@ -383,8 +383,7 @@ class CGLTFLoader final : public IRenderpassIndependentPipelineLoader
 
 					if (!count.has_value())
 						return false;
-					else
-						if (count.has_value() < 1)
+					else if (count.value() < 1)
 							return false;
 
 					if (!type.has_value())

Original file line number	Diff line number	Diff line change
`@@ -54,10 +54,11 @@ class CColoredStdoutLoggerWin32 : public IThreadsafeLogger`
`54`	`54`	`}`
`55`	`55`	`case ELL_NONE:`
`56`	`56`	`{`
`57`		`- assert(false); // how did this happen?? Btw, do we even need this log level?`
`58`		`- return 0;`
	`57`	`+ assert(false); // how did this happen?? Btw, do we even need this log level?`
	`58`	`+ break;`
`59`	`59`	`}`
`60`	`60`	`}`
	`61`	`+ return 0;`
`61`	`62`	`}`
`62`	`63`	`};`
`63`	`64`