update dxc submodule with fixed clang 19.1.1 build, upgrade & correct NBL_REQUEST_COMPILE_OPTION_SUPPORT, add required instruction set features for simdjson explicitly; now I hit GLI errors due to bad templates

Author: AnastaZIuk

3rdparty/dxc/dxc

@@ -15,9 +15,10 @@ define_property(TARGET PROPERTY NBL_CONFIGURATION_MAP
 # Usage: NBL_REQUEST_COMPILE_OPTION_SUPPORT(LANG <LANG;...> CONFIG <CONFIG;...> OPTIONS <OPTIONS;...> )
 # LANG, CONFIG - optional, OPTIONS - required
 function(NBL_REQUEST_COMPILE_OPTION_SUPPORT)
-	cmake_parse_arguments(IMPL "" "" "LANG;CONFIG;OPTIONS" ${ARGN})
+	cmake_parse_arguments(IMPL "" "REQUEST_VAR;REQUIRED" "LANG;CONFIG;OPTIONS" ${ARGN})
 
 	set(DEFAULT_COMPILERS c cxx)
+	set(REQUEST_ALL_OPTIONS_PRESENT True)
 
 	if(NOT IMPL_LANG)
         list(APPEND IMPL_LANG ${DEFAULT_COMPILERS})
@@ -51,14 +52,33 @@ function(NBL_REQUEST_COMPILE_OPTION_SUPPORT)
 					foreach(CONFIG ${IMPL_CONFIG})
 						# TODO: validate (${CONFIG} \in ${CMAKE_CONFIGURATION_TYPES})
 						string(TOUPPER "${CONFIG}" CONFIG_UPPER)
-						set(NBL_${COMPILER_UPPER}_${CONFIG_UPPER}_COMPILE_OPTIONS "${NBL_${COMPILER_UPPER}_${CONFIG_UPPER}_COMPILE_OPTIONS};${COMPILE_OPTION}" PARENT_SCOPE)
+						set(NBL_${COMPILER_UPPER}_${CONFIG_UPPER}_COMPILE_OPTIONS "${NBL_${COMPILER_UPPER}_${CONFIG_UPPER}_COMPILE_OPTIONS};${COMPILE_OPTION}")
 					endforeach()
 				else()
-					set(NBL_${COMPILER_UPPER}_COMPILE_OPTIONS "${NBL_${COMPILER_UPPER}_COMPILE_OPTIONS};${COMPILE_OPTION}" PARENT_SCOPE)
+					set(NBL_${COMPILER_UPPER}_COMPILE_OPTIONS "${NBL_${COMPILER_UPPER}_COMPILE_OPTIONS};${COMPILE_OPTION}")
 				endif()
+			else()
+				if(IMPL_REQUIRED)
+					message(FATAL_ERROR "Terminating, NBL_REQUEST_COMPILE_OPTION_SUPPORT was invoked with REQUIRED qualifier!")
+				endif()
+
+				set(REQUEST_ALL_OPTIONS_PRESENT False)
 			endif()
 		endforeach()
+
+		if(IMPL_CONFIG)
+			foreach(CONFIG ${IMPL_CONFIG})
+				string(TOUPPER "${CONFIG}" CONFIG_UPPER)
+				set(NBL_${COMPILER_UPPER}_${CONFIG_UPPER}_COMPILE_OPTIONS ${NBL_${COMPILER_UPPER}_${CONFIG_UPPER}_COMPILE_OPTIONS} PARENT_SCOPE)
+			endforeach()
+		else()
+			set(NBL_${COMPILER_UPPER}_COMPILE_OPTIONS ${NBL_${COMPILER_UPPER}_COMPILE_OPTIONS} PARENT_SCOPE)
+		endif()
     endforeach()
+
+	if(IMPL_REQUEST_VAR)
+		set(${IMPL_REQUEST_VAR} ${REQUEST_ALL_OPTIONS_PRESENT} PARENT_SCOPE)
+	endif()
 endfunction()
 
 option(NBL_REQUEST_SSE_4_2 "Request compilation with SSE 4.2 instruction set enabled for Nabla projects" ON)

cmake/adjust/flags.cmake

@@ -18,6 +18,20 @@ if(NBL_REQUEST_SSE_AVX2)
 	)
 endif()
 
+NBL_REQUEST_COMPILE_OPTION_SUPPORT(LANG ${LANG} OPTIONS
+	# latest Clang(CL) 19.1.1 shipped with VS seems to require explicitly features to be listed (simdjson)
+	# TODO: Yas, use with REQUEST_VAR, if the request fail then do not promote simdjson to build with 
+	# HASWELL implementation because those flags + avx2 compose subset it wants in this case
+
+	# also instead of enabling single options maybe we could consider requesting an
+	# instruction implementation set instead, eg -march=haswel, though this approach
+	# could add a few more flags then we actually need while building - to rethink
+
+	-mbmi # https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-mbmi
+	-mlzcnt # https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-mlzcnt
+	-mpclmul # https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-mpclmul
+)
+
 list(APPEND NBL_${LANG}_COMPILE_OPTIONS
 	-Wextra # https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-W-warning
 	-maes # https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-maes