Merge pull request #52 from Devsh-Graphics-Programming/raytracing

Make sure we get all the raytracing goodies before we work on MitsubaLoader again

Author: devshgraphicsprogramming

examples_tests/22.RaytracedAO/Renderer.cpp

@@ -305,18 +305,19 @@ Renderer::InitializationData Renderer::initSceneObjects(const SAssetBundle& mesh
 
 					m_sceneBound.addInternalBox(core::transformBoxEx(aabbOriginal,instance.tform));
 
-					if (instance.emitter.type != ext::MitsubaLoader::CElementEmitter::Type::INVALID)
+					auto emitter = instance.emitter.front;
+					if (emitter.type != ext::MitsubaLoader::CElementEmitter::Type::INVALID)
 					{
-						assert(instance.emitter.type == ext::MitsubaLoader::CElementEmitter::Type::AREA);
+						assert(emitter.type == ext::MitsubaLoader::CElementEmitter::Type::AREA);
 
 						SLight newLight(cpumesh->getBoundingBox(), instance.tform);
 
-						const float weight = newLight.computeFluxBound(instance.emitter.area.radiance) * instance.emitter.area.samplingWeight;
+						const float weight = newLight.computeFluxBound(emitter.area.radiance) * emitter.area.samplingWeight;
 						if (weight <= FLT_MIN)
 							continue;
 
 						retval.lights.emplace_back(std::move(newLight));
-						retval.lightRadiances.push_back(instance.emitter.area.radiance);
+						retval.lightRadiances.push_back(emitter.area.radiance);
 						retval.lightPDF.push_back(weight);
 					}
 				}
@@ -789,9 +790,10 @@ void Renderer::init(const SAssetBundle& meshes,
 			}
 			// set up m_raygenDS
 			{
-				auto scrambleTexture = createScreenSizedTexture(EF_R32_UINT);
+				auto scrambleTexture = createScreenSizedTexture(EF_R32G32_UINT);
 				{
-					core::vector<uint32_t> random(renderPixelCount);
+					constexpr auto ScrambleStateChannels = 2u;
+					core::vector<uint32_t> random(renderPixelCount*ScrambleStateChannels);
 					// generate
 					{
 						core::RandomSampler rng(0xbadc0ffeu);

examples_tests/22.RaytracedAO/raygen.comp

@@ -217,7 +217,7 @@ void main()
 			const bool validRay = any(greaterThan(throughput.rgb,vec3(FLT_MIN)));
 			if (validRay)
 			{
-				const float err = 1.0/256.0; // TODO: improve ray offsets
+				const float err = 1.0/64.0; // TODO: improve ray offsets
 				rays[realOutputID].origin = worldPosition+direction*err;
 				rays[realOutputID].maxT = max(maxT-err,0.0);
 				rays[realOutputID].direction = direction;

examples_tests/42.FragmentShaderPathTracer/common.glsl

@@ -576,26 +576,12 @@ void main()
 
 Now:
 - Always MIS (path correlated reuse)
-- Proper Universal&Robust Materials
 - Test MIS alpha (roughness) scheme
 
-Quality:
--* Reweighting Noise Removal
--* Covariance Rendering
--* Geometry Specular AA (Curvature adjusted roughness)
-
-When proper scheduling is available:
-- Russian Roulette
-- Divergence Optimization
-- Adaptive Sampling
-
-When finally texturing:
-- Covariance Rendering
-- CLEAR/LEAN/Toksvig for simult roughness + bumpmap filtering
-
 Many Lights:
 - Path Guiding
 - Light Importance Lists/Classification
+- Spatio-Temporal Reservoir Sampling
 
 Indirect Light:
 - Bidirectional Path Tracing

include/nbl/ext/MitsubaLoader/CElementEmitter.h

@@ -104,6 +104,7 @@ class CElementEmitter : public IElement
 		CElementEmitter(const char* id) : IElement(id), type(Type::INVALID), /*toWorldType(IElement::Type::TRANSFORM),*/ transform()
 		{
 		}
+		CElementEmitter() : CElementEmitter("") {}
 		CElementEmitter(const CElementEmitter& other) : IElement(""), transform()
 		{
 			operator=(other);

include/nbl/ext/MitsubaLoader/SContext.h

@@ -138,20 +138,24 @@ namespace MitsubaLoader
 
 		struct SInstanceData
 		{
-			SInstanceData(core::matrix3x4SIMD _tform, SContext::bsdf_type _bsdf, const std::string& _id, const CElementEmitter& _emitter) : 
+			SInstanceData(core::matrix3x4SIMD _tform, SContext::bsdf_type _bsdf, const std::string& _id, const CElementEmitter& _emitterFront, const CElementEmitter& _emitterBack) :
 				tform(_tform), bsdf(_bsdf),
 #if defined(_NBL_DEBUG) || defined(_NBL_RELWITHDEBINFO)
 				bsdf_id(_id),
 #endif
-				emitter(_emitter)
+				emitter{_emitterFront, _emitterBack}
 			{}
 
 			core::matrix3x4SIMD tform;
 			SContext::bsdf_type bsdf;
 #if defined(_NBL_DEBUG) || defined(_NBL_RELWITHDEBINFO)
 			std::string bsdf_id;
 #endif
-			CElementEmitter emitter; // type is invalid if not used
+			struct {
+				// type is invalid if not used
+				CElementEmitter front;
+				CElementEmitter back;
+			} emitter;
 		};
 		core::unordered_multimap<const shape_ass_type::pointee*, SInstanceData> mapMesh2instanceData;
 

source/Nabla/COpenGLDriver.h

@@ -453,7 +453,7 @@ class COpenGLDriver final : public CNullDriver, public COpenGLExtensionHandler
 				default:
 				{
 					GLint res = GL_FALSE;
-					extGlGetInternalformativ(GL_TEXTURE_2D, getSizedOpenGLFormatFromOurFormat(_fmt), GL_COLOR_RENDERABLE, sizeof(res), &res);
+					extGlGetInternalformativ(GL_TEXTURE_2D, getSizedOpenGLFormatFromOurFormat(_fmt), GL_COLOR_RENDERABLE, 1, &res);
 					return res==GL_TRUE;
 				}
             }

src/nbl/ext/MitsubaLoader/CMitsubaLoader.cpp

@@ -865,7 +865,7 @@ SContext::shape_ass_type CMitsubaLoader::loadBasicShape(SContext& ctx, uint32_t
 		assert(shape->bsdf);
 		auto bsdf = getBSDFtreeTraversal(ctx, shape->bsdf);
 		core::matrix3x4SIMD tform = core::concatenateBFollowedByA(relTform, shape->getAbsoluteTransform());
-		SContext::SInstanceData instance(tform, bsdf, shape->bsdf->id, shape->obtainEmitter());
+		SContext::SInstanceData instance(tform, bsdf, shape->bsdf->id, shape->obtainEmitter(), CElementEmitter{});
 		ctx.mapMesh2instanceData.insert({ mesh.get(), instance });
 	};
 
@@ -1616,8 +1616,10 @@ inline core::smart_refctd_ptr<asset::ICPUDescriptorSet> CMitsubaLoader::createDS
 			mb->setBaseInstance(instanceData.size());
 		}
 		for (const auto& inst : meta->getInstances()) {
-			// @Crisspl IIRC lights in mitsuba have "sides" , TODO
-			emissive = inst.emitter.type==CElementEmitter::AREA ? inst.emitter.area.radiance : core::vectorSIMDf(0.f);
+			// @Crisspl IIRC lights in mitsuba have "sides"
+			//
+			// i think it's just that backside of an area emitter does not emit, docs doesnt say anything about this
+			emissive = inst.emitter.front.type==CElementEmitter::AREA ? inst.emitter.front.area.radiance : core::vectorSIMDf(0.f);
 
 			nbl_glsl_ext_Mitsuba_Loader_instance_data_t instData;
 

src/nbl/ext/RadeonRays/RadeonRays.cpp

@@ -124,11 +124,11 @@ void Manager::makeInstance(	NblInstanceRRInstanceCache& instanceCache, MockScene
 				if (!gpumeshbuffer)
 					continue;
 				::RadeonRays::Shape* shape = cpuAssociation.second;
-				auto successAndLocation = gpuCache.emplace(gpumeshbuffer,shape);
-				if (gpumeshbuffer==mb)
-					found = successAndLocation.first;
+				gpuCache.emplace(gpumeshbuffer,shape);
 			}
 			notRefreshedAlready = false;
+
+			found = gpuCache.find(mb);
 		}
 		if (found==gpuCache.end())
 			continue;