add UI streaming buffer const getter, extra cull frees call, correct some typos, add comments & update examples_tests submodule

Author: AnastaZIuk

examples_tests

@@ -19,10 +19,11 @@ class UI final : public core::IReferenceCounted
 		void update(float deltaTimeInSec, const nbl::hlsl::float32_t2 mousePosition, const core::SRange<const nbl::ui::SMouseEvent> mouseEvents, const core::SRange<const nbl::ui::SKeyboardEvent> keyboardEvents);
 		int registerListener(std::function<void()> const& listener);
 		bool unregisterListener(uint32_t id);
+		void setContext(void* imguiContext);
+
 		inline nbl::core::smart_refctd_ptr<nbl::video::IGPUImageView> getFontAtlasView() { return m_fontAtlasTexture; }
-		
+		inline auto getStreamingBuffer() -> decltype(auto) { return (std::as_const(m_mdi.streamingTDBufferST)); }
 		void* getContext();
-		void setContext(void* imguiContext);
 
 	private:
 		void createPipeline(core::smart_refctd_ptr<video::IGPUDescriptorSetLayout> descriptorSetLayout, video::IGPURenderpass* renderpass, video::IGPUPipelineCache* pipelineCache);

include/nbl/ext/ImGui/ImGui.h

@@ -761,7 +761,7 @@ namespace nbl::ext::imgui
 			}();
 
 			static constexpr auto MDI_ALLOCATION_COUNT = MDI::EBC_COUNT;
-			static auto MDI_ALIGNMENTS = std::to_array<typename MDI::COMPOSE_T::size_type, MDI_ALLOCATION_COUNT>({ alignof(VkDrawIndexedIndirectCommand), alignof(PerObjectData), alignof(ImDrawIdx), alignof(ImDrawVert) });
+			static constexpr auto MDI_ALIGNMENTS = std::to_array<typename MDI::COMPOSE_T::size_type, MDI_ALLOCATION_COUNT>({ alignof(VkDrawIndexedIndirectCommand), alignof(PerObjectData), alignof(ImDrawIdx), alignof(ImDrawVert) });
 
 			struct MULTI_ALLOC_PARAMS
 			{
@@ -794,7 +794,7 @@ namespace nbl::ext::imgui
 
 				if (unallocatedSize != 0u)
 				{
-					// retry
+					// retry & cull frees
 					m_mdi.streamingTDBufferST->cull_frees();
 					unallocatedSize = m_mdi.streamingTDBufferST->multi_allocate(timeout, MDI_ALLOCATION_COUNT, multiAllocParams.offsets.data(), multiAllocParams.byteSizes.data(), MDI_ALIGNMENTS.data());
 
@@ -816,7 +816,7 @@ namespace nbl::ext::imgui
 						logger->log("[MDI::EBC_INDEX_BUFFERS offset] = \"%s\" bytes", system::ILogger::ELL_ERROR, getOffsetStr(multiAllocParams.offsets[MDI::EBC_INDEX_BUFFERS]).c_str());
 						logger->log("[MDI::EBC_VERTEX_BUFFERS offset] = \"%s\" bytes", system::ILogger::ELL_ERROR, getOffsetStr(multiAllocParams.offsets[MDI::EBC_VERTEX_BUFFERS]).c_str());
 
-						exit(0x45); // TODO: handle OOB memory requests
+						exit(0x45); // TODO: handle OOB memory requests, probably need to extend the mdi buffer/let user pass more size at init
 					}
 				}
 			}
@@ -971,8 +971,10 @@ namespace nbl::ext::imgui
 			}
 
 			auto waitInfo = info.getFutureScratchSemaphore();
-			m_mdi.streamingTDBufferST->multi_deallocate(MDI_ALLOCATION_COUNT, multiAllocParams.offsets.data(), multiAllocParams.byteSizes.data(), waitInfo); // at some point a block would be needed anyway, cull frees but where? - so I just retry on failed allocation then cull free
+			m_mdi.streamingTDBufferST->multi_deallocate(MDI_ALLOCATION_COUNT, multiAllocParams.offsets.data(), multiAllocParams.byteSizes.data(), waitInfo);
 		}
+
+		m_mdi.streamingTDBufferST->cull_frees();
 
 		return true;
 	}