Skip to content

Commit 50db489

Browse files
committed
small fixes
1 parent c4a7b97 commit 50db489

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

include/nbl/video/ILogicalDevice.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe
8585
bool supportsMask(const uint32_t queueFamilyIndex, core::bitflag<asset::ACCESS_FLAGS> accessMask) const;
8686

8787
//! NOTE/TODO: this is not yet finished
88-
inline bool validateMemoryBarrier(const uint32_t queueFamilyIndex, asset::SMemoryBarrier barrier) const;
88+
bool validateMemoryBarrier(const uint32_t queueFamilyIndex, asset::SMemoryBarrier barrier) const;
8989
inline bool validateMemoryBarrier(const uint32_t queueFamilyIndex, const IGPUCommandBuffer::SOwnershipTransferBarrier& barrier, const bool concurrentSharing) const
9090
{
9191
// implicitly satisfied by our API:

include/nbl/video/IPhysicalDevice.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -559,11 +559,11 @@ class NBL_API2 IPhysicalDevice : public core::Interface, public core::Unmovable
559559
if (videoDecodeDPB && !other.videoDecodeDPB) return false;
560560
if (videoEncodeInput && !other.videoEncodeInput) return false;
561561
if (videoEncodeDPB && !other.videoEncodeDPB) return false;
562-
if (other.storageImageLoadWithoutFormat && !storageImageLoadWithoutFormat) return false;
563-
if (other.storageImageStoreWithoutFormat && !storageImageStoreWithoutFormat) return false;
564-
if (other.depthCompareSampledImage && !depthCompareSampledImage) return false;
565-
if (other.hostImageTransfer && !hostImageTransfer) return false;
566-
if (other.log2MaxSamples < log2MaxSamples) return false;
562+
if (storageImageLoadWithoutFormat && !other.storageImageLoadWithoutFormat) return false;
563+
if (storageImageStoreWithoutFormat && !other.storageImageStoreWithoutFormat) return false;
564+
if (depthCompareSampledImage && !other.depthCompareSampledImage) return false;
565+
if (hostImageTransfer && !other.hostImageTransfer) return false;
566+
if (log2MaxSamples > other.log2MaxSamples) return false;
567567
return true;
568568
}
569569

src/nbl/CMakeLists.txt

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,15 +83,13 @@ include(common)
8383

8484
#[[ Loaders and writers compile options available to edit by user
8585
All revelant _NBL_COMPILE_WITH will be there]]
86-
option(_NBL_COMPILE_WITH_MTL_LOADER_ "Compile with MTL Loader" ON)
87-
option(_NBL_COMPILE_WITH_OBJ_LOADER_ "Compile with OBJ Loader" ON)
86+
option(_NBL_COMPILE_WITH_MTL_LOADER_ "Compile with MTL Loader" OFF) #default off until Material Compiler 2
87+
option(_NBL_COMPILE_WITH_OBJ_LOADER_ "Compile with OBJ Loader" OFF) #default off until Material Compiler 2
8888
#option(_NBL_COMPILE_WITH_OBJ_WRITER_ "Compile with OBJ Writer" ON) uncomment when writer exists
89-
option(_NBL_COMPILE_WITH_STL_LOADER_ "Compile with STL Loader" ON)
89+
option(_NBL_COMPILE_WITH_STL_LOADER_ "Compile with STL Loader" OFF) #default off until Material Compiler 2
9090
option(_NBL_COMPILE_WITH_STL_WRITER_ "Compile with STL Writer" ON)
91-
option(_NBL_COMPILE_WITH_PLY_LOADER_ "Compile with PLY Loader" ON)
91+
option(_NBL_COMPILE_WITH_PLY_LOADER_ "Compile with PLY Loader" OFF) #default off until Material Compiler 2
9292
option(_NBL_COMPILE_WITH_PLY_WRITER_ "Compile with PLY Writer" ON)
93-
option(_NBL_COMPILE_WITH_BAW_LOADER_ "Compile with BAW Loader" OFF)
94-
option(_NBL_COMPILE_WITH_BAW_WRITER_ "Compile with BAW Writer" OFF)
9593
option(_NBL_COMPILE_WITH_JPG_LOADER_ "Compile with JPG Loader" ON)
9694
option(_NBL_COMPILE_WITH_JPG_WRITER_ "Compile with JPG Writer" ON)
9795
option(_NBL_COMPILE_WITH_PNG_LOADER_ "Compile with PNG Loader" ON)

0 commit comments

Comments
 (0)