Reorder normal calculation so no need to normalize position

kevyuu · kevyuu · commit 53f81af9da45 · 2025-07-18T22:11:42.000+07:00
diff --git a/src/nbl/asset/utils/CGeometryCreator.cpp b/src/nbl/asset/utils/CGeometryCreator.cpp
@@ -568,8 +568,8 @@ core::smart_refctd_ptr<ICPUPolygonGeometry> CGeometryCreator::createCylinder(
 	{
 		const auto f_i = static_cast<float>(i);
 		hlsl::float32_t3 p(std::cos(f_i * step), std::sin(f_i * step), 0.f);
+		const auto n = quantNormalCache->quantize<NormalCacheFormat>(p);
 		p *= radius;
-		const auto n = quantNormalCache->quantize<NormalCacheFormat>(hlsl::normalize(p));
 
 		positions[i] = { p.x, p.y, p.z };
 		memcpy(normals + i, &n, sizeof(n));

Original file line number	Diff line number	Diff line change
`@@ -568,8 +568,8 @@ core::smart_refctd_ptr<ICPUPolygonGeometry> CGeometryCreator::createCylinder(`
`568`	`568`	`{`
`569`	`569`	`const auto f_i = static_cast<float>(i);`
`570`	`570`	`hlsl::float32_t3 p(std::cos(f_i * step), std::sin(f_i * step), 0.f);`
	`571`	`+ const auto n = quantNormalCache->quantize<NormalCacheFormat>(p);`
`571`	`572`	`p *= radius;`
`572`		`- const auto n = quantNormalCache->quantize<NormalCacheFormat>(hlsl::normalize(p));`
`573`	`573`
`574`	`574`	`positions[i] = { p.x, p.y, p.z };`
`575`	`575`	`memcpy(normals + i, &n, sizeof(n));`