IImage isn't an IDescriptor, only views can be bound, also fix a nasty static_cast bug

Author: devsh

include/nbl/asset/IDescriptor.h

@@ -42,7 +42,7 @@ class IDescriptor : public virtual core::IReferenceCounted
 		{
 			EC_BUFFER = 0,
 			EC_SAMPLER,
-			EC_IMAGE,
+			EC_IMAGE, // TODO: rename to IMAGE_VIEW
 			EC_BUFFER_VIEW,
 			EC_ACCELERATION_STRUCTURE,
 			EC_COUNT

include/nbl/asset/IImage.h

@@ -58,7 +58,7 @@ inline bool operator==(const VkExtent3D& v1, const VkExtent3D& v2)
 }
 
 
-class IImage : public IDescriptor
+class IImage : public virtual core::IReferenceCounted
 {
 	public:
 		enum E_ASPECT_FLAGS : uint16_t
@@ -583,10 +583,6 @@ class IImage : public IDescriptor
 		}
 
 
-		//!
-		E_CATEGORY getTypeCategory() const override { return EC_IMAGE; }
-
-
 		inline const auto& getTexelBlockInfo() const
 		{
 			return info;

include/nbl/type_traits.h

@@ -254,6 +254,10 @@ struct pointer_to_nonconst_object
 template<typename T>
 using pointer_to_nonconst_object_t = typename pointer_to_nonconst_object<T>::type;
 
+
+template<typename T, typename U>
+constexpr bool are_related_v = std::is_base_of_v<T,U> || std::is_base_of_v<U,T>;
+
 }
 
 #endif

include/nbl/video/IDescriptorPool.h

@@ -100,9 +100,15 @@ class NBL_API2 IDescriptorPool : public IBackendObject
         virtual bool reset_impl() = 0;
 
     private:
+        // unfortunately according to the C++ spec this is a pile of UB that will never pass strict aliasing
         inline core::smart_refctd_ptr<asset::IDescriptor>* getDescriptorStorage(const asset::IDescriptor::E_TYPE type) const
         {
             core::smart_refctd_ptr<asset::IDescriptor>* baseAddress;
+//            static_assert(reintepret_castable_pointers_v<asset::IDescriptor,IGPUSampler>);
+//            static_assert(reintepret_castable_pointers_v<asset::IDescriptor,IGPUImageView>);
+//            static_assert(reintepret_castable_pointers_v<asset::IDescriptor,IGPUBufferView>);
+//            static_assert(reintepret_castable_pointers_v<asset::IDescriptor,IGPUBuffer>);
+//            static_assert(reintepret_castable_pointers_v<asset::IDescriptor,IGPUTopLevelAccelerationStructure>);
             switch (type)
             {
                 case asset::IDescriptor::E_TYPE::ET_SAMPLER:

src/nbl/asset/ICPUDescriptorSet.cpp

@@ -125,7 +125,7 @@ IAsset* ICPUDescriptorSet::getDependant_impl(size_t ix)
 				case IDescriptor::EC_SAMPLER:
 					return static_cast<ICPUSampler*>(desc);
 				case IDescriptor::EC_IMAGE:
-					return static_cast<ICPUImage*>(desc);
+					return static_cast<ICPUImageView*>(desc);
 				case IDescriptor::EC_BUFFER_VIEW:
 					return static_cast<ICPUBufferView*>(desc);
 				case IDescriptor::EC_ACCELERATION_STRUCTURE: