correct horrible allocator bugs

Author: devsh

include/nbl/core/alloc/AddressAllocatorBase.h

@@ -117,7 +117,7 @@ namespace core
                 return true;
             }
 
-            inline void*                getAddressOffset() const noexcept {return addressOffset;}
+            inline _size_type           getAddressOffset() const noexcept {return addressOffset;}
 
             inline const void*          getReservedSpacePtr() const noexcept {return reservedSpace;}
 

include/nbl/core/alloc/GeneralpurposeAddressAllocator.h

@@ -516,7 +516,7 @@ class GeneralpurposeAddressAllocator : public AddressAllocatorBase<Generalpurpos
 
 #ifdef _NBL_DEBUG
             // allocation must not be outside the buffer
-            assert(found.first.startOffset +bytes<=AllocStrategy::bufferSize);
+            assert(found.first.startOffset+bytes<=AllocStrategy::bufferSize);
             // sanity check
             assert(AllocStrategy::freeSize+bytes<=AllocStrategy::bufferSize);
 #endif // _NBL_DEBUG

include/nbl/core/alloc/LinearAddressAllocator.h

@@ -127,7 +127,7 @@ class LinearAddressAllocator : public AddressAllocatorBase<LinearAddressAllocato
         }
     protected:
         size_type bufferSize;
-        size_type       cursor;
+        size_type cursor;
 };
 
 

include/nbl/video/alloc/CAsyncSingleBufferSubAllocator.h

@@ -201,7 +201,7 @@ class CAsyncSingleBufferSubAllocator
             std::unique_lock<std::recursive_mutex> tLock(stAccessVerfier,std::try_to_lock_t());
             assert(tLock.owns_lock());
             #endif // _NBL_DEBUG
-            multi_deallocate(count,addr,bytes,{});
+           m_composed.multi_deallocate(count,addr,bytes);
         }
         // TODO: improve signature of this function in the future
         template<typename T=core::IReferenceCounted>

include/nbl/video/alloc/StreamingTransientDataBuffer.h

@@ -70,6 +70,9 @@ class StreamingTransientDataBuffer
         //
         inline size_type max_size() noexcept {return m_composed.max_size();}
 
+        // anyone gonna use it?
+        inline const auto& getAddressAllocator() const noexcept {return m_composed.getAddressAllocator();}
+
         // perfect forward to `Composed` method
         template<typename... Args>
         inline value_type multi_allocate(Args&&... args) noexcept
@@ -187,6 +190,8 @@ class StreamingTransientDataBufferMT : public core::IReferenceCounted
             return retval;
         }
 
+        //! you should really `this->get_lock()` if you need the guarantee that the state doesn't change
+        inline const auto& getAddressAllocator() const noexcept {return m_composed.getAddressAllocator();}
 
         template<typename... Args>
         inline size_type multi_allocate(Args&&... args) noexcept