Last PR comments

Author: deprilula28

include/nbl/video/SPhysicalDeviceLimits.h

@@ -182,7 +182,11 @@ struct SPhysicalDeviceLimits
     E_TRI_BOOLEAN shaderRoundingModeRTZFloat32 = ETB_DONT_KNOW;
     E_TRI_BOOLEAN shaderRoundingModeRTZFloat64 = ETB_DONT_KNOW;
 
-    //      or VK_EXT_descriptor_indexing:
+    // expose in 2 phases
+    // -Update After Bindand nonUniformEXT shader qualifier:
+    //      Descriptor Lifetime Tracking PR #345 will do this, cause I don't want to rewrite the tracking system again.
+    // -Actual Descriptor Indexing:
+    //      The whole 512k descriptor limits, runtime desc arrays, etc.will come later
     uint32_t maxUpdateAfterBindDescriptorsInAllPools = ~0u;
     bool shaderUniformBufferArrayNonUniformIndexingNative = false;
     bool shaderSampledImageArrayNonUniformIndexingNative = false;
@@ -211,9 +215,6 @@ struct SPhysicalDeviceLimits
     bool filterMinmaxSingleComponentFormats = false;
     bool filterMinmaxImageComponentMapping = false;
 
-    core::bitflag<asset::IImage::E_SAMPLE_COUNT_FLAGS> framebufferIntegerColorSampleCounts = asset::IImage::E_SAMPLE_COUNT_FLAGS(0u);
-
-
     /* Vulkan 1.3 Core  */
 
     //      or VK_EXT_subgroup_size_control:
@@ -533,6 +534,14 @@ struct SPhysicalDeviceLimits
     //! uint32_t              maxVertexInputAttributeOffset;
     //! uint32_t              maxVertexInputBindingStride;
 
+    /*
+    - Spec states minimum supported value should be at least ESCF_1_BIT
+    - it might be different for each integer format, best way is to query your integer format from physical device using vkGetPhysicalDeviceImageFormatProperties and get the sampleCounts
+    https://www.khronos.org/registry/vulkan/specs/1.3-extensions/man/html/VkImageFormatProperties.html
+    */
+    // [DO NOT EXPOSE] because it might be different for every texture format and usage
+    // core::bitflag<asset::IImage::E_SAMPLE_COUNT_FLAGS> framebufferIntegerColorSampleCounts = asset::IImage::E_SAMPLE_COUNT_FLAGS(0u);
+
     /*  Always enabled, reported as limits */
     bool shaderOutputViewportIndex = false;     // ALIAS: VK_EXT_shader_viewport_index_layer
     bool shaderOutputLayer = false;             // ALIAS: VK_EXT_shader_viewport_index_layer

src/nbl/video/CVulkanPhysicalDevice.h

@@ -298,11 +298,6 @@ class CVulkanPhysicalDevice final : public IPhysicalDevice
                 m_properties.limits.filterMinmaxImageComponentMapping = samplerFilterMinmaxProperties.filterMinmaxImageComponentMapping;
             }
 
-            if(apiVersion >= VK_MAKE_API_VERSION(0, 1, 2, 0))
-            {
-                m_properties.limits.framebufferIntegerColorSampleCounts =  core::bitflag<asset::IImage::E_SAMPLE_COUNT_FLAGS>(vulkan12Properties.framebufferIntegerColorSampleCounts);
-            }
-
             /* Vulkan 1.3 Core  */
             if(isExtensionSupported(VK_KHR_MAINTENANCE_4_EXTENSION_NAME))
                 m_properties.limits.maxBufferSize = maintanance4Properties.maxBufferSize;

src/nbl/video/IOpenGL_PhysicalDeviceBase.h

@@ -1171,8 +1171,6 @@ class IOpenGL_PhysicalDeviceBase : public IOpenGLPhysicalDeviceBase
 			m_properties.limits.filterMinmaxSingleComponentFormats = false;
 			m_properties.limits.filterMinmaxImageComponentMapping = false;
 
-			m_properties.limits.framebufferIntegerColorSampleCounts = framebufferSampleCountFlags;
-
 			/* Vulkan 1.3 Core  */
 			m_properties.limits.maxBufferSize = maxBufferSize;