Skip to content

Commit 58e19fc

Browse files
Example 53 has bugs (needs fixing)
Example 11 works beautifully, but not on Vulkan due to validation errors (mostly due to Buffer API).
1 parent 32a7916 commit 58e19fc

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

examples_tests/11.LoDSystem/main.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,8 @@ void addLoDTable(
114114

115115
poly <<= 1u;
116116
}
117-
auto gpumeshes = video::CAssetPreservingGPUObjectFromAssetConverter().getGPUObjectsFromAssets(cpumeshes, cpumeshes + LoDLevels, cpu2gpuParams);
117+
cpu2gpuParams.beginCommandBuffers();
118+
auto gpumeshes = video::CAssetPreservingGPUObjectFromAssetConverter().getGPUObjectsFromAssets(cpumeshes, cpumeshes+LoDLevels, cpu2gpuParams);
118119

119120
core::smart_refctd_ptr<video::IGPUGraphicsPipeline> pipeline;
120121
{
@@ -346,7 +347,7 @@ class LoDSystemApp : public ApplicationBase
346347
const auto swapchainImageUsage = static_cast<asset::IImage::E_USAGE_FLAGS>(asset::IImage::EUF_COLOR_ATTACHMENT_BIT | asset::IImage::EUF_TRANSFER_DST_BIT);
347348
const video::ISurface::SFormat surfaceFormat(asset::EF_B8G8R8A8_SRGB, asset::ECP_COUNT, asset::EOTF_UNKNOWN);
348349

349-
CommonAPI::InitWithDefaultExt(initOutput, video::EAT_OPENGL_ES, "Level of Detail System", WIN_W, WIN_H, FBO_COUNT, swapchainImageUsage, surfaceFormat, asset::EF_D32_SFLOAT);
350+
CommonAPI::InitWithDefaultExt(initOutput, video::EAT_OPENGL, "Level of Detail System", WIN_W, WIN_H, FBO_COUNT, swapchainImageUsage, surfaceFormat, asset::EF_D32_SFLOAT);
350351
window = std::move(initOutput.window);
351352
gl = std::move(initOutput.apiConnection);
352353
surface = std::move(initOutput.surface);

examples_tests/53.ComputeShaders/main.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ APP_CONSTRUCTOR(MeshLoadersApp)
236236
const auto swapchainImageUsage = static_cast<asset::IImage::E_USAGE_FLAGS>(asset::IImage::EUF_COLOR_ATTACHMENT_BIT);
237237
const video::ISurface::SFormat surfaceFormat(asset::EF_R8G8B8A8_SRGB, asset::ECP_COUNT, asset::EOTF_UNKNOWN);
238238

239-
CommonAPI::InitWithDefaultExt(initOutput, video::EAT_VULKAN, "MeshLoaders", WIN_W, WIN_H, FBO_COUNT, swapchainImageUsage, surfaceFormat, nbl::asset::EF_D32_SFLOAT);
239+
CommonAPI::InitWithDefaultExt(initOutput, video::EAT_VULKAN, "ComputeShaders", WIN_W, WIN_H, FBO_COUNT, swapchainImageUsage, surfaceFormat, nbl::asset::EF_D32_SFLOAT);
240240
window = std::move(initOutput.window);
241241
gl = std::move(initOutput.apiConnection);
242242
surface = std::move(initOutput.surface);

examples_tests/Readme.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ N = No support
4242
| FREE_SLOT | | | | | | | | | |
4343
| 09.ColorSpaceTest | W | W | W | W | W | W | W | W | |
4444
| 10.AllocatorTest | Y | Y | Y | S | S | S | N | N | |
45-
| 11.LoDSystem | Y | N | B | S | N | S | N | S | |
45+
| 11.LoDSystem | Y | Y | B | S | N | S | N | S | |
4646
| 12.glTF | W | N | W | W | N | W | N | W | COMPILE_WITH_GLTF_LOADER |
4747
| FREE_SLOT | | | | | | | | | |
4848
| 14.ComputeScan | Y | Y | B | S | S | S | S | S | |
@@ -84,7 +84,7 @@ N = No support
8484
| 50.NewAPITest | W | W | W | W | W | W | W | W | |
8585
| 51.RadixSort | W | N | W | W | N | W | N | W | |
8686
| 52.SystemTest | Y | Y | Y | S | S | S | S | S | |
87-
| 53.ComputeShaders | S | N | S | S | N | S | N | S | |
87+
| 53.ComputeShaders | B | B | B | S | N | S | N | S | |
8888
| 54.Transformations | Y | Y | B | S | S | S | S | S | |
8989
| 55.RGB18E7S3 | Y | Y | Y | S | S | S | N | N | |
9090
| 56.RayQuery | N | N | Y | N | N | S | N | S | |

0 commit comments

Comments
 (0)