seems APK archive doesn't need to hang onto JNI

Author: devshgraphicsprogramming

src/nbl/system/CAPKResourcesArchive.cpp

@@ -4,16 +4,15 @@ using namespace nbl;
 using namespace nbl::system;
 
 #ifdef _NBL_PLATFORM_ANDROID_
-#include <jni.h>
 #include <android/native_activity.h>
 #include <android/asset_manager.h>
 
-CAPKResourcesArchive::CAPKResourcesArchive(const path& _path, system::logger_opt_smart_ptr&& logger, ANativeActivity* act, JNIEnv* jni)
-	: CFileArchive(path(_path),std::move(logger),computeItems(_path.string())), m_mgr(act->assetManager), m_activity(act), m_jniEnv(jni)
+CAPKResourcesArchive::CAPKResourcesArchive(const path& _path, system::logger_opt_smart_ptr&& logger, ANativeActivity* act, JNIEnv* jniEnv)
+	: CFileArchive(path(_path),std::move(logger),computeItems(_path.string(),act->assetManager,jniEnv)), m_mgr(act->assetManager), m_activity(act)
 {
 }
 
-core::vector<IFileArchive::SListEntry> CAPKResourcesArchive::computeItems(const std::string& asset_path)
+core::vector<IFileArchive::SListEntry> CAPKResourcesArchive::computeItems(const std::string& asset_path, AAssetManager* mgr, JNIEnv* env)
 {
 	auto context_object = activity->clazz;
 	auto getAssets_method = env->GetMethodID(env->GetObjectClass(context_object), "getAssets", "()Landroid/content/res/AssetManager;");
@@ -39,7 +38,7 @@ core::vector<IFileArchive::SListEntry> CAPKResourcesArchive::computeItems(const
 			auto& item = result.emplace_back();
 			item.pathRelativeToArchive = filename;
 			{
-				AAsset* asset = AAssetManager_open(m_mgr,filename,AASSET_MODE_STREAMING);
+				AAsset* asset = AAssetManager_open(mgr,filename,AASSET_MODE_STREAMING);
 				item.size = AAsset_getLength(asset);
 				AAsset_close(asset);
 			}
@@ -57,7 +56,7 @@ core::vector<IFileArchive::SListEntry> CAPKResourcesArchive::computeItems(const
 CFileArchive::file_buffer_t CAPKResourcesArchive::getFileBuffer(const IFileArchive::SListEntry* item)
 {
 	AAsset* asset = AAssetManager_open(m_mgr,item->pathRelativeToArchive.string().c_str(),AASSET_MODE_BUFFER);
-	return {const_cast<void*>(AAsset_getBuffer(asset)),AAsset_getLength(asset),asset};
+	return {const_cast<void*>(AAsset_getBuffer(asset)),static_cast<size_t>(AAsset_getLength(asset)),asset};
 }
 
 #endif

src/nbl/system/CAPKResourcesArchive.h

@@ -17,7 +17,7 @@ namespace nbl::system
 class CAPKResourcesArchive final : public CFileArchive
 {
 	public:
-		CAPKResourcesArchive(const path& _path, system::logger_opt_smart_ptr&& logger, ANativeActivity* act, JNIEnv* jni);
+		CAPKResourcesArchive(const path& _path, system::logger_opt_smart_ptr&& logger, ANativeActivity* act, JNIEnv* jniEnv);
 
 	protected:
 		static core::vector<SListEntry> computeItems(const std::string& asset_path);
@@ -26,7 +26,6 @@ class CAPKResourcesArchive final : public CFileArchive
 
 
 		AAssetManager* m_mgr;
-		JNIEnv* m_jniEnv;
 		ANativeActivity* m_activity;
 };