Skip to content

Commit 695243a

Browse files
committed
Temp Format Promotion Fix for Vulkan
1 parent 847a7f2 commit 695243a

File tree

1 file changed

+13
-20
lines changed

1 file changed

+13
-20
lines changed

examples_tests/common/CommonAPI.h

Lines changed: 13 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1243,31 +1243,24 @@ class CommonAPI
12431243
#endif
12441244
if(!headlessCompute)
12451245
{
1246-
nbl::video::ISurface::SFormat requestedFormat;
1246+
nbl::video::ISurface::SFormat requestedFormat = surfaceFormat;
12471247
if(api_type == EAT_VULKAN)
12481248
{
1249-
requestedFormat.format = (surfaceFormat.format == nbl::asset::EF_UNKNOWN)
1250-
? nbl::asset::EF_B8G8R8A8_SRGB
1251-
: surfaceFormat.format;
1252-
requestedFormat.colorSpace.eotf = (surfaceFormat.colorSpace.eotf == nbl::asset::EOTF_UNKNOWN)
1253-
? nbl::asset::EOTF_sRGB
1254-
: surfaceFormat.colorSpace.eotf;
1255-
requestedFormat.colorSpace.primary = (surfaceFormat.colorSpace.primary == nbl::asset::ECP_COUNT)
1256-
? nbl::asset::ECP_SRGB
1257-
: surfaceFormat.colorSpace.primary;
1249+
if (requestedFormat.format == nbl::asset::EF_UNKNOWN || requestedFormat.format == asset::EF_R8G8B8A8_SRGB)
1250+
{
1251+
requestedFormat.format = nbl::asset::EF_B8G8R8A8_SRGB;
1252+
requestedFormat.colorSpace.eotf = nbl::asset::EOTF_sRGB;
1253+
requestedFormat.colorSpace.primary = nbl::asset::ECP_SRGB;
1254+
}
12581255
}
12591256
else
12601257
{
1261-
// Temporary to make previous examples work
1262-
requestedFormat.format = (surfaceFormat.format == nbl::asset::EF_UNKNOWN)
1263-
? nbl::asset::EF_R8G8B8A8_SRGB
1264-
: surfaceFormat.format;
1265-
requestedFormat.colorSpace.eotf = (surfaceFormat.colorSpace.eotf == nbl::asset::EOTF_UNKNOWN)
1266-
? nbl::asset::EOTF_sRGB
1267-
: surfaceFormat.colorSpace.eotf;
1268-
requestedFormat.colorSpace.primary = (surfaceFormat.colorSpace.primary == nbl::asset::ECP_COUNT)
1269-
? nbl::asset::ECP_SRGB
1270-
: surfaceFormat.colorSpace.primary;
1258+
if (requestedFormat.format == nbl::asset::EF_UNKNOWN)
1259+
{
1260+
requestedFormat.format = nbl::asset::EF_R8G8B8A8_SRGB;
1261+
requestedFormat.colorSpace.eotf = nbl::asset::EOTF_sRGB;
1262+
requestedFormat.colorSpace.primary = nbl::asset::ECP_SRGB;
1263+
}
12711264
}
12721265
result.swapchain = createSwapchain(api_type, gpuInfo, sc_image_count, window_width, window_height, result.logicalDevice, result.surface, swapchainImageUsage, nbl::video::ISurface::EPM_FIFO_RELAXED, requestedFormat);
12731266
assert(result.swapchain);

0 commit comments

Comments
 (0)