Rename visitDependentsImpl to visitDependents_impl

kevyuu · kevyuu · commit 6a84bd7cf9ff · 2025-06-14T19:12:07.000+07:00
diff --git a/include/nbl/asset/IAsset.h b/include/nbl/asset/IAsset.h
@@ -158,7 +158,7 @@ class IAsset : virtual public core::IReferenceCounted
 
 		inline void visitDependents(std::function<bool(const IAsset*)> visit) const
 		{
-				visitDependentsImpl([&visit](const IAsset* dep)->bool
+				visitDependents_impl([&visit](const IAsset* dep)->bool
         {
             if (dep)
                 return visit(dep);
@@ -190,7 +190,7 @@ class IAsset : virtual public core::IReferenceCounted
 		friend IAssetManager;
 		bool m_mutable = true;
 
-		virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const = 0;
+		virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const = 0;
 };
 
 template<typename T>
diff --git a/include/nbl/asset/ICPUAccelerationStructure.h b/include/nbl/asset/ICPUAccelerationStructure.h
@@ -248,7 +248,7 @@ class ICPUBottomLevelAccelerationStructure final : public IPreHashed, public IBo
 		core::smart_refctd_dynamic_array<uint32_t> m_geometryPrimitiveCount = nullptr;
 		core::bitflag<BUILD_FLAGS> m_buildFlags = BUILD_FLAGS::PREFER_FAST_TRACE_BIT;
 
-		inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override {}
+		inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override {}
 };
 
 class ICPUTopLevelAccelerationStructure final : public IAsset, public ITopLevelAccelerationStructure
@@ -360,7 +360,7 @@ class ICPUTopLevelAccelerationStructure final : public IAsset, public ITopLevelA
 		hlsl::acceleration_structures::top_level::BuildRangeInfo m_buildRangeInfo;
 		core::bitflag<BUILD_FLAGS> m_buildFlags = BUILD_FLAGS::PREFER_FAST_BUILD_BIT;
 
-		inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+		inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
     {
         for (const auto& instance : *m_instances)
             if (!visit(instance.getBase().blas.get())) return;
diff --git a/include/nbl/asset/ICPUAnimationLibrary.h b/include/nbl/asset/ICPUAnimationLibrary.h
@@ -98,7 +98,7 @@ class ICPUAnimationLibrary final : public IAnimationLibrary<ICPUBuffer>, public
 
   private:
 
-		virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+		virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
     {
         if (!visit(m_keyframeStorageBinding.buffer.get())) return;
         if (!visit(m_timestampStorageBinding.buffer.get())) return;
diff --git a/include/nbl/asset/ICPUBuffer.h b/include/nbl/asset/ICPUBuffer.h
@@ -129,7 +129,7 @@ class ICPUBuffer final : public asset::IBuffer, public IPreHashed
         discardContent_impl();
     }
 
-    inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override {}
+    inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override {}
 
     void* m_data;
     core::smart_refctd_ptr<core::refctd_memory_resource> m_mem_resource;
diff --git a/include/nbl/asset/ICPUBufferView.h b/include/nbl/asset/ICPUBufferView.h
@@ -51,7 +51,7 @@ class ICPUBufferView : public IBufferView<ICPUBuffer>, public IAsset
 
   private:
 
-		inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+		inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
 		{
         if (!visit(m_buffer.get())) return;
 		}
diff --git a/include/nbl/asset/ICPUComputePipeline.h b/include/nbl/asset/ICPUComputePipeline.h
@@ -88,7 +88,7 @@ class ICPUComputePipeline final : public ICPUPipeline<IComputePipeline<ICPUPipel
           base_t(layout, {})
           {}
         
-        virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+        virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
         {
             if (!visit(m_layout.get())) return;
             if (!visit(m_specInfo.shader.get())) return;
diff --git a/include/nbl/asset/ICPUDescriptorSet.h b/include/nbl/asset/ICPUDescriptorSet.h
@@ -85,7 +85,7 @@ class NBL_API2 ICPUDescriptorSet final : public IDescriptorSet<ICPUDescriptorSet
 
 		core::smart_refctd_dynamic_array<ICPUDescriptorSet::SDescriptorInfo> m_descriptorInfos[static_cast<uint32_t>(IDescriptor::E_TYPE::ET_COUNT)];
 
-    virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+    virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
     {
         for (auto i = 0u; i < static_cast<uint32_t>(IDescriptor::E_TYPE::ET_COUNT); i++)
         {
diff --git a/include/nbl/asset/ICPUDescriptorSetLayout.h b/include/nbl/asset/ICPUDescriptorSetLayout.h
@@ -63,7 +63,7 @@ class ICPUDescriptorSetLayout : public IDescriptorSetLayout<ICPUSampler>, public
       
   private:
 
-      inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+      inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
       {
           if (m_immutableSamplers) return;
           for (const auto& sampler : *m_immutableSamplers)
diff --git a/include/nbl/asset/ICPUGraphicsPipeline.h b/include/nbl/asset/ICPUGraphicsPipeline.h
@@ -127,7 +127,7 @@ class ICPUGraphicsPipeline final : public ICPUPipeline<IGraphicsPipeline<ICPUPip
             return core::smart_refctd_ptr<base_t>(newPipeline, core::dont_grab);
         }
 
-        inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+        inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
         {
             if (!visit(m_layout.get())) return;
             if (!visit(m_renderpass.get())) return;
diff --git a/include/nbl/asset/ICPUImage.h b/include/nbl/asset/ICPUImage.h
@@ -217,7 +217,7 @@ class NBL_API2 ICPUImage final : public IImage, public IPreHashed
 			}
 		};
 
-    inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+    inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
     {
     }
 };
diff --git a/include/nbl/asset/ICPUImageView.h b/include/nbl/asset/ICPUImageView.h
@@ -67,7 +67,7 @@ class ICPUImageView final : public IImageView<ICPUImage>, public IAsset
 
   private:
 
-    inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+    inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
     {
         if (!visit(params.image.get())) return;
     }
diff --git a/include/nbl/asset/ICPUMesh.h b/include/nbl/asset/ICPUMesh.h
@@ -86,7 +86,7 @@ class ICPUMesh final : public IMesh<ICPUMeshBuffer>, public IAsset
 	private:
 		core::vector<core::smart_refctd_ptr<ICPUMeshBuffer>> m_meshBuffers;
 
-        inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+        inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
         {
         }
 };
diff --git a/include/nbl/asset/ICPUMeshBuffer.h b/include/nbl/asset/ICPUMeshBuffer.h
@@ -611,7 +611,7 @@ class ICPUMeshBuffer final : public IMeshBuffer<ICPUBuffer,ICPUDescriptorSet,ICP
             return const_cast<core::aabbox3df*>(const_cast<const ICPUMeshBuffer*>(this)->getJointAABBs());
         }
 
-        inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+        inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
         {
         }
 };
diff --git a/include/nbl/asset/ICPUPipelineCache.h b/include/nbl/asset/ICPUPipelineCache.h
@@ -93,7 +93,7 @@ class ICPUPipelineCache final : public IPreHashed
 	private:
 		entries_map_t m_cache;
 
-		inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+		inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
 		{
 		}
 };
diff --git a/include/nbl/asset/ICPUPipelineLayout.h b/include/nbl/asset/ICPUPipelineLayout.h
@@ -69,7 +69,7 @@ class ICPUPipelineLayout : public IAsset, public IPipelineLayout<ICPUDescriptorS
     protected:
 		virtual ~ICPUPipelineLayout() = default;
 
-      inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+      inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
       {
           for (auto i = 0; i < m_descSetLayouts.size(); i++)
           {
diff --git a/include/nbl/asset/ICPURayTracingPipeline.h b/include/nbl/asset/ICPURayTracingPipeline.h
@@ -116,21 +116,14 @@ class ICPURayTracingPipeline final : public ICPUPipeline<IRayTracingPipeline<ICP
             : base_t(layout, {})
             {}
 
-        inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+        inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
         {
-            core::unordered_set<const IAsset*> dependants;
-            const auto visitOnce = [&](const IAsset* dep) -> bool {
-                auto [iter, inserted] = dependants.insert(dep);
-                if (inserted) return visit(dep);
-                return true;
-            };
-            visitOnce(m_raygen.shader.get());
-            for (const auto& missInfo : self->m_misses) visitOnce(missInfo.shader.get());
-            for (const auto& anyHitInfo : self->m_hitGroups.anyHits) visitOnce(anyHitInfo.shader.get());
-            for (const auto& closestHitInfo : self->m_hitGroups.closestHits) visitOnce(closestHitInfo.shader.get());
-            for (const auto& intersectionInfo : self->m_hitGroups.intersections) visitOnce(intersectionInfo.shader.get());
-            for (const auto& callableInfo : self->m_callables) visitOnce(callableInfo.shader.get());
-
+            if (!visit(m_raygen.shader.get()) return;
+            for (const auto& missInfo : self->m_misses) if (!visit(missInfo.shader.get())) return;
+            for (const auto& anyHitInfo : self->m_hitGroups.anyHits) if (!visit(anyHitInfo.shader.get())) return;
+            for (const auto& closestHitInfo : self->m_hitGroups.closestHits) if (!visit(closestHitInfo.shader.get())) return;
+            for (const auto& intersectionInfo : self->m_hitGroups.intersections) if (!visit(intersectionInfo.shader.get())) return;
+            for (const auto& callableInfo : self->m_callables) if(!visit(callableInfo.shader.get())) return;
         }
 
         inline core::smart_refctd_ptr<base_t> clone_impl(core::smart_refctd_ptr<ICPUPipelineLayout>&& layout, uint32_t depth) const override final
diff --git a/include/nbl/asset/ICPURenderpass.h b/include/nbl/asset/ICPURenderpass.h
@@ -44,7 +44,7 @@ class ICPURenderpass : public IRenderpass, public IAsset
 
     private:
 
-        inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+        inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
         {
         }
 
diff --git a/include/nbl/asset/ICPURenderpassIndependentPipeline.h b/include/nbl/asset/ICPURenderpassIndependentPipeline.h
@@ -150,7 +150,7 @@ class ICPURenderpassIndependentPipeline : public IRenderpassIndependentPipeline,
 
   private:
 
-    inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+    inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
     {
     }
 };
diff --git a/include/nbl/asset/ICPUSampler.h b/include/nbl/asset/ICPUSampler.h
@@ -71,7 +71,7 @@ class ICPUSampler : public ISampler, public IAsset
 		
   private:
 
-    inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+    inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
     {
     }
 };
diff --git a/include/nbl/asset/ICPUSkeleton.h b/include/nbl/asset/ICPUSkeleton.h
@@ -81,7 +81,7 @@ class ICPUSkeleton final : public ISkeleton<ICPUBuffer>, public IAsset
 
   private:
 
-		inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+		inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
 		{
         if (!visit(m_defaultTransforms.buffer.get())) return;
 				if (!visit(m_parentJointIDs.buffer.get())) return;
diff --git a/include/nbl/asset/IShader.h b/include/nbl/asset/IShader.h
@@ -99,7 +99,7 @@ class IShader : public IAsset
 
   private:
 
-    inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+    inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
     {
         if (!visit(m_code.get())) return;
     }

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ class IAsset : virtual public core::IReferenceCounted`
`158`	`158`
`159`	`159`	`inline void visitDependents(std::function<bool(const IAsset*)> visit) const`
`160`	`160`	`{`
`161`		`- visitDependentsImpl([&visit](const IAsset* dep)->bool`
	`161`	`+ visitDependents_impl([&visit](const IAsset* dep)->bool`
`162`	`162`	`{`
`163`	`163`	`if (dep)`
`164`	`164`	`return visit(dep);`
`@@ -190,7 +190,7 @@ class IAsset : virtual public core::IReferenceCounted`
`190`	`190`	`friend IAssetManager;`
`191`	`191`	`bool m_mutable = true;`
`192`	`192`
`193`		`- virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const = 0;`
	`193`	`+ virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const = 0;`
`194`	`194`	`};`
`195`	`195`
`196`	`196`	`template<typename T>`
Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ class ICPUAnimationLibrary final : public IAnimationLibrary<ICPUBuffer>, public`
`98`	`98`
`99`	`99`	`private:`
`100`	`100`
`101`		`- virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override`
	`101`	`+ virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override`
`102`	`102`	`{`
`103`	`103`	`if (!visit(m_keyframeStorageBinding.buffer.get())) return;`
`104`	`104`	`if (!visit(m_timestampStorageBinding.buffer.get())) return;`
Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ class ICPUBuffer final : public asset::IBuffer, public IPreHashed`
`129`	`129`	`discardContent_impl();`
`130`	`130`	`}`
`131`	`131`
`132`		`- inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override {}`
	`132`	`+ inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override {}`
`133`	`133`
`134`	`134`	`void* m_data;`
`135`	`135`	`core::smart_refctd_ptr<core::refctd_memory_resource> m_mem_resource;`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ class ICPUBufferView : public IBufferView<ICPUBuffer>, public IAsset`
`51`	`51`
`52`	`52`	`private:`
`53`	`53`
`54`		`- inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override`
	`54`	`+ inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override`
`55`	`55`	`{`
`56`	`56`	`if (!visit(m_buffer.get())) return;`
`57`	`57`	`}`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ class ICPUComputePipeline final : public ICPUPipeline<IComputePipeline<ICPUPipel`
`88`	`88`	`base_t(layout, {})`
`89`	`89`	`{}`
`90`	`90`
`91`		`- virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override`
	`91`	`+ virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override`
`92`	`92`	`{`
`93`	`93`	`if (!visit(m_layout.get())) return;`
`94`	`94`	`if (!visit(m_specInfo.shader.get())) return;`
Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ class NBL_API2 ICPUDescriptorSet final : public IDescriptorSet<ICPUDescriptorSet`
`85`	`85`
`86`	`86`	`core::smart_refctd_dynamic_array<ICPUDescriptorSet::SDescriptorInfo> m_descriptorInfos[static_cast<uint32_t>(IDescriptor::E_TYPE::ET_COUNT)];`
`87`	`87`
`88`		`- virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override`
	`88`	`+ virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override`
`89`	`89`	`{`
`90`	`90`	`for (auto i = 0u; i < static_cast<uint32_t>(IDescriptor::E_TYPE::ET_COUNT); i++)`
`91`	`91`	`{`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ class ICPUDescriptorSetLayout : public IDescriptorSetLayout<ICPUSampler>, public`
`63`	`63`
`64`	`64`	`private:`
`65`	`65`
`66`		`- inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override`
	`66`	`+ inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override`
`67`	`67`	`{`
`68`	`68`	`if (m_immutableSamplers) return;`
`69`	`69`	`for (const auto& sampler : *m_immutableSamplers)`
Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ class ICPUGraphicsPipeline final : public ICPUPipeline<IGraphicsPipeline<ICPUPip`
`127`	`127`	`return core::smart_refctd_ptr<base_t>(newPipeline, core::dont_grab);`
`128`	`128`	`}`
`129`	`129`
`130`		`- inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override`
	`130`	`+ inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override`
`131`	`131`	`{`
`132`	`132`	`if (!visit(m_layout.get())) return;`
`133`	`133`	`if (!visit(m_renderpass.get())) return;`
Original file line number	Diff line number	Diff line change
`@@ -217,7 +217,7 @@ class NBL_API2 ICPUImage final : public IImage, public IPreHashed`
`217`	`217`	`}`
`218`	`218`	`};`
`219`	`219`
`220`		`- inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override`
	`220`	`+ inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override`
`221`	`221`	`{`
`222`	`222`	`}`
`223`	`223`	`};`