remind self to never reinterpret_cast between virtual base and derived

Author: devsh

include/nbl/video/IGPUCommandBuffer.h

@@ -884,7 +884,7 @@ class NBL_API2 IGPUCommandBuffer : public IBackendObject
         // If the user wants the builds to be tracking, and make the TLAS remember the BLASes that have been built into it.
         // NOTE: We know that a TLAS may be rebuilt multiple times per frame on purpose and not only the final BLASes need to be kept alive till submission finishes.
         // However, the Command Pool already tracks resources referenced in the Build Infos, so we only need pointers into those records.
-        core::unordered_map<IGPUTopLevelAccelerationStructure*,std::span<const IGPUTopLevelAccelerationStructure::blas_smart_ptr_t>> m_TLASToBLASReferenceSets;
+        core::unordered_map<IGPUTopLevelAccelerationStructure*,std::span<const core::smart_refctd_ptr<const IReferenceCounted>>> m_TLASToBLASReferenceSets;
 
         const IGPUGraphicsPipeline* m_boundGraphicsPipeline;
         const IGPUComputePipeline* m_boundComputePipeline;

include/nbl/video/ILogicalDevice.h

@@ -580,7 +580,7 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe
                     }
 
                     // the rawpointers are already smartpointers in whatever else the `fillTracking` declared above writes
-                    core::unordered_map<IGPUTopLevelAccelerationStructure*,std::span<const IGPUTopLevelAccelerationStructure::blas_smart_ptr_t>> m_TLASToBLASReferenceSets;
+                    core::unordered_map<IGPUTopLevelAccelerationStructure*,std::span<const core::smart_refctd_ptr<const IReferenceCounted>>> m_TLASToBLASReferenceSets;
                 } callback = {};
 
                 auto& tracking = deferredOperation->m_resourceTracking;
@@ -593,7 +593,7 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe
                     {
                         const auto blasCount = info.trackedBLASes.size();
                         if (blasCount)
-                            callback.m_TLASToBLASReferenceSets[info.dstAS] = {reinterpret_cast<const IGPUTopLevelAccelerationStructure::blas_smart_ptr_t*>(oit-blasCount),blasCount};
+                            callback.m_TLASToBLASReferenceSets[info.dstAS] = {oit-blasCount,blasCount};
                         else
                             callback.m_TLASToBLASReferenceSets[info.dstAS] = {};
                     }

src/nbl/video/IGPUCommandBuffer.cpp

@@ -843,7 +843,7 @@ uint32_t IGPUCommandBuffer::buildAccelerationStructures_common(const std::span<c
         {
             const auto blasCount = info.trackedBLASes.size();
             if (blasCount)
-                m_TLASToBLASReferenceSets[info.dstAS] = {reinterpret_cast<const IGPUTopLevelAccelerationStructure::blas_smart_ptr_t*>(oit-blasCount),blasCount};
+                m_TLASToBLASReferenceSets[info.dstAS] = {oit-blasCount,blasCount};
             else
                 m_TLASToBLASReferenceSets[info.dstAS] = {};
         }

src/nbl/video/IQueue.cpp

@@ -157,7 +157,11 @@ IQueue::DeferredSubmitCallback::DeferredSubmitCallback(const SSubmitInfo& info)
         {
             const auto tlas = refSet.first;
             // in theory could assert no duplicate entries, but thats obvious
-            m_TLASToBLASReferenceSets[tlas] = { .m_BLASes = {refSet.second.begin(),refSet.second.end()}, .m_buildVer = tlas->registerNextBuildVer()};
+            auto& out = m_TLASToBLASReferenceSets[tlas];
+            out.m_BLASes.reserve(refSet.second.size());
+            for (const auto& refCtd : refSet.second)
+                out.m_BLASes.emplace(dynamic_cast<const IGPUBottomLevelAccelerationStructure*>(refCtd.get()));
+            out.m_buildVer = tlas->registerNextBuildVer();
         }
     }
     // We don't hold the last signal semaphore, because the timeline does as an Event trigger.