remove more silly stuff

Author: devshgraphicsprogramming

include/ISceneManager.h

@@ -34,11 +34,9 @@ namespace scene
 	class IDummyTransformationSceneNode;
 	class IMeshLoader;
 	class IMeshSceneNode;
-	class IMeshSceneNodeInstanced;
 	class IMeshWriter;
 	class ISceneNode;
 	class ISceneNodeAnimator;
-	class ISceneNodeAnimatorCollisionResponse;
 
 	//! The Scene Manager manages scene nodes, mesh recources, cameras and all the other stuff.
 	/** All Scene nodes can be created only here. There is a always growing
@@ -193,15 +191,6 @@ namespace scene
 		virtual IDummyTransformationSceneNode* addDummyTransformationSceneNode(
 			IDummyTransformationSceneNode* parent=0, int32_t id=-1) = 0;
 
-		//! Gets the root scene node.
-		/** This is the scene node which is parent
-		of all scene nodes. The root scene node is a special scene node which
-		only exists to manage all scene nodes. It will not be rendered and cannot
-		be removed from the scene.
-		\return Pointer to the root scene node.
-		This pointer should not be dropped. See IReferenceCounted::drop() for more information. */
-		virtual ISceneNode* getRootSceneNode() = 0;
-
 		//! Get the current active camera.
 		/** \return The active camera is returned. Note that this can
 		be NULL, if there was no camera created yet.
@@ -213,17 +202,6 @@ namespace scene
 		\param camera: The new camera which should be active. */
 		virtual void setActiveCamera(ICameraSceneNode* camera) = 0;
 
-		//! Adds a scene node to the deletion queue.
-		/** The scene node is immediatly
-		deleted when it's secure. Which means when the scene node does not
-		execute animators and things like that. This method is for example
-		used for deleting scene nodes by their scene node animators. In
-		most other cases, a ISceneNode::remove() call is enough, using this
-		deletion queue is not necessary.
-		See ISceneManager::createDeleteAnimator() for details.
-		\param node: Node to detete. */
-		virtual void addToDeletionQueue(IDummyTransformationSceneNode* node) = 0;
-
 		//! Posts an input event to the environment.
 		/** Usually you do not have to
 		use this method, it is used by the internal engine. */

include/splines.h

@@ -18,9 +18,22 @@ namespace core
 {
 
 // TODO @Przemog
-// TODO: Rename to Follow Curve Animator
-// TODO: Refactor into an interpolator so we can use it for rotations too
+// TODO: Refactor the base into an interpolator so we can use it for rotations too (in `core`)
+    // control points
+    // looping, finishing or pingponging (repeat, clamp or mirror)
+    // do what `getPos_fromParameter` does but call it `getValue`
+    // do what `getUnnormDirection_fromParameter` does but call it `getDerivativeAndTangent`
+// TODO: Refactor the other functionality Follow Curve Animator (in `scene`)
+    // need `getSplineLength` as `getCurveLength`
+    // info about segments
+    // info about arclength being precise (for many splines its not because arclength integrals are not fun)
+    // for the Follow Spine Animators (derived from interpolator)
+        // implement `_fromParameter` as simple passthroughs
+        // remember that `getPos` and `getUnnormDirection` need to be implemented in arclength (so the object can follow at constant speed)
+// TODO: Implement a FollowCircle or FollowEllipsoid derived from Follow Curve Animator
+    // 
 // TODO: Refactor the `BlockChange` stuff into an ext::baw::Animators
+    // all the methods with `BlockChange` in the name
 class ISpline// : public AllocationOverrideDefault
 {
     public:

source/Nabla/CSceneManager.cpp

@@ -44,8 +44,6 @@ CSceneManager::CSceneManager(IrrlichtDevice* device, video::IVideoDriver* driver
 //! destructor
 CSceneManager::~CSceneManager()
 {
-	clearDeletionList();
-
 	if (CursorControl)
 		CursorControl->drop();
 
@@ -166,16 +164,6 @@ IDummyTransformationSceneNode* CSceneManager::addDummyTransformationSceneNode(
 	return node;
 }
 
-//! Returns the root scene node. This is the scene node wich is parent
-//! of all scene nodes. The root scene node is a special scene node which
-//! only exists to manage all scene nodes. It is not rendered and cannot
-//! be removed from the scene.
-//! \return Returns a pointer to the root scene node.
-ISceneNode* CSceneManager::getRootSceneNode()
-{
-	return this;
-}
-
 
 //! Returns the current active camera.
 //! \return The active camera is returned. Note that this can be NULL, if there
@@ -233,32 +221,6 @@ void CSceneManager::OnAnimate(uint32_t timeMs)
     }
 }
 
-//! Adds a scene node to the deletion queue.
-void CSceneManager::addToDeletionQueue(IDummyTransformationSceneNode* node)
-{
-	if (!node)
-		return;
-
-	node->grab();
-	DeletionList.push_back(node);
-}
-
-
-//! clears the deletion list
-void CSceneManager::clearDeletionList()
-{
-	if (DeletionList.empty())
-		return;
-
-	for (uint32_t i=0; i<DeletionList.size(); ++i)
-	{
-		DeletionList[i]->remove();
-		DeletionList[i]->drop();
-	}
-
-	DeletionList.clear();
-}
-
 //! Posts an input event to the environment. Usually you do not have to
 //! use this method, it is used by the internal engine.
 bool CSceneManager::receiveIfEventReceiverDidNotAbsorb(const SEvent& event)

source/Nabla/CSceneManager.h

@@ -88,13 +88,6 @@ namespace scene
 		virtual IDummyTransformationSceneNode* addDummyTransformationSceneNode(
 			IDummyTransformationSceneNode* parent=0, int32_t id=-1);
 
-		//! Returns the root scene node. This is the scene node wich is parent
-		//! of all scene nodes. The root scene node is a special scene node which
-		//! only exists to manage all scene nodes. It is not rendered and cannot
-		//! be removed from the scene.
-		//! \return Pointer to the root scene node.
-		virtual ISceneNode* getRootSceneNode();
-
 		//! Returns the current active camera.
 		//! \return The active camera is returned. Note that this can be NULL, if there
 		//! was no camera created yet.
@@ -104,10 +97,6 @@ namespace scene
 		//! \param camera: The new camera which should be active.
 		virtual void setActiveCamera(ICameraSceneNode* camera);
 
-
-		//! Adds a scene node to the deletion queue.
-		virtual void addToDeletionQueue(IDummyTransformationSceneNode* node);
-
 		//! Posts an input event to the environment. Usually you do not have to
 		//! use this method, it is used by the internal engine.
 		virtual bool receiveIfEventReceiverDidNotAbsorb(const SEvent& event);

source/Nabla/CSceneNodeAnimatorFlyCircle.cpp

@@ -229,7 +229,6 @@ ${NBL_ROOT_PATH}/source/Nabla/CSceneManager.cpp
 ${NBL_ROOT_PATH}/source/Nabla/CSceneNodeAnimatorCameraFPS.cpp
 	${NBL_ROOT_PATH}/source/Nabla/CSceneNodeAnimatorCameraMaya.cpp
 	${NBL_ROOT_PATH}/source/Nabla/CSceneNodeAnimatorCameraModifiedMaya.cpp
-	${NBL_ROOT_PATH}/source/Nabla/CSceneNodeAnimatorFlyCircle.cpp
 )
 set(NABLA_SRCS_COMMON
 	${NBL_CORE_SOURCES}

source/Nabla/CSceneNodeAnimatorFlyCircle.h

@@ -108,7 +108,6 @@
 #include "CWriteFile.h"
 #include "CZipReader.h"
 #include "FW_Mutex.h" // refactor
-#include "ISceneNodeAnimatorFinishing.h"
 #include "os.h"
 */