not the best error bounding solution in the world but seems to work

Author: devshgraphicsprogramming

examples_tests/22.RaytracedAO/closestHit.comp

@@ -90,29 +90,22 @@ void main()
 				);
 
 				vec3 origin_error;
-				const float compactBary_error = 0.f; // TODO:
+				const float compactBary_error = nbl_glsl_ieee754_gamma(1u);
 				const vec3 origin = nbl_glsl_interpolate_with_bounds(origin_error,dPdBary,dPdBary_error,lastVxPos,lastVxPos_error,compactBary,compactBary_error);
 
 				generate_next_rays(
 					MAX_RAYS_GENERATED,material,frontfacing,vertex_depth,scramble_start_state,
 					sampleID,outPixelLocation,origin,origin_error,throughput
 				);
 			}
-	#if 1	
-			if (vertex_depth!=2u)
-				emissive = vec3(0.f);
-			else
-				emissive = frontfacing ? vec3(0.f,10.f,0.f):vec3(10.f,0.f,0.f);
-	#endif
 		}
-	#if 1
+
 		// TODO: finish MIS
 		vec3 acc;
 		const uvec3 accumulationLocation = uvec3(outPixelLocation,sampleID%staticViewData.samplesPerPixelPerDispatch);
 		const bool first_accumulating_path_vertex = accumulationLocation.z!=0u||get_path_vertex_depth()==2u;
 		const bool notFirstFrame = pc.cummon.rcpFramesDispatched!=1.f;
 		if (record_emission_common(acc,accumulationLocation,emissive*throughput,first_accumulating_path_vertex))
 			storeAccumulation(acc,accumulationLocation);
-	#endif
 	}
 }

examples_tests/22.RaytracedAO/raygen.comp

@@ -67,8 +67,6 @@ void main()
 			const vec3 origin = nbl_glsl_interpolate_with_bounds(origin_error,dPdBary,dPdBary_error,lastVxPos,lastVxPos_error,compactBary,compactBary_error);
 			normalizedV = normalize(pc.cummon.camPos-origin);
 
-			//emissive = vec3(1000.f)*dot(abs(normalizedN),origin_error)*1.03125f;
-
 			// generate rays
 			const uint vertex_depth = 1u;
 			generate_next_rays(

examples_tests/22.RaytracedAO/raytraceCommon.glsl

@@ -302,9 +302,17 @@ for (uint i=1u; i!=vertex_depth; i++)
 	// TODO: investigate workgroup reductions here
 	const uint baseOutputID = atomicAdd(rayCount[pc.cummon.rayCountWriteIx],raysToAllocate);
 
-	const vec3 geomNormal = cross(dPdBary[0],dPdBary[1]);
-	float ray_offset = dot(normalize(abs(normalizedN)),origin_error)+nbl_glsl_ieee754_gamma(3u);
-	//float ray_offset = nbl_glsl_ieee754_gamma(3u);
+	float ray_offset = dot(normalize(abs(normalizedN)),origin_error)+nbl_glsl_ieee754_gamma(3u); // I pulled the gamma(3) out of my @$$
+	// TODO: in the future run backward error analysis of
+	// dot(mat3(WorldToObj)*(origin+offset*geomNormal/length(geomNormal))+(WorldToObj-vx_pos[1]),geomNormal)
+	// where
+	// origin = mat3x2(vx_pos[2]-vx_pos[1],vx_pos[0]-vx_pos[1])*barys+vx_pos[1]
+	// geonNormal = cross(vx_pos[2]-vx_pos[1],vx_pos[0]-vx_pos[1])
+	// and we assume only `WorldToObj`, `vx_pos[i]` and `barys` are accurate values. So far:
+	// offset > (1+gamma(2))/(1-gamma(2))*(dot(abs(geomNormal),omega_error)+dot(abs(omega),geomNormal_error)+dot(omega_error,geomNormal_error))
+	//const vec3 geomNormal = cross(dPdBary[0],dPdBary[1]);
+	//float ray_offset = ?;
+	//ray_offset = nbl_glsl_ieee754_next_ulp_away_from_zero(ray_offset);
 	// adjust for the fact that the normal might be too short (inversesqrt precision)
 	ray_offset *= 1.03125f;
 	uint offset = 0u;
@@ -326,7 +334,7 @@ for (uint i=1u; i!=vertex_depth; i++)
 	}
 }
 
-/* TODO: optimize
+/* TODO: optimize and reorganize
 void main()
 {
 	clear_raycount();