Now every tgmath function utilize helpers

Author: Przemog1

examples_tests

@@ -705,6 +705,82 @@ struct max_helper<Vector NBL_PARTIAL_REQ_BOT(is_vector_v<Vector>) >
 	}
 };
 
+// DETERMINANT
+
+template<typename T NBL_STRUCT_CONSTRAINABLE>
+struct determinant_helper;
+
+template<typename SquareMatrix>
+NBL_PARTIAL_REQ_TOP(matrix_traits<SquareMatrix>::Square)
+struct determinant_helper<SquareMatrix NBL_PARTIAL_REQ_BOT(matrix_traits<SquareMatrix>::Square) >
+{
+	static typename matrix_traits<SquareMatrix>::scalar_type __call(NBL_CONST_REF_ARG(SquareMatrix) mat)
+	{
+#ifdef __HLSL_VERSION
+		spirv::determinant(mat);
+#else
+		return glm::determinant(reinterpret_cast<typename SquareMatrix::Base const&>(mat));
+#endif
+	}
+};
+
+// INVERSE
+
+template<typename T NBL_STRUCT_CONSTRAINABLE>
+struct inverse_helper;
+
+template<typename SquareMatrix>
+NBL_PARTIAL_REQ_TOP(matrix_traits<SquareMatrix>::Square)
+struct inverse_helper<SquareMatrix NBL_PARTIAL_REQ_BOT(matrix_traits<SquareMatrix>::Square) >
+{
+	static SquareMatrix __call(NBL_CONST_REF_ARG(SquareMatrix) mat)
+	{
+#ifdef __HLSL_VERSION
+		return spirv::matrixInverse(mat);
+#else
+		return reinterpret_cast<SquareMatrix&>(glm::inverse(reinterpret_cast<typename SquareMatrix::Base const&>(mat)));
+#endif
+	}
+};
+
+// RSQRT
+
+template<typename T NBL_STRUCT_CONSTRAINABLE>
+struct rsqrt_helper;
+
+template<typename FloatingPoint>
+NBL_PARTIAL_REQ_TOP(is_floating_point_v<FloatingPoint> && is_scalar_v<FloatingPoint>)
+struct rsqrt_helper<FloatingPoint NBL_PARTIAL_REQ_BOT(is_floating_point_v<FloatingPoint> && is_scalar_v<FloatingPoint>) >
+{
+	static FloatingPoint __call(NBL_CONST_REF_ARG(FloatingPoint) x)
+	{
+		// TODO: https://stackoverflow.com/a/62239778
+#ifdef __HLSL_VERSION
+		return spirv::inverseSqrt(x);
+#else
+		return 1.0f / std::sqrt(x);
+#endif
+	}
+};
+
+template<typename FloatingPointVector>
+NBL_PARTIAL_REQ_TOP(is_vector_v<FloatingPointVector> && is_floating_point_v<typename vector_traits<FloatingPointVector>::scalar_type>)
+struct rsqrt_helper<FloatingPointVector NBL_PARTIAL_REQ_BOT(is_vector_v<FloatingPointVector>&& is_floating_point_v<typename vector_traits<FloatingPointVector>::scalar_type>) >
+{
+	static FloatingPointVector __call(NBL_CONST_REF_ARG(FloatingPointVector) x)
+	{
+		using traits = hlsl::vector_traits<FloatingPointVector>;
+		array_get<FloatingPointVector, typename traits::scalar_type> getter;
+		array_set<FloatingPointVector, typename traits::scalar_type> setter;
+
+		FloatingPointVector output;
+		for (uint32_t i = 0; i < traits::Dimension; ++i)
+			setter(output, i, rsqrt_helper<typename traits::scalar_type>::__call(getter(x, i)));
+
+		return output;
+	}
+};
+
 }
 }
 }

include/nbl/builtin/hlsl/cpp_compat/impl/intrinsics_impl.hlsl

@@ -62,17 +62,12 @@ typename vector_traits<T>::scalar_type dot(NBL_CONST_REF_ARG(T) lhs, NBL_CONST_R
 	return cpp_compat_intrinsics_impl::dot_helper<T>::__call(lhs, rhs);
 }
 
-// TODO: for clearer error messages, use concepts to ensure that input type is a square matrix
 // determinant not defined cause its implemented via hidden friend
 // https://stackoverflow.com/questions/67459950/why-is-a-friend-function-not-treated-as-a-member-of-a-namespace-of-a-class-it-wa
-template<typename T, uint16_t N>
-inline T determinant(NBL_CONST_REF_ARG(matrix<T, N, N>) m)
+template<typename Matrix>
+inline typename matrix_traits<Matrix>::scalar_type determinant(NBL_CONST_REF_ARG(Matrix) mat)
 {
-#ifdef __HLSL_VERSION
-	spirv::determinant(m);
-#else
-	return glm::determinant(reinterpret_cast<typename matrix<T, N, N>::Base const&>(m));
-#endif
+	return cpp_compat_intrinsics_impl::determinant_helper<Matrix>::__call(mat);
 }
 
 template<typename Integer>
@@ -87,16 +82,11 @@ inline typename cpp_compat_intrinsics_impl::find_msb_return_type<Integer>::type
 	return cpp_compat_intrinsics_impl::find_msb_helper<Integer>::__call(val);
 }
 
-// TODO: for clearer error messages, use concepts to ensure that input type is a square matrix
 // inverse not defined cause its implemented via hidden friend
-template<typename T, uint16_t N>
-inline matrix<T, N, N> inverse(NBL_CONST_REF_ARG(matrix<T, N, N>) m)
+template<typename Matrix>
+inline Matrix inverse(NBL_CONST_REF_ARG(Matrix) mat)
 {
-#ifdef __HLSL_VERSION
-	return spirv::matrixInverse(m);
-#else
-	return reinterpret_cast<matrix<T, N, N>&>(glm::inverse(reinterpret_cast<typename matrix<T, N, N>::Base const&>(m)));
-#endif
+	return cpp_compat_intrinsics_impl::inverse_helper<Matrix>::__call(mat);
 }
 
 // transpose not defined cause its implemented via hidden friend
@@ -128,12 +118,7 @@ inline T max(NBL_CONST_REF_ARG(T) a, NBL_CONST_REF_ARG(T) b)
 template<typename FloatingPoint>
 inline FloatingPoint rsqrt(FloatingPoint x)
 {
-	// TODO: https://stackoverflow.com/a/62239778
-#ifdef __HLSL_VERSION
-	return spirv::inverseSqrt(x);
-#else
-	return 1.0f / std::sqrt(x);
-#endif
+	return cpp_compat_intrinsics_impl::rsqrt_helper<FloatingPoint>::__call(x);
 }
 
 template<typename Integer>