Command buffer begin and reset function changed uint32_t to actual flags

Erfan-Ahmadi · Erfan-Ahmadi · commit 7126e9d73f5c · 2022-05-24T15:53:14.000+04:30
diff --git a/examples_tests/0.ImportanceSamplingEnvMaps/main.cpp b/examples_tests/0.ImportanceSamplingEnvMaps/main.cpp
@@ -795,7 +795,7 @@ class ImportanceSamplingEnvMaps : public ApplicationBase
 			fence = logicalDevice->createFence(static_cast<video::IGPUFence::E_CREATE_FLAGS>(0));
 
 		commandBuffer->reset(nbl::video::IGPUCommandBuffer::ERF_RELEASE_RESOURCES_BIT);
-		commandBuffer->begin(0);
+		commandBuffer->begin(IGPUCommandBuffer::EU_NONE);
 
 		const auto nextPresentationTimestamp = oracle.acquireNextImage(swapchain.get(), imageAcquire[resourceIx].get(), nullptr, &acquiredNextFBO);
 		{
diff --git a/examples_tests/01.HelloWorld/main.cpp b/examples_tests/01.HelloWorld/main.cpp
@@ -532,7 +532,7 @@ Choose Graphics API:
 		else
 			fence = device->createFence(static_cast<video::IGPUFence::E_CREATE_FLAGS>(0));
 
-		commandBuffer->begin(0u);
+		commandBuffer->begin(IGPUCommandBuffer::EU_NONE);
 
 		swapchain->acquireNextImage(MAX_TIMEOUT, m_imageAcquire[m_resourceIx].get(), nullptr, &m_acquiredNextFBO);
 
diff --git a/examples_tests/02.ComputeShader/main.cpp b/examples_tests/02.ComputeShader/main.cpp
@@ -404,7 +404,7 @@ class ComputeShaderSampleApp : public ApplicationBase
 		swapchain->acquireNextImage(MAX_TIMEOUT, m_imageAcquire[m_resourceIx].get(), nullptr, &imgnum);
 
 		// safe to proceed
-		cb->begin(0);
+		cb->begin(IGPUCommandBuffer::EU_NONE);
 
 		{
 			asset::SViewport vp;
diff --git a/examples_tests/03.GPU_Mesh/main.cpp b/examples_tests/03.GPU_Mesh/main.cpp
@@ -260,7 +260,7 @@ class GPUMesh : public ApplicationBase
 		const auto& mvp = camera.getConcatenatedMatrix();
 
 		commandBuffer->reset(nbl::video::IGPUCommandBuffer::ERF_RELEASE_RESOURCES_BIT);
-		commandBuffer->begin(0);
+		commandBuffer->begin(IGPUCommandBuffer::EU_NONE);
 
 		asset::SViewport viewport;
 		viewport.minDepth = 1.f;
diff --git a/examples_tests/05.NablaTutorialExample/main.cpp b/examples_tests/05.NablaTutorialExample/main.cpp
@@ -503,7 +503,7 @@ class NablaTutorialExampleApp : public ApplicationBase
 		const auto& viewProjectionMatrix = camera.getConcatenatedMatrix();
 
 		commandBuffer->reset(nbl::video::IGPUCommandBuffer::ERF_RELEASE_RESOURCES_BIT);
-		commandBuffer->begin(0);
+		commandBuffer->begin(IGPUCommandBuffer::EU_NONE);
 
 		asset::SViewport viewport;
 		viewport.minDepth = 1.f;
diff --git a/examples_tests/06.MeshLoaders/main.cpp b/examples_tests/06.MeshLoaders/main.cpp
@@ -420,7 +420,7 @@ class MeshLoadersApp : public ApplicationBase
             fence = logicalDevice->createFence(static_cast<video::IGPUFence::E_CREATE_FLAGS>(0));
 
         commandBuffer->reset(nbl::video::IGPUCommandBuffer::ERF_RELEASE_RESOURCES_BIT);
-        commandBuffer->begin(0);
+        commandBuffer->begin(IGPUCommandBuffer::EU_NONE);
 
         const auto nextPresentationTimestamp = oracle.acquireNextImage(swapchain.get(), imageAcquire[resourceIx].get(), nullptr, &acquiredNextFBO);
         {
diff --git a/examples_tests/07.SubpassBaking/main.cpp b/examples_tests/07.SubpassBaking/main.cpp
@@ -411,7 +411,7 @@ class SubpassBaking : public ApplicationBase
                 auto fence = logicalDevice->createFence(video::IGPUFence::ECF_UNSIGNALED);
                 core::smart_refctd_ptr<video::IGPUCommandBuffer> tferCmdBuf;
                 logicalDevice->createCommandBuffers(commandPools[decltype(initOutput)::EQT_TRANSFER_UP].get(), video::IGPUCommandBuffer::EL_PRIMARY, 1u, &tferCmdBuf);
-                tferCmdBuf->begin(0u); // TODO some one time submit bit or something
+                tferCmdBuf->begin(IGPUCommandBuffer::EU_NONE); // TODO some one time submit bit or something
                 {
                     auto* ppHandler = utilities->getDefaultPropertyPoolHandler();
                     // if we did multiple transfers, we'd reuse the scratch
@@ -503,7 +503,7 @@ class SubpassBaking : public ApplicationBase
 
         //
         commandBuffer->reset(nbl::video::IGPUCommandBuffer::ERF_RELEASE_RESOURCES_BIT);
-        commandBuffer->begin(0);
+        commandBuffer->begin(IGPUCommandBuffer::EU_NONE);
 
         // late latch input
         const auto nextPresentationTimestamp = oracle.acquireNextImage(swapchain.get(), imageAcquire[resourceIx].get(), nullptr, &acquiredNextFBO);
diff --git a/examples_tests/09.ColorSpaceTest/main.cpp b/examples_tests/09.ColorSpaceTest/main.cpp
@@ -371,7 +371,7 @@ class ColorSpaceTestSampleApp : public ApplicationBase
 				// acquire image 
 				swapchain->acquireNextImage(MAX_TIMEOUT, imageAcquire[resourceIx].get(), nullptr, &imgnum);
 
-				cb->begin(0);
+				cb->begin(IGPUCommandBuffer::EU_NONE);
 
 				asset::SViewport viewport;
 				viewport.minDepth = 1.f;
diff --git a/examples_tests/11.LoDSystem/main.cpp b/examples_tests/11.LoDSystem/main.cpp
@@ -649,7 +649,7 @@ class LoDSystemApp : public ApplicationBase
                         core::smart_refctd_ptr<video::IGPUCommandBuffer> tferCmdBuf;
                         logicalDevice->createCommandBuffers(commandPools[CommonAPI::InitOutput::EQT_TRANSFER_UP].get(), video::IGPUCommandBuffer::EL_PRIMARY, 1u, &tferCmdBuf);
                         auto fence = logicalDevice->createFence(video::IGPUFence::ECF_UNSIGNALED);
-                        tferCmdBuf->begin(0u); // TODO some one time submit bit or something
+                        tferCmdBuf->begin(IGPUCommandBuffer::EU_NONE); // TODO some one time submit bit or something
                         {
                             auto ppHandler = utilities->getDefaultPropertyPoolHandler();
                             asset::SBufferBinding<video::IGPUBuffer> scratch;
@@ -763,7 +763,7 @@ class LoDSystemApp : public ApplicationBase
 
             //
             commandBuffer->reset(nbl::video::IGPUCommandBuffer::ERF_RELEASE_RESOURCES_BIT);
-            commandBuffer->begin(0);
+            commandBuffer->begin(IGPUCommandBuffer::EU_NONE);
 
             // late latch input
             const auto nextPresentationTimestamp = oracle.acquireNextImage(swapchain.get(), imageAcquire[resourceIx].get(), nullptr, &acquiredNextFBO);
diff --git a/examples_tests/12.glTF/main.cpp b/examples_tests/12.glTF/main.cpp
@@ -204,7 +204,7 @@ class GLTFApp : public ApplicationBase
 			{
 				xferFence = logicalDevice->createFence(static_cast<nbl::video::IGPUFence::E_CREATE_FLAGS>(0));
 				logicalDevice->createCommandBuffers(commandPools[CommonAPI::InitOutput::EQT_TRANSFER_UP].get(),nbl::video::IGPUCommandBuffer::EL_PRIMARY,1u,&xferCmdbuf);
-				xferCmdbuf->begin(0);
+				xferCmdbuf->begin(IGPUCommandBuffer::EU_NONE);
 			}
 			auto xferQueue = logicalDevice->getQueue(xferCmdbuf->getQueueFamilyIndex(),0u);
 			asset::SBufferBinding<video::IGPUBuffer> xferScratch;
@@ -795,7 +795,7 @@ class GLTFApp : public ApplicationBase
 				fence = logicalDevice->createFence(static_cast<video::IGPUFence::E_CREATE_FLAGS>(0));
 
 			commandBuffer->reset(nbl::video::IGPUCommandBuffer::ERF_RELEASE_RESOURCES_BIT);
-			commandBuffer->begin(0);
+			commandBuffer->begin(IGPUCommandBuffer::EU_NONE);
 
 			const auto nextPresentationTimestamp = oracle.acquireNextImage(swapchain.get(), imageAcquire[resourceIx].get(), nullptr, &acquiredNextFBO);
 
diff --git a/examples_tests/13.EmptyExample/main.cpp b/examples_tests/13.EmptyExample/main.cpp
@@ -533,7 +533,7 @@ Choose Graphics API:
 		else
 			fence = device->createFence(static_cast<video::IGPUFence::E_CREATE_FLAGS>(0));
 
-		commandBuffer->begin(0u);
+		commandBuffer->begin(IGPUCommandBuffer::EU_NONE);
 
 		swapchain->acquireNextImage(MAX_TIMEOUT, m_imageAcquire[m_resourceIx].get(), nullptr, &m_acquiredNextFBO);
 
diff --git a/examples_tests/16.OrderIndependentTransparency/main.cpp b/examples_tests/16.OrderIndependentTransparency/main.cpp
@@ -524,7 +524,7 @@ class OITSampleApp : public ApplicationBase
         const auto& viewProjectionMatrix = camera.getConcatenatedMatrix();
 
         commandBuffer->reset(nbl::video::IGPUCommandBuffer::ERF_RELEASE_RESOURCES_BIT);
-        commandBuffer->begin(0);
+        commandBuffer->begin(IGPUCommandBuffer::EU_NONE);
 
         asset::SViewport viewport;
         viewport.minDepth = 1.f;
diff --git a/examples_tests/17.SimpleBulletIntegration/main.cpp b/examples_tests/17.SimpleBulletIntegration/main.cpp
@@ -775,7 +775,7 @@ class BulletSampleApp : public ApplicationBase
 			fence = logicalDevice->createFence(static_cast<video::IGPUFence::E_CREATE_FLAGS>(0));
 
 		// safe to proceed
-		cb->begin(0);
+		cb->begin(IGPUCommandBuffer::EU_NONE);
 
 		// acquire image 
 		uint32_t imgnum = 0u;
diff --git a/examples_tests/18.MitsubaLoader/main.cpp b/examples_tests/18.MitsubaLoader/main.cpp
@@ -958,7 +958,7 @@ class MeshLoadersApp : public ApplicationBase
 		const auto& viewProjectionMatrix = camera.getConcatenatedMatrix();
 		
 		commandBuffer->reset(nbl::video::IGPUCommandBuffer::ERF_RELEASE_RESOURCES_BIT);
-		commandBuffer->begin(0);
+		commandBuffer->begin(IGPUCommandBuffer::EU_NONE);
 		
 		asset::SViewport viewport;
 		viewport.minDepth = 1.f;
@@ -1720,7 +1720,7 @@ class MeshLoadersApp : public ApplicationBase
 //		const auto& viewProjectionMatrix = camera.getConcatenatedMatrix();
 //
 //		commandBuffer->reset(nbl::video::IGPUCommandBuffer::ERF_RELEASE_RESOURCES_BIT);
-//		commandBuffer->begin(0);
+//		commandBuffer->begin(IGPUCommandBuffer::EU_NONE);
 //
 //		asset::SViewport viewport;
 //		viewport.minDepth = 1.f;
diff --git a/examples_tests/20.Megatexture/main.cpp b/examples_tests/20.Megatexture/main.cpp
@@ -709,7 +709,7 @@ APP_CONSTRUCTOR(MegaTextureApp)
         auto commandBuffer = commandBuffers[0];
 
         commandBuffer->reset(nbl::video::IGPUCommandBuffer::ERF_RELEASE_RESOURCES_BIT);
-        commandBuffer->begin(0);
+        commandBuffer->begin(IGPUCommandBuffer::EU_NONE);
 
         asset::SViewport viewport;
         viewport.minDepth = 1.f;
diff --git a/examples_tests/21.DynamicTextureIndexing/main.cpp b/examples_tests/21.DynamicTextureIndexing/main.cpp
@@ -563,7 +563,7 @@ class DynamicTextureIndexingApp : public ApplicationBase
         const auto& viewProjectionMatrix = camera.getConcatenatedMatrix();
 
         commandBuffer->reset(nbl::video::IGPUCommandBuffer::ERF_RELEASE_RESOURCES_BIT);
-        commandBuffer->begin(0);
+        commandBuffer->begin(IGPUCommandBuffer::EU_NONE);
 
         asset::SViewport viewport;
         viewport.minDepth = 1.f;
diff --git a/examples_tests/27.PLYSTLDemo/main.cpp b/examples_tests/27.PLYSTLDemo/main.cpp
@@ -460,7 +460,7 @@ APP_CONSTRUCTOR(PLYSTLDemo)
 		const auto& viewProjectionMatrix = camera.getConcatenatedMatrix();
 
 		commandBuffer->reset(nbl::video::IGPUCommandBuffer::ERF_RELEASE_RESOURCES_BIT);
-		commandBuffer->begin(0);
+		commandBuffer->begin(IGPUCommandBuffer::EU_NONE);
 
 		asset::SViewport viewport;
 		viewport.minDepth = 1.f;
diff --git a/examples_tests/29.SpecializationConstants/main.cpp b/examples_tests/29.SpecializationConstants/main.cpp
@@ -430,7 +430,7 @@ class SpecializationConstantsSampleApp : public ApplicationBase
 		}
 
 		// safe to proceed
-		cb->begin(0);
+		cb->begin(IGPUCommandBuffer::EU_NONE);
 
 		{
 			auto time = std::chrono::high_resolution_clock::now();
diff --git a/examples_tests/33.Draw3DLine/main.cpp b/examples_tests/33.Draw3DLine/main.cpp
@@ -223,7 +223,7 @@ class Draw3DLineSampleApp : public ApplicationBase
 		else
 			fence = device->createFence(static_cast<video::IGPUFence::E_CREATE_FLAGS>(0));
 
-		cb->begin(0);
+		cb->begin(IGPUCommandBuffer::EU_NONE);
 
 		asset::SViewport vp;
 		vp.minDepth = 1.f;
diff --git a/examples_tests/35.GeometryCreator/main.cpp b/examples_tests/35.GeometryCreator/main.cpp
@@ -533,7 +533,7 @@ class GeometryCreatorSampleApp : public ApplicationBase
 		const auto& viewProjectionMatrix = m_camera->getConcatenatedMatrix();
 
 		commandBuffer->reset(nbl::video::IGPUCommandBuffer::ERF_RELEASE_RESOURCES_BIT);
-		commandBuffer->begin(0);
+		commandBuffer->begin(IGPUCommandBuffer::EU_NONE);
 
 		asset::SViewport viewport;
 		viewport.minDepth = 1.f;
diff --git a/examples_tests/42.FragmentShaderPathTracer/main.cpp b/examples_tests/42.FragmentShaderPathTracer/main.cpp
@@ -485,7 +485,7 @@ int main()
 		const auto viewProjectionMatrix = cam.getConcatenatedMatrix();
 				
 		// safe to proceed
-		cb->begin(0);
+		cb->begin(IGPUCommandBuffer::EU_NONE);
 
 		// renderpass 
 		uint32_t imgnum = 0u;
diff --git a/examples_tests/47.DerivMapTest/main.cpp b/examples_tests/47.DerivMapTest/main.cpp
@@ -380,7 +380,7 @@ class DerivMapTestApp : public ApplicationBase
 				break;
 
 			commandBuffer->reset(nbl::video::IGPUCommandBuffer::ERF_RELEASE_RESOURCES_BIT);
-			commandBuffer->begin(0);
+			commandBuffer->begin(IGPUCommandBuffer::EU_NONE);
 
 			asset::SViewport viewport;
 			viewport.minDepth = 1.f;
diff --git a/examples_tests/48.ArithmeticUnitTest/main.cpp b/examples_tests/48.ArithmeticUnitTest/main.cpp
@@ -305,7 +305,7 @@ class ArythmeticUnitTestApp : public NonGraphicalApplicationBase
 	void onAppInitialized_impl() override
 	{
 		CommonAPI::InitOutput initOutput;
-		CommonAPI::InitWithNoExt(initOutput, video::EAT_OPENGL, "Subgroup Arithmetic Test");
+		CommonAPI::InitWithNoExt(initOutput, video::EAT_VULKAN, "Subgroup Arithmetic Test");
 		gl = std::move(initOutput.apiConnection);
 		gpuPhysicalDevice = std::move(initOutput.physicalDevice);
 		logicalDevice = std::move(initOutput.logicalDevice);
diff --git a/examples_tests/50.NewAPITest/main.cpp b/examples_tests/50.NewAPITest/main.cpp
@@ -404,7 +404,7 @@ Choose Graphics API:
 		auto& cb = cmdbuf[i];
 		auto& fb = fbo[i];
 
-		cb->begin(0);
+		cb->begin(IGPUCommandBuffer::EU_NONE);
 		
 		const video::IGPUBuffer* buf = buffer.get();
 		size_t offset = 0u;
diff --git a/examples_tests/53.ComputeShaders/main.cpp b/examples_tests/53.ComputeShaders/main.cpp
@@ -572,7 +572,7 @@ APP_CONSTRUCTOR(MeshLoadersApp)
 
 		auto& commandBuffer = commandBuffers[0];
 		commandBuffer->reset(nbl::video::IGPUCommandBuffer::ERF_RELEASE_RESOURCES_BIT);
-		commandBuffer->begin(0);
+		commandBuffer->begin(IGPUCommandBuffer::EU_NONE);
 
 		asset::SViewport viewport;
 		viewport.minDepth = 1.f;
diff --git a/examples_tests/54.Transformations/main.cpp b/examples_tests/54.Transformations/main.cpp
@@ -438,7 +438,7 @@ class TransformationApp : public ApplicationBase
 						ttm->setupTransfers(req, transfers);
 					}
 
-					cmdbuf_nodes->begin(0);
+					cmdbuf_nodes->begin(IGPUCommandBuffer::EU_NONE);
 					utils->getDefaultPropertyPoolHandler()->transferProperties(
 						cmdbuf_nodes.get(), fence_nodes.get(), scratch, { 0ull,tmp_node_buf },
 						transfers, transfers + scene::ITransformTreeManager::TransferCount, initOutput.logger.get()
@@ -648,7 +648,7 @@ class TransformationApp : public ApplicationBase
 			timestamp++;
 
 			// safe to proceed
-			cb->begin(0);
+			cb->begin(IGPUCommandBuffer::EU_NONE);
 
 			// we don't wait on anything because we do everything on the same queue
 			uint32_t waitSemaphoreCount = 0u;
diff --git a/examples_tests/55.RGB18E7S3/main.cpp b/examples_tests/55.RGB18E7S3/main.cpp
@@ -187,7 +187,7 @@ int main()
     auto gpuFence = logicalDevice->createFence(static_cast<video::IGPUFence::E_CREATE_FLAGS>(0));
     {
 
-        commandBuffer->begin(0);
+        commandBuffer->begin(IGPUCommandBuffer::EU_NONE);
 
         commandBuffer->bindComputePipeline(gpuComputePipeline.get());
         commandBuffer->bindDescriptorSets(asset::EPBP_COMPUTE, gpuComputePipeline->getLayout(), 0, 1, &gpuCDescriptorSet.get());
diff --git a/examples_tests/56.RayQuery/main.cpp b/examples_tests/56.RayQuery/main.cpp
@@ -945,7 +945,7 @@ class RayQuerySampleApp : public ApplicationBase
 		const auto viewProjectionMatrix = cam.getConcatenatedMatrix();
 				
 		// safe to proceed
-		cb->begin(0);
+		cb->begin(IGPUCommandBuffer::EU_NONE);
 
 		// renderpass 
 		swapchain->acquireNextImage(MAX_TIMEOUT,imageAcquire[m_resourceIx].get(),nullptr,&m_acquiredNextFBO);
diff --git a/examples_tests/57.AndroidSample/main.cpp b/examples_tests/57.AndroidSample/main.cpp
@@ -413,7 +413,7 @@ void main()
 			auto& cb = cmdbuf[i];
 			auto& fb = fbo[i];
 
-			cb->begin(0);
+			cb->begin(IGPUCommandBuffer::EU_NONE);
 
 			asset::SViewport vp;
 			vp.minDepth = 1.f;
diff --git a/include/nbl/asset/ICommandBuffer.h b/include/nbl/asset/ICommandBuffer.h
@@ -113,8 +113,9 @@ class ICommandBuffer
 public:
     _NBL_STATIC_INLINE_CONSTEXPR size_t MAX_PUSH_CONSTANT_BYTESIZE = 128u;
 
-    enum E_RESET_FLAGS : uint32_t
+    enum E_RESET_FLAGS : uint8_t
     {
+        ERF_NONE = 0x00,
         ERF_RELEASE_RESOURCES_BIT = 0x01
     };
 
@@ -135,7 +136,7 @@ class ICommandBuffer
         - ES_INVALID
             -> After submission for resettable command buffers.
     */
-    enum E_STATE : uint32_t
+    enum E_STATE : uint8_t
     {
         ES_INITIAL,
         ES_RECORDING,
@@ -144,14 +145,15 @@ class ICommandBuffer
         ES_INVALID
     };
 
-    enum E_USAGE : uint32_t
+    enum E_USAGE : uint8_t
     {
+        EU_NONE = 0x00,
         EU_ONE_TIME_SUBMIT_BIT = 0x01,
         EU_RENDER_PASS_CONTINUE_BIT = 0x02,
         EU_SIMULTANEOUS_USE_BIT = 0x04
     };
 
-    enum E_LEVEL : uint32_t
+    enum E_LEVEL : uint8_t
     {
         EL_PRIMARY = 0u,
         EL_SECONDARY
@@ -205,12 +207,13 @@ class ICommandBuffer
 
     E_STATE getState() const { return m_state; }
 
+    core::bitflag<E_USAGE> getRecordingFlags() const { return m_recordingFlags; } // TODO(Erfan): maybe store m_recordingFlags as 
+
     E_LEVEL getLevel() const { return m_level; }
 
     // hm now i think having begin(), reset() and end() as command buffer API is a little weird
 
-    //! `_flags` takes bits from E_USAGE
-    virtual bool begin(uint32_t _flags)
+    virtual bool begin(core::bitflag<E_USAGE> _flags)
     {
         if(m_state == ES_RECORDING)
         {
@@ -222,8 +225,7 @@ class ICommandBuffer
         return true;
     }
    
-    //! `_flags` takes bits from E_RESET_FLAGS
-    virtual bool reset(uint32_t _flags)
+    virtual bool reset(core::bitflag<E_RESET_FLAGS> _flags)
     {
         m_state = ES_INITIAL;
         return true;
@@ -365,7 +367,7 @@ class ICommandBuffer
 
     E_LEVEL m_level;
     // Flags from E_USAGE
-    uint32_t m_recordingFlags = 0u;
+    core::bitflag<E_USAGE> m_recordingFlags = E_USAGE::EU_NONE;
     E_STATE m_state = ES_INITIAL;
     //future
     uint32_t m_deviceMask = ~0u;
diff --git a/include/nbl/video/IGPUCommandBuffer.h b/include/nbl/video/IGPUCommandBuffer.h
@@ -67,7 +67,7 @@ class IGPUCommandBuffer :
         return false;
     }
 
-    virtual bool begin(uint32_t _flags, const SInheritanceInfo* inheritanceInfo = nullptr)
+    virtual bool begin(core::bitflag<E_USAGE> _flags, const SInheritanceInfo* inheritanceInfo = nullptr)
     {
         if (!isResettable())
         {
@@ -90,7 +90,7 @@ class IGPUCommandBuffer :
         return base_t::begin(_flags);
     }
 
-    virtual bool reset(uint32_t _flags)
+    virtual bool reset(core::bitflag<E_RESET_FLAGS> _flags)
     {
         if (!canReset())
         {
diff --git a/include/nbl/video/utilities/IGPUVirtualTexture.h b/include/nbl/video/utilities/IGPUVirtualTexture.h
diff --git a/include/nbl/video/utilities/IUtilities.h b/include/nbl/video/utilities/IUtilities.h
diff --git a/src/nbl/video/COpenGLCommandBuffer.cpp b/src/nbl/video/COpenGLCommandBuffer.cpp
diff --git a/src/nbl/video/COpenGLCommandBuffer.h b/src/nbl/video/COpenGLCommandBuffer.h
diff --git a/src/nbl/video/CVulkanCommandBuffer.h b/src/nbl/video/CVulkanCommandBuffer.h
diff --git a/src/nbl/video/utilities/IUtilities.cpp b/src/nbl/video/utilities/IUtilities.cpp

Original file line number	Diff line number	Diff line change
`@@ -795,7 +795,7 @@ class ImportanceSamplingEnvMaps : public ApplicationBase`
`795`	`795`	`fence = logicalDevice->createFence(static_cast<video::IGPUFence::E_CREATE_FLAGS>(0));`
`796`	`796`
`797`	`797`	`commandBuffer->reset(nbl::video::IGPUCommandBuffer::ERF_RELEASE_RESOURCES_BIT);`
`798`		`- commandBuffer->begin(0);`
	`798`	`+ commandBuffer->begin(IGPUCommandBuffer::EU_NONE);`
`799`	`799`
`800`	`800`	`const auto nextPresentationTimestamp = oracle.acquireNextImage(swapchain.get(), imageAcquire[resourceIx].get(), nullptr, &acquiredNextFBO);`
`801`	`801`	`{`
Original file line number	Diff line number	Diff line change
`@@ -404,7 +404,7 @@ class ComputeShaderSampleApp : public ApplicationBase`
`404`	`404`	`swapchain->acquireNextImage(MAX_TIMEOUT, m_imageAcquire[m_resourceIx].get(), nullptr, &imgnum);`
`405`	`405`
`406`	`406`	`// safe to proceed`
`407`		`- cb->begin(0);`
	`407`	`+ cb->begin(IGPUCommandBuffer::EU_NONE);`
`408`	`408`
`409`	`409`	`{`
`410`	`410`	`asset::SViewport vp;`
Original file line number	Diff line number	Diff line change
`@@ -420,7 +420,7 @@ class MeshLoadersApp : public ApplicationBase`
`420`	`420`	`fence = logicalDevice->createFence(static_cast<video::IGPUFence::E_CREATE_FLAGS>(0));`
`421`	`421`
`422`	`422`	`commandBuffer->reset(nbl::video::IGPUCommandBuffer::ERF_RELEASE_RESOURCES_BIT);`
`423`		`- commandBuffer->begin(0);`
	`423`	`+ commandBuffer->begin(IGPUCommandBuffer::EU_NONE);`
`424`	`424`
`425`	`425`	`const auto nextPresentationTimestamp = oracle.acquireNextImage(swapchain.get(), imageAcquire[resourceIx].get(), nullptr, &acquiredNextFBO);`
`426`	`426`	`{`
Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,7 @@ class GLTFApp : public ApplicationBase`
`204`	`204`	`{`
`205`	`205`	`xferFence = logicalDevice->createFence(static_cast<nbl::video::IGPUFence::E_CREATE_FLAGS>(0));`
`206`	`206`	`logicalDevice->createCommandBuffers(commandPools[CommonAPI::InitOutput::EQT_TRANSFER_UP].get(),nbl::video::IGPUCommandBuffer::EL_PRIMARY,1u,&xferCmdbuf);`
`207`		`- xferCmdbuf->begin(0);`
	`207`	`+ xferCmdbuf->begin(IGPUCommandBuffer::EU_NONE);`
`208`	`208`	`}`
`209`	`209`	`auto xferQueue = logicalDevice->getQueue(xferCmdbuf->getQueueFamilyIndex(),0u);`
`210`	`210`	`asset::SBufferBinding<video::IGPUBuffer> xferScratch;`
`@@ -795,7 +795,7 @@ class GLTFApp : public ApplicationBase`
`795`	`795`	`fence = logicalDevice->createFence(static_cast<video::IGPUFence::E_CREATE_FLAGS>(0));`
`796`	`796`
`797`	`797`	`commandBuffer->reset(nbl::video::IGPUCommandBuffer::ERF_RELEASE_RESOURCES_BIT);`
`798`		`- commandBuffer->begin(0);`
	`798`	`+ commandBuffer->begin(IGPUCommandBuffer::EU_NONE);`
`799`	`799`
`800`	`800`	`const auto nextPresentationTimestamp = oracle.acquireNextImage(swapchain.get(), imageAcquire[resourceIx].get(), nullptr, &acquiredNextFBO);`
`801`	`801`