Skip to content

Commit 739e9ec

Browse files
committed
add GIT_EXCLUDE_IS_DIRTY, turn off by default, update 3rdparty/git-version-tracking submodule & leave TODO comments for Tadzio there
1 parent 2b05707 commit 739e9ec

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

3rdparty/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,8 @@ add_library(spirv_cross OBJECT
286286
target_compile_definitions(spirv_cross PUBLIC SPIRV_CROSS_EXCEPTIONS_TO_ASSERTIONS)
287287

288288
# cmake-git-version-tracking
289+
# note that checking if a repository is dirty may cost build time (especially a lot if like us you have a lot of submodules) - by default we run with all checks but if you want to increase build time iterations I recommend to exclude this check
290+
option(GIT_EXCLUDE_IS_DIRTY "Exclude IS_DIRTY from git tracking checks, will increase build time iterations at the expense of the meta information loss" OFF)
289291
add_subdirectory(git-version-tracking EXCLUDE_FROM_ALL)
290292
NBL_ADD_GIT_TRACKING_META_LIBRARY(nabla "${NBL_ROOT_PATH}")
291293
NBL_ADD_GIT_TRACKING_META_LIBRARY(dxc "${CMAKE_CURRENT_SOURCE_DIR}/dxc/dxc")

0 commit comments

Comments
 (0)