Merge branch 'separable_image_sampler' into separable_image_sampler_amortized_lookups

Fletterio · Fletterio · commit 7b76bed5b2ad · 2024-07-06T17:18:59.000-03:00
diff --git a/src/nbl/video/IGPUDescriptorSet.cpp b/src/nbl/video/IGPUDescriptorSet.cpp
@@ -74,7 +74,6 @@ IGPUDescriptorSet::SWriteValidationResult IGPUDescriptorSet::validateWrite(const
         return validationResult;
     }
 
-    // Possible TODO: ensure the types are the same, not just categories! Requires IDescriptor to provide a virtual getType() method
     for (uint32_t i = 0; i < write.count; ++i)
     {
         if (asset::IDescriptor::GetTypeCategory(descriptorType) != write.info[i].desc->getTypeCategory())

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,6 @@ IGPUDescriptorSet::SWriteValidationResult IGPUDescriptorSet::validateWrite(const`
`74`	`74`	`return validationResult;`
`75`	`75`	`}`
`76`	`76`
`77`		`- // Possible TODO: ensure the types are the same, not just categories! Requires IDescriptor to provide a virtual getType() method`
`78`	`77`	`for (uint32_t i = 0; i < write.count; ++i)`
`79`	`78`	`{`
`80`	`79`	`if (asset::IDescriptor::GetTypeCategory(descriptorType) != write.info[i].desc->getTypeCategory())`