fix a bug in the application of SPIR-V Optimizer onto Shaders which are already SPIR-V in ILogicalDevice::compileShader CC @kevyuu

Author: devsh

src/nbl/asset/utils/CHLSLCompiler.cpp

@@ -540,7 +540,7 @@ core::smart_refctd_ptr<ICPUShader> CHLSLCompiler::compileToSPIRV_impl(const std:
     auto outSpirv = ICPUBuffer::create({ compileResult.objectBlob->GetBufferSize() });
     memcpy(outSpirv->getPointer(), compileResult.objectBlob->GetBufferPointer(), compileResult.objectBlob->GetBufferSize());
 
-    // Optimizer step
+    // Optimizer step (TODO: improve by working on `compileResult.objectBlob->GetBufferPointer()` directly)
     if (hlslOptions.spirvOptimizer)
         outSpirv = hlslOptions.spirvOptimizer->optimize(outSpirv.get(), logger);
 

src/nbl/video/ILogicalDevice.cpp

@@ -342,10 +342,8 @@ core::smart_refctd_ptr<asset::ICPUShader> ILogicalDevice::compileShader(const SS
     {
         if (creationParams.optimizer)
         {
-            auto spirvBuf = asset::ICPUBuffer::create({ creationParams.cpushader->getContent()->getSize() });
-            auto str = new std::string();
             spirvShader = core::make_smart_refctd_ptr<asset::ICPUShader>(
-                std::move(creationParams.optimizer->optimize(spirvBuf.get(), m_logger)),
+                std::move(creationParams.optimizer->optimize(creationParams.cpushader->getContent(), m_logger)),
                 shaderStage, asset::ICPUShader::E_CONTENT_TYPE::ECT_SPIRV,
                 std::string(creationParams.cpushader->getFilepathHint()));
         }