Skip to content

Commit 8347c8f

Browse files
committed
Corrections
1 parent 94696e0 commit 8347c8f

File tree

2 files changed

+21
-5
lines changed

2 files changed

+21
-5
lines changed

examples_tests/47.DerivMapTest/main.cpp

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -178,8 +178,8 @@ static core::smart_refctd_ptr<asset::ICPUImage> createDerivMapFromHeightMap(asse
178178
<
179179
DefaultSwizzle,
180180
IdentityDither,
181-
void, //TODO: i have no idea if this parameter is correct
182-
false, //TODO: i have no idea if this parameter is correct
181+
void, //TODO: fix
182+
true,
183183
XDerivKernel,
184184
YDerivKernel,
185185
CBoxImageFilterKernel
@@ -426,7 +426,16 @@ class DerivMapTestApp : public ApplicationBase
426426

427427
const std::string writePath = "screenShot_" + captionData.name + ".png";
428428
//TODO: what should be last parameter here?
429-
bool status = ext::ScreenShot::createScreenShot(logicalDevice.get(), queues[CommonAPI::InitOutput::EQT_TRANSFER_UP], renderFinished[resourceIx].get(), gpuSourceImageView.get(), assetManager.get(), writePath, EIL_UNDEFINED);
429+
bool status = ext::ScreenShot::createScreenShot(
430+
logicalDevice.get(),
431+
queues[CommonAPI::InitOutput::EQT_TRANSFER_UP],
432+
renderFinished[resourceIx].get(),
433+
gpuSourceImageView.get(),
434+
assetManager.get(),
435+
writePath,
436+
asset::EIL_PRESENT_SRC,
437+
static_cast<asset::E_ACCESS_FLAGS>(0u));
438+
430439
return status;
431440
};
432441

@@ -661,7 +670,6 @@ class DerivMapTestApp : public ApplicationBase
661670

662671
void workLoopBody() override
663672
{
664-
//TODO: for sure?
665673
auto gpuImageView = gpuImageViews->operator[](imagesPresented);
666674
auto& captionData = captionTexturesData[imagesPresented];
667675

examples_tests/53.ComputeShaders/main.cpp

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -519,7 +519,15 @@ APP_CONSTRUCTOR(MeshLoadersApp)
519519
const auto& fboCreationParams = fbo[0]->getCreationParameters();
520520
auto gpuSourceImageView = fboCreationParams.attachments[0];
521521

522-
bool status = ext::ScreenShot::createScreenShot(logicalDevice.get(), queues[CommonAPI::InitOutput::EQT_TRANSFER_UP], render_finished_sem.get(), gpuSourceImageView.get(), assetManager.get(), "ScreenShot.png", EIL_UNDEFINED);
522+
bool status = ext::ScreenShot::createScreenShot(logicalDevice.get(),
523+
queues[CommonAPI::InitOutput::EQT_TRANSFER_UP],
524+
render_finished_sem.get(),
525+
gpuSourceImageView.get(),
526+
assetManager.get(),
527+
"ScreenShot.png",
528+
asset::EIL_PRESENT_SRC,
529+
static_cast<asset::E_ACCESS_FLAGS>(0u));
530+
523531
assert(status);
524532
}
525533

0 commit comments

Comments
 (0)