update wording

tad1 · tad1 · commit 84450e6c1743 · 2024-08-06T20:10:38.000+02:00
diff --git a/include/nbl/video/ILogicalDevice.h b/include/nbl/video/ILogicalDevice.h
@@ -400,7 +400,7 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe
         ) const
         {
             if (invalidFeaturesForASBuild<Geometry::buffer_t>(motionBlur)) {
-                m_logger.log("Required features are not supported by the device [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
+                m_logger.log("Required features are not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
                 return {};
             }
 
@@ -443,7 +443,7 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe
         ) const
         {
             if (invalidFeaturesForASBuild<IGPUBuffer>(motionBlur)) {
-                m_logger.log("Required features are not supported by the device [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
+                m_logger.log("Required features are not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
                 return {};
             }
 
@@ -494,13 +494,13 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe
 
             // https://registry.khronos.org/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-vkBuildAccelerationStructuresKHR-accelerationStructureHostCommands-03581
             if (!m_enabledFeatures.accelerationStructureHostCommands) {
-                m_logger.log("Acceleration structure host commands feature is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
+                m_logger.log("Feature `acceleration structure host commands` is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
                 return false;
             }
 
             // https://registry.khronos.org/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-vkBuildAccelerationStructuresKHR-infoCount-arraylength
             if (infos.empty()) {
-                m_logger.log("Invalid parameters, infos may not be empty [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
+                m_logger.log("Invalid parameters, infos must not be empty [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
                 return false;
             }
 
@@ -549,7 +549,7 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe
                     break;
             }
             if (!getEnabledFeatures().accelerationStructureHostCommands) {
-                m_logger.log("Acceleration structure host commands feature is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
+                m_logger.log("Feature `acceleration structure` host commands is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
                 return false;
             }
             for (const auto& as : accelerationStructures)
@@ -867,7 +867,7 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe
             {
                 case IQueryPool::TYPE::PIPELINE_STATISTICS:
                     if (!getEnabledFeatures().pipelineStatisticsQuery) {
-                        m_logger.log("Pipeline statistics feature is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
+                        m_logger.log("Feature `pipeline statistics` is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
                         return nullptr;
                     }
                     break;
@@ -876,7 +876,7 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe
                 case IQueryPool::TYPE::ACCELERATION_STRUCTURE_SERIALIZATION_BOTTOM_LEVEL_POINTERS: [[fallthrough]];
                 case IQueryPool::TYPE::ACCELERATION_STRUCTURE_SIZE:
                     if (!getEnabledFeatures().accelerationStructure) {
-                        m_logger.log("Acceleration structure feature is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
+                        m_logger.log("Feature `acceleration structure` is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
                         return nullptr;
                     }
                     break;
@@ -1181,7 +1181,7 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe
         inline bool invalidCreationParams(const IGPUAccelerationStructure::SCreationParams& params)
         {
             if (!getEnabledFeatures().accelerationStructure) {
-                m_logger.log("Acceleration structure feature is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
+                m_logger.log("Feature `acceleration structure` is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
                 return true;
             }
             constexpr size_t MinAlignment = 256u;
@@ -1195,7 +1195,7 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe
                 return true;
             }
             if (params.flags.hasFlags(IGPUAccelerationStructure::SCreationParams::FLAGS::MOTION_BIT) && !getEnabledFeatures().rayTracingMotionBlur) {
-                m_logger.log("Ray tracing motion blur feature is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
+                m_logger.log("Feature `ray tracing motion blur` is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
                 return true;
             }
             return false;
@@ -1205,17 +1205,17 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe
         {
             // https://registry.khronos.org/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-vkGetAccelerationStructureBuildSizesKHR-accelerationStructure-08933
             if (!m_enabledFeatures.accelerationStructure) {
-                m_logger.log("Acceleration structure feature is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
+                m_logger.log("Feature `acceleration structure` is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
                 return true;
             }
 			// not sure of VUID
             if (std::is_same_v<BufferType, asset::ICPUBuffer> && !m_enabledFeatures.accelerationStructureHostCommands) {
-                m_logger.log("Acceleration structure host commands feature is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
+                m_logger.log("Feature `acceleration structure` host commands is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
 				return true;
             }
             // not sure of VUID
             if (motionBlur && !m_enabledFeatures.rayTracingMotionBlur) {
-                m_logger.log("Ray tracing motion blur feature is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
+                m_logger.log("Feature `ray tracing motion blur` is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
                 return true;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -400,7 +400,7 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe`
`400`	`400`	`) const`
`401`	`401`	`{`
`402`	`402`	`if (invalidFeaturesForASBuild<Geometry::buffer_t>(motionBlur)) {`
`403`		`- m_logger.log("Required features are not supported by the device [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);`
	`403`	`+ m_logger.log("Required features are not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);`
`404`	`404`	`return {};`
`405`	`405`	`}`
`406`	`406`
`@@ -443,7 +443,7 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe`
`443`	`443`	`) const`
`444`	`444`	`{`
`445`	`445`	`if (invalidFeaturesForASBuild<IGPUBuffer>(motionBlur)) {`
`446`		`- m_logger.log("Required features are not supported by the device [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);`
	`446`	`+ m_logger.log("Required features are not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);`
`447`	`447`	`return {};`
`448`	`448`	`}`
`449`	`449`
`@@ -494,13 +494,13 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe`
`494`	`494`
`495`	`495`	`// https://registry.khronos.org/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-vkBuildAccelerationStructuresKHR-accelerationStructureHostCommands-03581`
`496`	`496`	`if (!m_enabledFeatures.accelerationStructureHostCommands) {`
`497`		`- m_logger.log("Acceleration structure host commands feature is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);`
	`497`	+ m_logger.log("Feature `acceleration structure host commands` is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
`498`	`498`	`return false;`
`499`	`499`	`}`
`500`	`500`
`501`	`501`	`// https://registry.khronos.org/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-vkBuildAccelerationStructuresKHR-infoCount-arraylength`
`502`	`502`	`if (infos.empty()) {`
`503`		`- m_logger.log("Invalid parameters, infos may not be empty [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);`
	`503`	`+ m_logger.log("Invalid parameters, infos must not be empty [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);`
`504`	`504`	`return false;`
`505`	`505`	`}`
`506`	`506`
`@@ -549,7 +549,7 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe`
`549`	`549`	`break;`
`550`	`550`	`}`
`551`	`551`	`if (!getEnabledFeatures().accelerationStructureHostCommands) {`
`552`		`- m_logger.log("Acceleration structure host commands feature is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);`
	`552`	+ m_logger.log("Feature `acceleration structure` host commands is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
`553`	`553`	`return false;`
`554`	`554`	`}`
`555`	`555`	`for (const auto& as : accelerationStructures)`
`@@ -867,7 +867,7 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe`
`867`	`867`	`{`
`868`	`868`	`case IQueryPool::TYPE::PIPELINE_STATISTICS:`
`869`	`869`	`if (!getEnabledFeatures().pipelineStatisticsQuery) {`
`870`		`- m_logger.log("Pipeline statistics feature is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);`
	`870`	+ m_logger.log("Feature `pipeline statistics` is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
`871`	`871`	`return nullptr;`
`872`	`872`	`}`
`873`	`873`	`break;`
`@@ -876,7 +876,7 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe`
`876`	`876`	`case IQueryPool::TYPE::ACCELERATION_STRUCTURE_SERIALIZATION_BOTTOM_LEVEL_POINTERS: [[fallthrough]];`
`877`	`877`	`case IQueryPool::TYPE::ACCELERATION_STRUCTURE_SIZE:`
`878`	`878`	`if (!getEnabledFeatures().accelerationStructure) {`
`879`		`- m_logger.log("Acceleration structure feature is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);`
	`879`	+ m_logger.log("Feature `acceleration structure` is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
`880`	`880`	`return nullptr;`
`881`	`881`	`}`
`882`	`882`	`break;`
`@@ -1181,7 +1181,7 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe`
`1181`	`1181`	`inline bool invalidCreationParams(const IGPUAccelerationStructure::SCreationParams& params)`
`1182`	`1182`	`{`
`1183`	`1183`	`if (!getEnabledFeatures().accelerationStructure) {`
`1184`		`- m_logger.log("Acceleration structure feature is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);`
	`1184`	+ m_logger.log("Feature `acceleration structure` is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
`1185`	`1185`	`return true;`
`1186`	`1186`	`}`
`1187`	`1187`	`constexpr size_t MinAlignment = 256u;`
`@@ -1195,7 +1195,7 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe`
`1195`	`1195`	`return true;`
`1196`	`1196`	`}`
`1197`	`1197`	`if (params.flags.hasFlags(IGPUAccelerationStructure::SCreationParams::FLAGS::MOTION_BIT) && !getEnabledFeatures().rayTracingMotionBlur) {`
`1198`		`- m_logger.log("Ray tracing motion blur feature is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);`
	`1198`	+ m_logger.log("Feature `ray tracing motion blur` is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
`1199`	`1199`	`return true;`
`1200`	`1200`	`}`
`1201`	`1201`	`return false;`
`@@ -1205,17 +1205,17 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe`
`1205`	`1205`	`{`
`1206`	`1206`	`// https://registry.khronos.org/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-vkGetAccelerationStructureBuildSizesKHR-accelerationStructure-08933`
`1207`	`1207`	`if (!m_enabledFeatures.accelerationStructure) {`
`1208`		`- m_logger.log("Acceleration structure feature is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);`
	`1208`	+ m_logger.log("Feature `acceleration structure` is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
`1209`	`1209`	`return true;`
`1210`	`1210`	`}`
`1211`	`1211`	`// not sure of VUID`
`1212`	`1212`	`if (std::is_same_v<BufferType, asset::ICPUBuffer> && !m_enabledFeatures.accelerationStructureHostCommands) {`
`1213`		`- m_logger.log("Acceleration structure host commands feature is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);`
	`1213`	+ m_logger.log("Feature `acceleration structure` host commands is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
`1214`	`1214`	`return true;`
`1215`	`1215`	`}`
`1216`	`1216`	`// not sure of VUID`
`1217`	`1217`	`if (motionBlur && !m_enabledFeatures.rayTracingMotionBlur) {`
`1218`		`- m_logger.log("Ray tracing motion blur feature is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);`
	`1218`	+ m_logger.log("Feature `ray tracing motion blur` is not enabled [%s - %s:%p]", system::ILogger::ELL_ERROR, __FUNCTION__, __FILE__, __LINE__);
`1219`	`1219`	`return true;`
`1220`	`1220`	`}`
`1221`	`1221`