Fix PNG writer, and signed/unsigned comparison with ZIP archives.

P.S. Also android fixes.

Author: devshgraphicsprogramming

include/nbl/system/ICancellableAsyncQueueDispatcher.h

@@ -186,6 +186,7 @@ class ICancellableAsyncQueueDispatcher : public IAsyncQueueDispatcher<CRTP, Requ
                     _NBL_DEBUG_BREAK_IF(didntUseFuture);
                 }
 
+                // can only be called once!
                 T& get()
                 {
                     future_base_t::wait();

include/nbl/system/ISystemPOSIX.h

@@ -13,6 +13,8 @@ class ISystemPOSIX : public ISystem
         class CCaller final : public ISystem::ICaller
         {
             public:
+                CCaller(ISystemPOSIX* _system) : ICaller(_system) {}
+
                 core::smart_refctd_ptr<ISystemFile> createFile(const std::filesystem::path& filename, const core::bitflag<IFile::E_CREATE_FLAGS> flags) override;
         };
 

src/nbl/asset/interchange/CImageWriterPNG.cpp

@@ -52,13 +52,13 @@ void PNGAPI user_write_data_fcn(png_structp png_ptr, png_bytep data, png_size_t
 	//check=(png_size_t) file->write((const void*)data,(uint32_t)length);
 	auto usrData = (CImageWriterPNG::SContext*)png_get_user_chunk_ptr(png_ptr);
 
-	system::ISystem::future_t<size_t> future;
-	file->write(future, data, usrData->file_pos, length);
-	usrData->file_pos += future.get();
-	png_set_read_user_chunk_fn(png_ptr, usrData, nullptr);
-
-	if (future.get() != length)
+	system::IFile::success_t success;
+	file->write(success, data, usrData->file_pos, length);
+	if (!success)
 		png_error(png_ptr, "Write Error");
+
+	usrData->file_pos += success.getSizeToProcess();
+	png_set_read_user_chunk_fn(png_ptr, usrData, nullptr);
 }
 #endif // _NBL_COMPILE_WITH_LIBPNG_
 

src/nbl/system/CArchiveLoaderZip.cpp

@@ -78,7 +78,7 @@ enum E_GZIP_FLAGS
 };
 struct SZipFileExtraHeader
 {
-	int16_t ID;
+	uint16_t ID;
 	int16_t Size;
 };
 

src/nbl/system/CSystemAndroid.cpp

@@ -28,7 +28,7 @@ ISystem::SystemInfo CSystemAndroid::getSystemInfo() const
 {
 	SystemInfo info;
 	// TODO: hardcoded
-	info.cpuFrequency = 1100;
+	info.cpuFrequencyHz = 1100000000;
 	info.totalMemory = 4ull<<30ull;
 	info.availableMemory = 2ull<<30ull;