Take BufferCreateParams instead of size in createFilledDeviceLocalGPUBufferOnDedMem

Author: Erfan-Ahmadi

examples_tests/48.ArithmeticUnitTest/main.cpp

@@ -328,7 +328,10 @@ class ArythmeticUnitTestApp : public NonGraphicalApplicationBase
 				inputData[i] = randGenerator();
 		}
 
-		auto gpuinputDataBuffer = utilities->createFilledDeviceLocalGPUBufferOnDedMem(queues[decltype(initOutput)::EQT_TRANSFER_UP], kBufferSize, inputData);
+		IGPUBuffer::SCreationParams inputDataBufferCreationParams = {};
+		inputDataBufferCreationParams.size = kBufferSize;
+		// inputDataBufferCreationParams.usage = ; TODO: Usage should not be EUF_NONE
+		auto gpuinputDataBuffer = utilities->createFilledDeviceLocalGPUBufferOnDedMem(queues[decltype(initOutput)::EQT_TRANSFER_UP], std::move(inputDataBufferCreationParams), inputData);
 
 		//create 8 buffers.
 		constexpr const auto totalBufferCount = outputBufferCount + 1u;

include/nbl/scene/ICullingLoDSelectionSystem.h

@@ -48,8 +48,9 @@ class ICullingLoDSelectionSystem : public virtual core::IReferenceCounted
 			setWorkgroups(contents.drawCompact);
 
 			video::IGPUBuffer::SCreationParams params;
+			params.size = sizeof(contents);
 			params.usage = core::bitflag(asset::IBuffer::EUF_STORAGE_BUFFER_BIT)|asset::IBuffer::EUF_INDIRECT_BUFFER_BIT;
-			return utils->createFilledDeviceLocalGPUBufferOnDedMem(queue,sizeof(contents),&contents);
+			return utils->createFilledDeviceLocalGPUBufferOnDedMem(queue,std::move(params),&contents);
 		}
 
 		// These buffer ranges can be safely discarded or reused after `processInstancesAndFillIndirectDraws` completes

include/nbl/scene/ISkinInstanceCacheManager.h

@@ -45,7 +45,12 @@ class ISkinInstanceCacheManager : public virtual core::IReferenceCounted
 			const auto& limits = device->getPhysicalDevice()->getLimits();
 			core::vector<uint8_t> tmp(limits.SSBOAlignment);
 			*reinterpret_cast<ISkinInstanceCache::recomputed_stamp_t*>(tmp.data()) = ISkinInstanceCache::initial_recomputed_timestamp;
-			auto initTimestampValue = utils->createFilledDeviceLocalGPUBufferOnDedMem(uploadQueue,tmp.size(),tmp.data());
+			
+			IGPUBuffer::SCreationParams initTimestampValueBufferCreationParams = {};
+			initTimestampValueBufferCreationParams.size = tmp.size();
+			// initTimestampValueBufferCreationParams.usage = ; TODO: Usage should not be EUF_NONE
+
+			auto initTimestampValue = utils->createFilledDeviceLocalGPUBufferOnDedMem(uploadQueue,std::move(initTimestampValueBufferCreationParams),tmp.data());
 			if (!initTimestampValue)
 				return nullptr;
 			initTimestampValue->setObjectDebugName("ISkinInstanceCacheManager::m_initTimestampValue");

include/nbl/scene/ITransformTreeManager.h

@@ -134,8 +134,12 @@ class ITransformTreeManager : public virtual core::IReferenceCounted
 				*reinterpret_cast<ITransformTree::relative_transform_t*>(fillData+getDefaultValueBufferOffset(limits,ITransformTree::relative_transform_prop_ix)) = core::matrix3x4SIMD();
 				*reinterpret_cast<ITransformTree::modified_stamp_t*>(fillData+getDefaultValueBufferOffset(limits,ITransformTree::modified_stamp_prop_ix)) = ITransformTree::initial_modified_timestamp;
 				*reinterpret_cast<ITransformTree::recomputed_stamp_t*>(fillData+getDefaultValueBufferOffset(limits,ITransformTree::recomputed_stamp_prop_ix)) = ITransformTree::initial_recomputed_timestamp;
-			}
-			auto defaultFillValues = utils->createFilledDeviceLocalGPUBufferOnDedMem(uploadQueue,tmp.size(),fillData);
+			}			
+			
+			video::IGPUBuffer::SCreationParams defaultFillValuesBufferCreationParams = {};
+			defaultFillValuesBufferCreationParams.size = tmp.size();
+			// defaultFillValuesBufferCreationParams.usage = ; TODO: Usage should not be EUF_NONE
+			auto defaultFillValues = utils->createFilledDeviceLocalGPUBufferOnDedMem(uploadQueue,std::move(defaultFillValuesBufferCreationParams),fillData);
 			defaultFillValues->setObjectDebugName("ITransformTreeManager::m_defaultFillValues");
 			tmp.resize(sizeof(uint16_t)*DebugIndexCount);
 			uint16_t* debugIndices = reinterpret_cast<uint16_t*>(tmp.data());
@@ -168,7 +172,11 @@ class ITransformTreeManager : public virtual core::IReferenceCounted
 				debugIndices[24] = 8u;
 				debugIndices[25] = 9u;
 			}
-			auto debugIndexBuffer = utils->createFilledDeviceLocalGPUBufferOnDedMem(uploadQueue,tmp.size(),fillData);
+			
+			video::IGPUBuffer::SCreationParams debugIndexBufferCreationParams = {};
+			debugIndexBufferCreationParams.size = tmp.size();
+			// debugIndexBufferCreationParams.usage = ; TODO: Usage should not be EUF_NONE
+			auto debugIndexBuffer = utils->createFilledDeviceLocalGPUBufferOnDedMem(uploadQueue,std::move(debugIndexBufferCreationParams),fillData);
 
 			auto updateLocalDsLayout = createUpdateLocalTransformsDescriptorSetLayout(device);
 			auto recomputeGlobalDsLayout = createRecomputeGlobalTransformsDescriptorSetLayout(device);

include/nbl/video/utilities/IUtilities.h

@@ -116,15 +116,13 @@ class IUtilities : public core::IReferenceCounted
         }
 
         //! WARNING: This function blocks the CPU and stalls the GPU!
-        inline core::smart_refctd_ptr<IGPUBuffer> createFilledDeviceLocalGPUBufferOnDedMem(IGPUQueue* queue, size_t size, const void* data)
+        inline core::smart_refctd_ptr<IGPUBuffer> createFilledDeviceLocalGPUBufferOnDedMem(IGPUQueue* queue, IGPUBuffer::SCreationParams&& params, const void* data)
         {
-            IGPUBuffer::SCreationParams params = {};
-            params.size = size;
             auto buffer = m_device->createBuffer(params);
             auto mreqs = buffer->getMemoryReqs();
             mreqs.memoryTypeBits &= m_device->getPhysicalDevice()->getDeviceLocalMemoryTypeBits();
             auto mem = m_device->allocate(mreqs, buffer.get());
-            updateBufferRangeViaStagingBuffer(queue, asset::SBufferRange<IGPUBuffer>{0u, size, buffer}, data);
+            updateBufferRangeViaStagingBuffer(queue, asset::SBufferRange<IGPUBuffer>{0u, params.size, buffer}, data);
             return buffer;
         }