Skip to content

Commit 983a83b

Browse files
committed
Ready for merge, unroll attribute stays default
1 parent 1ffd2bf commit 983a83b

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

include/nbl/builtin/hlsl/memory_accessor.hlsl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,13 +187,13 @@ struct MemoryAdaptor<BaseAccessor, 0>
187187
accessor.set(ix + stride, asuint(value.y));
188188
}
189189
template<typename Scalar>
190-
enable_if_t<sizeof(Scalar) == sizeof(uint32_t), void> set(const uint ix, const <Scalar, 3> value) {
190+
enable_if_t<sizeof(Scalar) == sizeof(uint32_t), void> set(const uint ix, const vector <Scalar, 3> value) {
191191
accessor.set(ix, asuint(value.x));
192192
accessor.set(ix + stride, asuint(value.y));
193193
accessor.set(ix + 2 * stride, asuint(value.z));
194194
}
195195
template<typename Scalar>
196-
enable_if_t<sizeof(Scalar) == sizeof(uint32_t), void> set(const uint ix, const <Scalar, 4> value) {
196+
enable_if_t<sizeof(Scalar) == sizeof(uint32_t), void> set(const uint ix, const vector <Scalar, 4> value) {
197197
accessor.set(ix, asuint(value.x));
198198
accessor.set(ix + stride, asuint(value.y));
199199
accessor.set(ix + 2 * stride, asuint(value.z));

include/nbl/builtin/hlsl/workgroup/fft.hlsl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
// Caveats
1313
// - Sin and Cos in HLSL take 32-bit floats. Using this library with 64-bit floats works perfectly fine, but DXC will emit warnings
14+
// This also means that you don't really get the full precision of 64-bit since twiddle factors are only 32-bit precision
1415

1516
namespace nbl
1617
{

0 commit comments

Comments
 (0)