Anisotropy Feature/Limit added to PhysicalDevice

Author: Erfan-Ahmadi

include/nbl/video/IPhysicalDevice.h

@@ -29,6 +29,7 @@ class IPhysicalDevice : public core::Interface, public core::Unmovable
             uint32_t UBOAlignment;
             uint32_t SSBOAlignment;
             uint32_t bufferViewAlignment;
+            float    maxSamplerAnisotropyLog2;
 
             uint32_t maxUBOSize;
             uint32_t maxSSBOSize;
@@ -130,6 +131,7 @@ class IPhysicalDevice : public core::Interface, public core::Unmovable
             bool shaderSubgroupQuadAllStages = false;
             bool drawIndirectCount = false;
             bool multiDrawIndirect = false;
+            bool samplerAnisotropy = false;
 
             // RayQuery
             bool rayQuery = false;

src/nbl/video/CVulkanLogicalDevice.h

@@ -863,8 +863,9 @@ class CVulkanLogicalDevice final : public ILogicalDevice
         vk_createInfo.addressModeV = getVkAddressModeFromTexClamp(static_cast<asset::ISampler::E_TEXTURE_CLAMP>(_params.TextureWrapV));
         vk_createInfo.addressModeW = getVkAddressModeFromTexClamp(static_cast<asset::ISampler::E_TEXTURE_CLAMP>(_params.TextureWrapW));
         vk_createInfo.mipLodBias = _params.LodBias;
-        vk_createInfo.maxAnisotropy = std::exp2(_params.AnisotropicFilter); // Todo(achal): Verify
-        vk_createInfo.anisotropyEnable = VK_FALSE; // vk_createInfo.maxAnisotropy < 1.f ? VK_FALSE : VK_TRUE; // Todo(achal): Verify. Also this needs to take into account if the anistropic sampling feature is enabled
+        assert(_params.AnisotropicFilter <= m_physicalDevice->getLimits().maxSamplerAnisotropyLog2);
+        vk_createInfo.maxAnisotropy = std::exp2(_params.AnisotropicFilter);
+        vk_createInfo.anisotropyEnable = m_physicalDevice->getFeatures().samplerAnisotropy;
         vk_createInfo.compareEnable = _params.CompareEnable;
         vk_createInfo.compareOp = static_cast<VkCompareOp>(_params.CompareFunc);
         vk_createInfo.minLod = _params.MinLod;

src/nbl/video/CVulkanPhysicalDevice.h

@@ -42,7 +42,8 @@ class CVulkanPhysicalDevice final : public IPhysicalDevice
             m_limits.UBOAlignment = deviceProperties.properties.limits.minUniformBufferOffsetAlignment;
             m_limits.SSBOAlignment = deviceProperties.properties.limits.minStorageBufferOffsetAlignment;
             m_limits.bufferViewAlignment = deviceProperties.properties.limits.minTexelBufferOffsetAlignment;
-                    
+            m_limits.maxSamplerAnisotropyLog2 = std::log2(deviceProperties.properties.limits.maxSamplerAnisotropy);
+
             m_limits.maxUBOSize = deviceProperties.properties.limits.maxUniformBufferRange;
             m_limits.maxSSBOSize = deviceProperties.properties.limits.maxStorageBufferRange;
             m_limits.maxBufferViewSizeTexels = deviceProperties.properties.limits.maxTexelBufferElements;
@@ -138,6 +139,7 @@ class CVulkanPhysicalDevice final : public IPhysicalDevice
             m_features.imageCubeArray = features.imageCubeArray;
             m_features.logicOp = features.logicOp;
             m_features.multiDrawIndirect = features.multiDrawIndirect;
+            m_features.samplerAnisotropy = features.samplerAnisotropy;
             m_features.multiViewport = features.multiViewport;
             m_features.vertexAttributeDouble = features.shaderFloat64;
             m_features.dispatchBase = false; // Todo(achal): Umm.. what is this? Whether you can call VkCmdDispatchBase with non zero base args
@@ -151,7 +153,6 @@ class CVulkanPhysicalDevice final : public IPhysicalDevice
             m_features.shaderSubgroupQuad = subgroupProperties.supportedOperations & VK_SUBGROUP_FEATURE_QUAD_BIT;
             m_features.shaderSubgroupQuadAllStages = ((subgroupProperties.supportedStages & asset::IShader::E_SHADER_STAGE::ESS_ALL)
                                                         == asset::IShader::E_SHADER_STAGE::ESS_ALL);
-            
 
             // RayQuery
             if (m_availableFeatureSet.find(VK_KHR_RAY_QUERY_EXTENSION_NAME) != m_availableFeatureSet.end())