fix a nasty possible threading bug with IDeferredOperation and a bunch of typos

Author: devsh

include/nbl/asset/ICPUAccelerationStructure.h

@@ -90,13 +90,13 @@ class ICPUBottomLevelAccelerationStructure final : public IBottomLevelAccelerati
 		inline std::span<AABBs<asset::ICPUBuffer>> getAABBGeometries()
 		{
 			if (!isMutable() || !m_AABBGeoms)
-				return {nullptr,nullptr};
+				return {};
 			return {m_AABBGeoms->data(),m_AABBGeoms->size()};
 		}
 		inline std::span<const AABBs<asset::ICPUBuffer>> getAABBGeometries() const
 		{
 			if (!m_AABBGeoms)
-				return {nullptr,nullptr};
+				return {};
 			return {m_AABBGeoms->data(),m_AABBGeoms->size()};
 		}
 		inline bool setGeometries(core::smart_refctd_dynamic_array<AABBs<ICPUBuffer>>&& geometries, core::smart_refctd_dynamic_array<uint32_t>&& ranges)

include/nbl/asset/IDescriptorSetLayout.h

@@ -150,8 +150,8 @@ class IDescriptorSetLayoutBase : public virtual core::IReferenceCounted // TODO:
 				// Weird functions for exceptional situations
 				inline storage_range_index_t findBindingStorageIndex(const storage_offset_t offset) const
 				{
-					const auto found = std::upper_bound(m_storageOffsets, m_storageOffsets+m_count, offset, [](storage_range_index_t a, storage_range_index_t b) -> bool {return a.data < b.data; });
-					const auto ix = m_storageOffsets - found;
+					const auto found = std::upper_bound(m_storageOffsets,m_storageOffsets+m_count,offset,[](storage_offset_t a, storage_offset_t b)->bool{return a.data<b.data;});
+					const auto ix = m_storageOffsets-found;
 					if (ix>=m_count)
 						return {};
 					return storage_range_index_t(ix);

include/nbl/video/IDeferredOperation.h

@@ -30,7 +30,10 @@ class IDeferredOperation : public IBackendObject
         {
             const auto retval = execute_impl();
             if (retval==STATUS::COMPLETED || retval==STATUS::_ERROR)
+            {
+                std::lock_guard lock(vectorLock);
                 m_resourceTracking.clear();
+            }
             return retval;
         }
 
@@ -66,6 +69,7 @@ class IDeferredOperation : public IBackendObject
     private:
         friend class ILogicalDevice;
         // when we improve allocators, etc. we'll stop using STL containers here
+        std::mutex vectorLock;
         core::vector<core::smart_refctd_ptr<const IReferenceCounted>> m_resourceTracking;
 };
 

include/nbl/video/ILogicalDevice.h

@@ -46,6 +46,8 @@ class NBL_API2 ILogicalDevice : public core::IReferenceCounted, public IDeviceMe
 
 
         //! Basic getters
+        inline system::ILogger* getLogger() const {return m_logger.get();}
+
         inline const IPhysicalDevice* getPhysicalDevice() const { return m_physicalDevice; }
 
         inline const SPhysicalDeviceFeatures& getEnabledFeatures() const { return m_enabledFeatures; }