moved the box muller transform out to out GLSL library

Author: devshgraphicsprogramming

examples_tests/22.RaytracedAO/main.cpp

@@ -237,6 +237,12 @@ int main()
 
 		if (generateNewSamples)
 		{
+			/** TODO: redo the sampling
+			Locality Level 0: the 6 or 4 dimensions consumed for BSDF + NEE sampling
+			Locality Level 1: the N samples per dispatch which will be consumed in parallel
+			Locality Level 2: the k dimensions batches (where D=4k or 6k) consumed as we recurse deeper
+			Locality Level 3: the z sample batches (where T=zN) consumed as we progressively add samples
+			**/
 			constexpr uint32_t Channels = 3u;
 			static_assert(Renderer::MaxDimensions%Channels==0u,"We cannot have this!");
 			core::OwenSampler sampler(Renderer::MaxDimensions,0xdeadbeefu);

examples_tests/42.FragmentShaderPathTracer/common.glsl

@@ -23,13 +23,7 @@ layout(location = 0) out vec4 pixelColor;
 #include <nbl/builtin/glsl/math/constants.glsl>
 #include <nbl/builtin/glsl/utils/common.glsl>
 
-//! @Crisspl move this to `nbl/builtin/glsl/sampling.glsl` (along with the circle transform)
-vec2 nbl_glsl_BoxMullerTransform(in vec2 xi, in float stddev)
-{
-    float sinPhi, cosPhi;
-    nbl_glsl_sincos(2.0 * nbl_glsl_PI * xi.y - nbl_glsl_PI, sinPhi, cosPhi);
-    return vec2(cosPhi, sinPhi) * sqrt(-2.0 * log(xi.x)) * stddev;
-}
+#include <nbl/builtin/glsl/sampling/box_muller_transform.glsl>
 
 layout(set = 1, binding = 0, row_major, std140) uniform UBO
 {

include/nbl/builtin/glsl/sampling/box_muller_transform.glsl

@@ -0,0 +1,13 @@
+#ifndef _NBL_BUILTIN_GLSL_BOX_MULLER_TRANSFORM_INCLUDED_
+#define _NBL_BUILTIN_GLSL_BOX_MULLER_TRANSFORM_INCLUDED_
+
+#include <nbl/builtin/glsl/math/functions.glsl>
+
+vec2 nbl_glsl_BoxMullerTransform(in vec2 xi, in float stddev)
+{
+    float sinPhi, cosPhi;
+    nbl_glsl_sincos(2.0 * nbl_glsl_PI * xi.y - nbl_glsl_PI, sinPhi, cosPhi);
+    return vec2(cosPhi, sinPhi) * sqrt(-2.0 * log(xi.x)) * stddev;
+}
+
+#endif

src/nbl/builtin/CMakeLists.txt

@@ -85,6 +85,7 @@ set(nbl_resources_to_embed
   "nbl/builtin/glsl/random/xoroshiro.glsl"
   # sampling
   "nbl/builtin/glsl/sampling/bilinear.glsl"
+  "nbl/builtin/glsl/sampling/box_muller_transform.glsl"
   "nbl/builtin/glsl/sampling/concentric_mapping.glsl"
   "nbl/builtin/glsl/sampling/cos_weighted.glsl"
   "nbl/builtin/glsl/sampling/linear.glsl"