Moved flipSign function to ieee754.hlsl

Author: Przemog1

include/nbl/builtin/hlsl/cpp_compat/impl/intrinsics_impl.hlsl

@@ -360,41 +360,6 @@ struct mul_helper
 	}
 };
 
-template<typename T NBL_STRUCT_CONSTRAINABLE>
-struct negate_helper;
-
-template<typename FloatingPoint>
-NBL_PARTIAL_REQ_TOP(hlsl::is_floating_point_v<FloatingPoint> && hlsl::is_scalar_v<FloatingPoint>)
-struct negate_helper<FloatingPoint NBL_PARTIAL_REQ_BOT(hlsl::is_floating_point_v<FloatingPoint> && hlsl::is_scalar_v<FloatingPoint>) >
-{
-	static inline FloatingPoint __call(NBL_CONST_REF_ARG(FloatingPoint) val)
-	{
-#ifdef __HLSL_VERSION
-		return spirv::fNegate(val);
-#else
-		return -val;
-#endif
-	}
-};
-
-template<typename Vector>
-NBL_PARTIAL_REQ_TOP(hlsl::is_vector_v<Vector>)
-struct negate_helper<Vector NBL_PARTIAL_REQ_BOT(hlsl::is_floating_point_v<Vector> && hlsl::is_vector_v<Vector>) >
-{
-	static Vector __call(NBL_CONST_REF_ARG(Vector) vec)
-	{
-#ifdef __HLSL_VERSION
-		return spirv::fNegate(vec);
-#else
-		Vector output;
-		using traits = hlsl::vector_traits<Vector>;
-		for (uint32_t i = 0; i < traits::Dimension; ++i)
-			output[i] = negate_helper<traits::scalar_type >::__call(vec[i]);
-		return output;
-#endif
-	}
-};
-
 }
 }
 }

include/nbl/builtin/hlsl/cpp_compat/intrinsics.hlsl

@@ -152,12 +152,6 @@ inline Integer bitReverse(Integer val)
 	return cpp_compat_intrinsics_impl::bitReverse_helper<Integer>::__call(val);
 }
 
-template<typename FloatingPoint>
-inline FloatingPoint negate(FloatingPoint val)
-{
-	return cpp_compat_intrinsics_impl::negate_helper<FloatingPoint>::__call(val);
-}
-
 }
 }
 

include/nbl/builtin/hlsl/ieee754.hlsl

@@ -141,6 +141,16 @@ NBL_CONSTEXPR_INLINE_FUNC FloatingPoint copySign(FloatingPoint to, FloatingPoint
 	return bit_cast<FloatingPoint>(toAsUint | extractSignPreserveBitPattern(from));
 }
 
+template <typename FloatingPoint NBL_FUNC_REQUIRES(hlsl::is_floating_point_v<FloatingPoint>&& hlsl::is_scalar_v<FloatingPoint>)
+NBL_CONSTEXPR_INLINE_FUNC FloatingPoint flipSign(FloatingPoint val)
+{
+	using AsFloat = typename float_of_size<sizeof(FloatingPoint)>::type;
+	using AsUint = typename unsigned_integer_of_size<sizeof(FloatingPoint)>::type;
+	const AsUint asUint = ieee754::impl::bitCastToUintType(val);
+
+	return bit_cast<FloatingPoint>(asUint ^ ieee754::traits<AsFloat>::signMask);
+}
+
 }
 }
 }

include/nbl/builtin/hlsl/spirv_intrinsics/core.hlsl

@@ -246,10 +246,6 @@ template<typename Matrix>
 [[vk::ext_instruction( spv::OpTranspose )]]
 Matrix transpose(Matrix mat);
 
-template<typename FloatingPoint>
-[[vk::ext_instruction(spv::OpFNegate)]]
-enable_if_t<is_floating_point_v<FloatingPoint>, FloatingPoint> fNegate(FloatingPoint mat);
-
 }
 
 #endif