Skip to content

Commit ae353c4

Browse files
tiny TODOs
1 parent f650459 commit ae353c4

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

include/nbl/config/BuildConfigOptions.h.in

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
#ifndef __NBL_BUILD_CONFIG_OPTIONS_H_INCLUDED__
22
#define __NBL_BUILD_CONFIG_OPTIONS_H_INCLUDED__
33

4+
// TODO: figure out _ and _ suffixes and prefixes
5+
46
#cmakedefine _NBL_DEBUG
57
#cmakedefine _NBL_RELWITHDEBINFO
68

7-
// architecture
9+
// architecture (TODO: rethink)
810
#cmakedefine __NBL_COMPILE_WITH_ARM_SIMD_
911

1012
// libraries
@@ -17,6 +19,7 @@
1719
#cmakedefine _NBL_PLATFORM_OSX_
1820
#cmakedefine _NBL_PLATFORM_ANDROID_
1921

22+
// TODO: X11 vs Wayland shouldn't even be an option (dlopen at runtime!)
2023
#cmakedefine _NBL_BUILD_WITH_WAYLAND
2124

2225
// graphics API backend
@@ -57,7 +60,6 @@
5760
#cmakedefine _NBL_COMPILE_WITH_GLTF_WRITER_
5861

5962
// compute interop
60-
#cmakedefine _NBL_COMPILE_WITH_OPENCL_
6163
#cmakedefine _NBL_COMPILE_WITH_CUDA_
6264
#cmakedefine _NBL_BUILD_OPTIX_
6365

include/nbl/system/IApplicationFramework.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ class IApplicationFramework : public core::IReferenceCounted
3838
protected:
3939
~IApplicationFramework() {}
4040

41+
// TODO: why aren't these pure virtual, and why do we even need a `_impl()`suffix?
4142
virtual void onAppInitialized_impl() {}
4243
virtual void onAppTerminated_impl() {}
4344

include/nbl/system/IThreadHandler.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ template <typename CRTP, typename InternalStateType = void>
2626
class IThreadHandler
2727
{
2828
private:
29-
// TODO: @Crisspl factor this out somewhere? `nbl/core/reflection` ?
29+
// TODO: @AnastzIuk factor this out somewhere? `nbl/core/reflection` ?
3030
#define _NBL_IMPL_MEMBER_FUNC_PRESENCE_CHECKER(member_func_name)\
3131
class has_##member_func_name\
3232
{\

0 commit comments

Comments
 (0)