some more refactors to get closer to the "failed_pt_refactor"

Author: devshgraphicsprogramming

examples_tests/22.RaytracedAO/closestHit.comp

@@ -27,6 +27,7 @@ bool get_sample_job(in uint vertex_depth_mod_2)
 
 void main()
 {
+	bool hit = false;
 	const uint vertex_depth = get_path_vertex_depth();
 	const uint vertex_depth_mod_2 = vertex_depth&0x1u;
 	if (get_sample_job(vertex_depth_mod_2))
@@ -39,7 +40,7 @@ void main()
 
 		const uint batchInstanceGUID = intersection.shapeid;
 		const uint invalidID = 0x80000000u;
-		const bool hit = batchInstanceGUID!=invalidID;
+		hit = batchInstanceGUID!=invalidID;
 
 		const uvec2 outPixelLocation = unpackOutPixelLocation(ray.time);
 		const vec3 throughput = vec3(
@@ -55,7 +56,7 @@ void main()
 			const nbl_glsl_ext_Mitsuba_Loader_instance_data_t batchInstanceData = InstData.data[batchInstanceGUID];
 
 			// obtain ray incoming direction
-			normalizedV = -normalize(ray.direction);
+			normalizedV = -ray.direction;
 			// clear the hit success flag
 			intersections[vertex_depth_mod_2].data[gl_GlobalInvocationID.x].shapeid = -1;
 
@@ -86,7 +87,7 @@ void main()
 
 				generate_next_rays(
 					MAX_RAYS_GENERATED,material,frontfacing,vertex_depth,scramble_start_state,
-					sampleID,outPixelLocation,hitWorldPos,geomNormal,throughput
+					sampleID,outPixelLocation,hitWorldPos,throughput
 				);
 			}
 		}

examples_tests/22.RaytracedAO/raygen.comp

@@ -65,11 +65,10 @@ void main()
 
 			// generate rays
 			const uint sampleID = bitfieldExtract(pc.cummon.samplesComputed_depth,0,16);
-			const vec3 geomNormal = cross(dPdBary[0],dPdBary[1]);
 			const uint vertex_depth = 1u;
 			generate_next_rays(
 				staticViewData.samplesPerPixelPerDispatch,material,frontfacing,vertex_depth,
-				scramble_start_state,sampleID,outPixelLocation,hitWorldPos,geomNormal,vec3(1.0)
+				scramble_start_state,sampleID,outPixelLocation,hitWorldPos,vec3(1.0)
 			);
 		}
 

examples_tests/22.RaytracedAO/raytraceCommon.glsl

@@ -217,7 +217,7 @@ nbl_glsl_xoroshiro64star_state_t load_aux_vertex_attrs(
 void generate_next_rays(
 	in uint maxRaysToGen, in nbl_glsl_MC_oriented_material_t material, in bool frontfacing, in uint vertex_depth,
 	in nbl_glsl_xoroshiro64star_state_t scramble_start_state, in uint sampleID, in uvec2 outPixelLocation,
-	in vec3 origin, vec3 geomNormal, in vec3 prevThroughput)
+	in vec3 origin, in vec3 prevThroughput)
 {
 	// get material streams as well
 	const nbl_glsl_MC_instr_stream_t gcs = nbl_glsl_MC_oriented_material_t_getGenChoiceStream(material);
@@ -262,6 +262,7 @@ for (uint i=1u; i!=vertex_depth; i++)
 	atomicMax(traceIndirect[vertex_depth_mod_2_inv].params.num_groups_x,(baseOutputID+raysToAllocate-1u)/WORKGROUP_SIZE+1u);
 
 	// TODO: improve ray offset (maybe using smooth normal wouldn't be a sin)
+	vec3 geomNormal = cross(dPdBary[0], dPdBary[1]);
 	const vec3 absGeomNormal = abs(geomNormal);
 	geomNormal /= max(max(absGeomNormal.x,absGeomNormal.y),absGeomNormal.z)*96.f;
 	uint offset = 0u;