Skip to content

Commit bca9f86

Browse files
committed
bring back GLSLstd450MatrixInverse & GLSLstd450UnpackSnorm2x16 - set proper extended instruction set for our opcodes ( ext_instruction(opcode[, set]) )
1 parent 4b8990b commit bca9f86

File tree

1 file changed

+2
-7
lines changed
  • include/nbl/builtin/hlsl/spirv_intrinsics

1 file changed

+2
-7
lines changed

include/nbl/builtin/hlsl/spirv_intrinsics/core.hlsl

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -190,18 +190,13 @@ enable_if_t<is_spirv_type_v<P>,void> store(P pointer, T obj);
190190

191191
//! Std 450 Extended set operations
192192

193-
// COMMENTING OUT BECAUSE OF https://github.com/microsoft/DirectXShaderCompiler/issues/6751, bring back when fixed!
194-
/*
195-
196193
template<typename SquareMatrix>
197-
[[vk::ext_instruction(GLSLstd450MatrixInverse)]]
194+
[[vk::ext_instruction(GLSLstd450MatrixInverse, "GLSL.std.450")]]
198195
SquareMatrix matrixInverse(NBL_CONST_REF_ARG(SquareMatrix) mat);
199196

200-
[[vk::ext_instruction(GLSLstd450UnpackSnorm2x16)]]
197+
[[vk::ext_instruction(GLSLstd450UnpackSnorm2x16, "GLSL.std.450")]]
201198
float32_t2 unpackSnorm2x16(uint32_t p);
202199

203-
*/
204-
205200
// Memory Semantics link here: https://registry.khronos.org/SPIR-V/specs/unified1/SPIRV.html#Memory_Semantics_-id-
206201

207202
// https://registry.khronos.org/SPIR-V/specs/unified1/SPIRV.html#_memory_semantics_id

0 commit comments

Comments
 (0)