I'm dumb part 3

Author: devshgraphicsprogramming

examples_tests/41.VisibilityBuffer/fillVBuffer.frag

@@ -19,7 +19,8 @@ void main()
 {
     vec2 bary = nbl_glsl_barycentric_frag_get();
 
-    triangleIDdrawID_unorm16Bary_dBarydScreenHalf2x2[0] = bitfieldInsert(gl_PrimitiveID,drawGUID,MAX_TRIANGLES_IN_BATCH,32-MAX_TRIANGLES_IN_BATCH);
+    const int triangleIDBitcount = findMSB(MAX_TRIANGLES_IN_BATCH-1)+1;
+    triangleIDdrawID_unorm16Bary_dBarydScreenHalf2x2[0] = bitfieldInsert(gl_PrimitiveID,drawGUID,triangleIDBitcount,32-triangleIDBitcount);
     triangleIDdrawID_unorm16Bary_dBarydScreenHalf2x2[1] = packUnorm2x16(bary);
     triangleIDdrawID_unorm16Bary_dBarydScreenHalf2x2[2] = packHalf2x16(dFdx(bary));
     triangleIDdrawID_unorm16Bary_dBarydScreenHalf2x2[3] = packHalf2x16(dFdy(bary));

include/nbl/builtin/glsl/barycentric/frag.glsl

@@ -48,13 +48,11 @@ vec3 nbl_glsl_barycentric_frag_getVertexPos(in uint drawID, in uint primID, in u
 #include <nbl/builtin/glsl/barycentric/utils.glsl>
 vec2 nbl_glsl_barycentric_frag_get()
 {
-    return nbl_glsl_barycentric_reconstructBarycentrics(
-        nbl_glsl_barycentric_frag_pos-nbl_glsl_barycentric_frag_provokingPos,
-        mat2x3(
-            nbl_glsl_barycentric_frag_getVertexPos(nbl_glsl_barycentric_frag_getDrawID(),gl_PrimitiveID,1u)-nbl_glsl_barycentric_frag_provokingPos,
-            nbl_glsl_barycentric_frag_getVertexPos(nbl_glsl_barycentric_frag_getDrawID(),gl_PrimitiveID,2u)-nbl_glsl_barycentric_frag_provokingPos
-        )
-    );
+    return nbl_glsl_barycentric_reconstructBarycentrics(nbl_glsl_barycentric_frag_pos,mat3(
+        nbl_glsl_barycentric_frag_provokingPos,
+        nbl_glsl_barycentric_frag_getVertexPos(nbl_glsl_barycentric_frag_getDrawID(),gl_PrimitiveID,1u),
+        nbl_glsl_barycentric_frag_getVertexPos(nbl_glsl_barycentric_frag_getDrawID(),gl_PrimitiveID,2u)
+    ));
 }
 #define _NBL_BUILTIN_GLSL_BARYCENTRIC_FRAG_GET_DEFINED_
 #endif

include/nbl/builtin/glsl/barycentric/utils.glsl

@@ -13,14 +13,14 @@ vec2 nbl_glsl_barycentric_reconstructBarycentrics(in vec3 positionRelativeToV0,
 
     const float qe0 = dot(positionRelativeToV0,edges[0]);
     const float qe1 = dot(positionRelativeToV0,edges[1]);
-    vec2 protoBary = vec2(qe0*e1_2-qe1*e0e1,qe1*e0_2-qe0*e0e1);
+    const vec2 protoBary = vec2(qe0*e1_2-qe1*e0e1,qe1*e0_2-qe0*e0e1);
 
-    const float rcp_dep = 1.f/(e0_2*e1_2+e0e1*e0e1);
+    const float rcp_dep = 1.f/(e0_2*e1_2-e0e1*e0e1);
     return protoBary*rcp_dep;
 }
 vec2 nbl_glsl_barycentric_reconstructBarycentrics(in vec3 pointPosition, in mat3 vertexPositions)
 {
-    return nbl_glsl_barycentric_reconstructBarycentrics(pointPosition-vertexPositions[0],mat2x3(vertexPositions[1]-vertexPositions[0],vertexPositions[2]-vertexPositions[0]));
+    return nbl_glsl_barycentric_reconstructBarycentrics(pointPosition-vertexPositions[2],mat2x3(vertexPositions[0]-vertexPositions[2],vertexPositions[1]-vertexPositions[2]));
 }
 
 vec3 nbl_glsl_barycentric_expand(in vec2 compactBarycentrics)