Skip to content

Commit c120e16

Browse files
committed
save work
1 parent 73ef4cd commit c120e16

File tree

2 files changed

+18
-12
lines changed

2 files changed

+18
-12
lines changed

cmake/common.cmake

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1625,9 +1625,14 @@ endfunction()
16251625

16261626
function(NBL_CREATE_RESOURCE_ARCHIVE)
16271627
set(REQUIRED_SINGLE_ARGS TARGET BIND NAMESPACE)
1628-
cmake_parse_arguments(IMPL "" "${REQUIRED_SINGLE_ARGS}" "BUILTINS" ${ARGV})
1628+
cmake_parse_arguments(IMPL "" "${REQUIRED_SINGLE_ARGS}" "BUILTINS;LINK_TO" ${ARGV})
16291629
NBL_PARSE_REQUIRED(IMPL ${REQUIRED_SINGLE_ARGS})
16301630

1631+
if(NOT NBL_EMBED_BUILTIN_RESOURCES)
1632+
add_library(${IMPL_TARGET} INTERFACE) # dummy, could use LINK_TO but makes no difference in this case
1633+
return()
1634+
endif()
1635+
16311636
set(IMPL_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/${IMPL_TARGET}")
16321637

16331638
set(_BUNDLE_ARCHIVE_ABSOLUTE_PATH_ "")
@@ -1641,17 +1646,18 @@ function(NBL_CREATE_RESOURCE_ARCHIVE)
16411646
get_filename_component(BUILTIN_ARCHIVE_INPUT_ABS_ENTRY "${IMPL_INPUT_DIRECTORY}" ABSOLUTE)
16421647
set(BUILTIN_KEY_ENTRY_ABS "${BUILTIN_ARCHIVE_INPUT_ABS_ENTRY}/${_BUNDLE_ARCHIVE_ABSOLUTE_PATH_}")
16431648

1644-
if(NBL_EMBED_BUILTIN_RESOURCES)
1645-
foreach(IT ${IMPL_BUILTINS})
1646-
if(NBL_LOG_VERBOSE)
1647-
message(STATUS "[${IMPL_TARGET}'s Builtins]: Registered \"${IT}\" key")
1648-
endif()
1649+
unset(NBL_RESOURCES_TO_EMBED)
1650+
foreach(IT ${IMPL_BUILTINS})
1651+
if(NBL_LOG_VERBOSE)
1652+
message(STATUS "[${IMPL_TARGET}'s Builtins]: Registered \"${IT}\" key")
1653+
endif()
16491654

1650-
LIST_BUILTIN_RESOURCE(NBL_RESOURCES_TO_EMBED ${IT})
1651-
endforeach()
1655+
LIST_BUILTIN_RESOURCE(NBL_RESOURCES_TO_EMBED ${IT})
1656+
endforeach()
16521657

1653-
ADD_CUSTOM_BUILTIN_RESOURCES(${IMPL_TARGET} NBL_RESOURCES_TO_EMBED "${_BUNDLE_SEARCH_DIRECTORY_}" "${_BUNDLE_ARCHIVE_ABSOLUTE_PATH_}" "${_BUILTIN_RESOURCES_NAMESPACE_}" "${_OUTPUT_DIRECTORY_HEADER_}" "${_OUTPUT_DIRECTORY_SOURCE_}" "${_LINK_MODE_}")
1654-
else()
1655-
add_library(${IMPL_TARGET} INTERFACE) # dummy
1658+
ADD_CUSTOM_BUILTIN_RESOURCES(${IMPL_TARGET} NBL_RESOURCES_TO_EMBED "${_BUNDLE_SEARCH_DIRECTORY_}" "${_BUNDLE_ARCHIVE_ABSOLUTE_PATH_}" "${_BUILTIN_RESOURCES_NAMESPACE_}" "${_OUTPUT_DIRECTORY_HEADER_}" "${_OUTPUT_DIRECTORY_SOURCE_}" "${_LINK_MODE_}")
1659+
1660+
if(IMPL_LINK_TO)
1661+
LINK_BUILTIN_RESOURCES_TO_TARGET(${IMPL_LINK_TO} ${IMPL_TARGET})
16561662
endif()
16571663
endfunction()

0 commit comments

Comments
 (0)