Skip to content

Commit c2ff831

Browse files
Fixed another Push-Constants bug... CC: @Crisspl
1 parent a57295a commit c2ff831

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

examples_tests/22.RaytracedAO/raygen.comp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -221,12 +221,12 @@ void main()
221221
const uint realOutputID = outputID+i;
222222
if (validRay)
223223
{
224-
throughput /= float(staticViewData.samplesPerPixelPerDispatch);
224+
throughput.rgb /= float(staticViewData.samplesPerPixelPerDispatch);
225225

226226
const float tt = 1.0;
227-
rays[realOutputID].origin = nbl_glsl_MC_getWorldSpacePosition()+nbl_glsl_MC_getNormalizedWorldSpaceV()*tt;//-direction*0.5*maxT;/*+newray.direction*err?; TODO */
228-
rays[realOutputID].maxT = tt*2.0;
229-
rays[realOutputID].direction = -nbl_glsl_MC_getNormalizedWorldSpaceV()*tt;
227+
rays[realOutputID].origin = pc.cummon.cameraPosition;//nbl_glsl_MC_getWorldSpacePosition()+nbl_glsl_MC_getNormalizedWorldSpaceV()*tt;//-direction*0.5*maxT;/*+newray.direction*err?; TODO */
228+
rays[realOutputID].maxT = FLT_MAX;//tt*2.0;
229+
rays[realOutputID].direction = -nbl_glsl_MC_getNormalizedWorldSpaceV();
230230
rays[realOutputID].mask = -1;
231231
rays[realOutputID]._active = 1;
232232
rays[realOutputID].backfaceCulling = int(packHalf2x16(throughput.ab));

examples_tests/22.RaytracedAO/resolve.comp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ void main()
2929
if (hit.shapeid<0)
3030
continue;
3131

32-
//color.r -= float(hit.shapeid);//staticViewData.samplesPerPixelPerDispatch;
33-
//color.g -= float(hit.primid);//staticViewData.samplesPerPixelPerDispatch;
32+
color.r -= float(hit.shapeid);//staticViewData.samplesPerPixelPerDispatch;
33+
color.g -= float(hit.primid);//staticViewData.samplesPerPixelPerDispatch;
3434

3535
// hit buffer needs clearing
3636
hits[rayID].shapeid = -1;

src/nbl/video/IOpenGLPipeline.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,8 @@ class IOpenGLPipeline
9999
{
100100
// pack the constant data as OpenGL uniform update functions expect packed arrays
101101
{
102-
const bool isRowMajor = is_scalar_or_vec() || m.rowMajor;
103-
const uint32_t rowOrColCnt = isRowMajor ? m.mtxRowCnt : m.mtxColCnt;
104-
const uint32_t len = isRowMajor ? m.mtxColCnt : m.mtxRowCnt;
102+
const uint32_t rowOrColCnt = m.rowMajor ? m.mtxRowCnt : m.mtxColCnt;
103+
const uint32_t len = m.rowMajor ? m.mtxColCnt : m.mtxRowCnt;
105104
for (uint32_t i = 0u; i < count; ++i)
106105
for (uint32_t c = 0u; c < rowOrColCnt; ++c)
107106
{

0 commit comments

Comments
 (0)