Remove valid implementation on IAsset and implement valid for all derived class of IAsset

Author: kevyuu

include/nbl/asset/IAsset.h

@@ -175,11 +175,7 @@ class IAsset : virtual public core::IReferenceCounted
 				});
     }
 
-    virtual bool valid() const
-    {
-        //TODO(kevinyu): Temporary set this to true to make changes compile. Will revisit this later for each asset
-        return true;
-    }
+		virtual bool valid() const = 0;
 
     protected:
 		inline IAsset() = default;

include/nbl/asset/ICPUAccelerationStructure.h

@@ -231,6 +231,33 @@ class ICPUBottomLevelAccelerationStructure final : public IPreHashed, public IBo
 			return !m_geometryPrimitiveCount || !m_triangleGeoms && !m_AABBGeoms;
 		}
 
+		inline virtual bool valid() const override
+		{
+			if (!validBuildFlags(m_buildFlags)) return false;
+
+			size_t geometryCount = 0;
+			if (m_buildFlags.hasFlags(BUILD_FLAGS::GEOMETRY_TYPE_IS_AABB_BIT))
+			{
+				if (!m_AABBGeoms || m_triangleGeoms) return false;
+				geometryCount = m_AABBGeoms->size();
+			}
+			else
+			{
+				if (!m_triangleGeoms || m_AABBGeoms) return false;
+				geometryCount = m_triangleGeoms->size();
+			}
+
+      // https://registry.khronos.org/vulkan/specs/latest/man/html/vkGetAccelerationStructureBuildSizesKHR.html#VUID-vkGetAccelerationStructureBuildSizesKHR-pBuildInfo-03619
+			if (geometryCount == 0) {
+				if (m_geometryPrimitiveCount && m_geometryPrimitiveCount->size() > 0) return false;
+			}
+		  else
+			{
+				if (!m_geometryPrimitiveCount || m_geometryPrimitiveCount->size() != geometryCount) return false;
+			}
+			return true;
+		}
+
 	protected:
 		virtual ~ICPUBottomLevelAccelerationStructure() = default;
 
@@ -352,6 +379,17 @@ class ICPUTopLevelAccelerationStructure final : public IAsset, public ITopLevelA
 			return cp;
 		}
 
+		inline virtual bool valid() const override
+		{
+			if (!validBuildFlags(m_buildFlags)) return false;
+			if (!m_instances) return false;
+			for (const auto& instance : *m_instances)
+				if (!instance.getBase().blas->valid()) return false;
+			if (m_buildRangeInfo.instanceCount != m_instances->size()) return false;
+			if (m_buildRangeInfo.instanceByteOffset % 16 != 0) return false;
+			return true;
+		}
+
 	protected:
 		virtual ~ICPUTopLevelAccelerationStructure() = default;
 

include/nbl/asset/ICPUAnimationLibrary.h

@@ -95,6 +95,7 @@ class ICPUAnimationLibrary final : public IAnimationLibrary<ICPUBuffer>, public
 
 		constexpr static inline auto AssetType = ET_ANIMATION_LIBRARY;
 		inline E_TYPE getAssetType() const override { return AssetType; }
+		inline virtual bool valid() const override { return true; }
 
   private:
 

include/nbl/asset/ICPUImage.h

@@ -199,9 +199,10 @@ class NBL_API2 ICPUImage final : public IImage, public IPreHashed
 		{
 			if (!validateCreationParameters(m_creationParams)) return false;
 			if (info != m_creationParams.format) return false;
-			if (!buffer->valid()) return false;
-			for (const auto& region : regions)
-				if (!region.isValid()) return false;
+			if (buffer && !buffer->valid()) return false;
+			if (regions)
+				for (const auto& region : *regions)
+					if (!region.isValid()) return false;
 			return true;
 		}
 

include/nbl/asset/ICPUMesh.h

@@ -81,6 +81,16 @@ class ICPUMesh final : public IMesh<ICPUMeshBuffer>, public IAsset
             return cp;
         }
 
+    inline virtual bool valid() const override
+    {
+      for (const auto& meshBuffer : m_meshBuffers)
+      {
+        if (!meshBuffer) return false;
+        if (!meshBuffer->valid()) return false;
+      }
+      return true;
+    }
+
 	protected:
 
 	private:

include/nbl/asset/ICPUMeshBuffer.h

@@ -610,7 +610,12 @@ class ICPUMeshBuffer final : public IMeshBuffer<ICPUBuffer,ICPUDescriptorSet,ICP
             assert(isMutable());
             return const_cast<core::aabbox3df*>(const_cast<const ICPUMeshBuffer*>(this)->getJointAABBs());
         }
+        inline virtual bool valid() const override
+        {
+            return true;
+        }
 
+    private:
         inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
         {
         }

include/nbl/asset/ICPURenderpassIndependentPipeline.h

@@ -93,6 +93,11 @@ class ICPURenderpassIndependentPipeline : public IRenderpassIndependentPipeline,
 			m_layout = std::move(_layout);
 		}
 
+    inline virtual bool valid() const override
+    {
+      return m_layout && m_layout->valid();
+    }
+
 #if 0
 		// The getters are weird because the shader pointer needs patching
 		inline IShader::SSpecInfo<ICPUShader> getSpecInfos(const hlsl::ShaderStage stage)

include/nbl/asset/ICPUSampler.h

@@ -68,6 +68,7 @@ class ICPUSampler : public ISampler, public IAsset
 
 		constexpr static inline auto AssetType = ET_SAMPLER;
 		inline IAsset::E_TYPE getAssetType() const override { return AssetType; }
+		inline virtual bool valid() const override { return true; }
 
   private:
 

include/nbl/asset/ICPUSkeleton.h

@@ -78,6 +78,7 @@ class ICPUSkeleton final : public ISkeleton<ICPUBuffer>, public IAsset
 
 		constexpr static inline auto AssetType = ET_SKELETON;
 		inline E_TYPE getAssetType() const override { return AssetType; }
+		inline virtual bool valid() const override { return true; }
 
   private:
 

include/nbl/asset/IShader.h

@@ -87,6 +87,14 @@ class IShader : public IAsset
 
 		// TODO: `void setContent(core::smart_refctd_ptr<const ICPUBuffer>&&,const E_CONTENT_TYPE)`
 
+		inline virtual bool valid() const override
+		{
+			if (!m_code) return false;
+			if (m_contentType == E_CONTENT_TYPE::ECT_UNKNOWN) return false;
+			// Note(kevyuu) : Should we check for m_filepathHint if content type is not spirv. What if no pragma includ in the source code. Do we even need m_filepathHint in that case?
+			return true;
+		}
+
 		// alias for legacy reasons
 		using E_SHADER_STAGE = hlsl::ShaderStage;