Skip to content

Commit ca1d2e5

Browse files
committed
we need to switch some stuff off for a while
1 parent 67463f1 commit ca1d2e5

File tree

4 files changed

+13
-10
lines changed

4 files changed

+13
-10
lines changed

CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ cmake_policy(SET CMP0072 OLD) #not yet, would need to get pointers to all OpenGL
88
set(OpenGL_GL_PREFERENCE LEGACY)
99
#cmake_policy(SET CMP )
1010

11+
set(NBL_BUILD_ANDROID OFF)
12+
1113
include(ExternalProject)
1214
include(${CMAKE_CURRENT_SOURCE_DIR}/cmake/toolchains/android/build.cmake)
1315

cmake/toolchains/android/build.cmake

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
set(NBL_BUILD_ANDROID OFF)
1615
if(DEFINED CMAKE_TOOLCHAIN_FILE)
1716
if(EXISTS "${CMAKE_TOOLCHAIN_FILE}")
1817
cmake_path(GET CMAKE_TOOLCHAIN_FILE FILENAME _NBL_CMAKE_TOOLCHAIN_FILENAME_)
@@ -88,13 +87,6 @@ if(NBL_BUILD_ANDROID)
8887
message(FATAL_ERROR "Current host OS for Android cross-compiling isn't allowed!")
8988
endif()
9089

91-
# TODO - remove those bellow in future
92-
set(_NBL_COMPILE_WITH_OPEN_EXR_ OFF CACHE BOOL "Off for Android purposes at the moment" FORCE) # TODO - check it out
93-
set(_NBL_COMPILE_WITH_BAW_LOADER_ OFF CACHE BOOL "Off for Android purposes at the moment" FORCE) # TODO - remove when BAW-v4 is done
94-
set(_NBL_COMPILE_WITH_BAW_WRITER_ OFF CACHE BOOL "Off for Android purposes at the moment" FORCE) # TODO - remove when BAW-v4 is done
95-
set(_NBL_COMPILE_WITH_OBJ_LOADER_ ON CACHE BOOL "Off for Android purposes at the moment" FORCE)
96-
set(NBL_BUILD_MITSUBA_LOADER OFF CACHE BOOL "Off for Android purposes at the moment" FORCE) # TODO - compile/linker errors
97-
9890
find_package(Java 1.8)
9991

10092
if(DEFINED Java_JAVA_EXECUTABLE)

src/nbl/CMakeLists.txt

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,16 @@ option(_NBL_COMPILE_WITH_GLI_WRITER_ "Compile with GLI Writer" ON)
121121
option(_NBL_COMPILE_WITH_GLTF_LOADER_ "Compile with GLTF Loader" ON)
122122
option(_NBL_COMPILE_WITH_GLTF_WRITER_ "Compile with GLTF Writer" ON)
123123

124+
if(NBL_BUILD_ANDROID)
125+
# TODO - remove those bellow in future
126+
set(_NBL_COMPILE_WITH_OPEN_EXR_ OFF CACHE BOOL "Off for Android purposes at the moment" FORCE) # TODO - check it out
127+
set(_NBL_COMPILE_WITH_BAW_LOADER_ OFF CACHE BOOL "Off for Android purposes at the moment" FORCE) # TODO - remove when BAW-v4 is done
128+
set(_NBL_COMPILE_WITH_BAW_WRITER_ OFF CACHE BOOL "Off for Android purposes at the moment" FORCE) # TODO - remove when BAW-v4 is done
129+
set(_NBL_COMPILE_WITH_OBJ_LOADER_ OFF CACHE BOOL "Off for Android purposes at the moment" FORCE)
130+
set(_NBL_COMPILE_WITH_MTL_LOADER_ OFF CACHE BOOL "Off for Android purposes at the moment" FORCE)
131+
set(NBL_BUILD_MITSUBA_LOADER OFF CACHE BOOL "Off for Android purposes at the moment" FORCE) # TODO - compile/linker errors
132+
endif()
133+
124134
nbl_get_conf_dir(NABLA_CONF_DIR_DEBUG Debug)
125135
nbl_get_conf_dir(NABLA_CONF_DIR_RELEASE Release)
126136
if(NBL_EMBED_BUILTIN_RESOURCES)

src/nbl/asset/interchange/CGraphicsPipelineLoaderMTL.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ void CGraphicsPipelineLoaderMTL::initialize()
8686
// default pipelines
8787
constexpr std::string_view filename = "Nabla default MTL material";
8888

89-
auto default_mtl_file = core::make_smart_refctd_ptr<system::CFileView<system::CPlainHeapAllocator>>(core::smart_refctd_ptr(m_system), filename, system::IFile::ECF_READ, strlen(DUMMY_MTL_CONTENT));
89+
auto default_mtl_file = core::make_smart_refctd_ptr<system::CFileView<system::CPlainHeapAllocator>>(core::smart_refctd_ptr(m_system), filename, system::IFile::ECF_READ_WRITE, strlen(DUMMY_MTL_CONTENT));
9090

9191
system::future<size_t> future;
9292
default_mtl_file->write(future, DUMMY_MTL_CONTENT, 0, strlen(DUMMY_MTL_CONTENT));
@@ -95,7 +95,6 @@ void CGraphicsPipelineLoaderMTL::initialize()
9595
SAssetLoadParams assetLoadParams;
9696
auto bundle = loadAsset(default_mtl_file.get(), assetLoadParams, &dfltOver);
9797

98-
9998
insertBuiltinAssetIntoCache(m_assetMgr, bundle, "nbl/builtin/renderpass_independent_pipeline/loader/mtl/missing_material_pipeline");
10099
}
101100

0 commit comments

Comments
 (0)