Skip to content

Commit d9d27d9

Browse files
Bugs to address by @Crisspl
1 parent 7cf32f8 commit d9d27d9

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

include/nbl/asset/utils/IVirtualTexture.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1020,7 +1020,7 @@ class IVirtualTexture : public core::IReferenceCounted, public IVirtualTextureBa
10201020
bnd.samplers = _samplers;
10211021
};
10221022

1023-
fillBinding(bindings[0], _pgtBinding, 1u, samplers);
1023+
fillBinding(bindings[0], _pgtBinding, 1u, samplers); // @Crisspl why is the count hardcoded to 1 !?
10241024

10251025
uint32_t i = 1u;
10261026
if (getFloatViews().size())
@@ -1030,12 +1030,12 @@ class IVirtualTexture : public core::IReferenceCounted, public IVirtualTextureBa
10301030
}
10311031
if (getIntViews().size())
10321032
{
1033-
fillBinding(bindings[i], _isamplersBinding, getIntViews().size(), samplers+1);
1033+
fillBinding(bindings[i], _isamplersBinding, getIntViews().size(), samplers+1); // @Crisspl this has to be wrong! Sampler state for an interpolated float texture is definitely wrong to use for a integer texture
10341034
++i;
10351035
}
10361036
if (getUintViews().size())
10371037
{
1038-
fillBinding(bindings[i], _usamplersBinding, getUintViews().size(), samplers+1);
1038+
fillBinding(bindings[i], _usamplersBinding, getUintViews().size(), samplers+1); // @Crisspl this has to be wrong! Sampler state for an interpolated float texture is definitely wrong to use for a integer texture
10391039
}
10401040

10411041
return std::make_pair(bindingCount, samplerCount);

0 commit comments

Comments
 (0)