Cleanups.

Author: achalpandeyy

examples_tests/60.ClusteredRendering/cull_common.glsl

@@ -186,6 +186,9 @@ bool cullCone(in cone_t cone, in nbl_glsl_shapes_AABB_t aabb)
 
 			const vec3 waypoint = normalize(vertex - cone.tip);
 
+			// Todo(achal): nbl_glsl_slerp_impl_impl wants the length of cross of first two params to be exactly 1, hence there should be division
+			// by sine of angle between the cone.direction and waypoint, however, it introduces a chance of divison by zero as well which messes up
+			// things massively (as I have come to find out with a previous bug) --need to think about what to do when the sine approaches 0.
 			const vec3 normal = nbl_glsl_slerp_impl_impl(cone.direction, normalize(waypoint), sqrt(1.f - cone.cosHalfAngle * cone.cosHalfAngle));
 			if (dot(nbl_glsl_shapes_AABB_getFarthestPointInFront(aabb, normal) - cone.tip, normal) < 0.f)
 				return true;
@@ -213,7 +216,6 @@ bool cullCone(in cone_t cone, in nbl_glsl_shapes_AABB_t aabb)
 // Todo(achal): Can make this cone_t something like light_volume_t..
 bool lightIntersectAABB(in cone_t cone, in nbl_glsl_shapes_AABB_t aabb)
 {
-#if 1
 	const vec3 sphereMinPoint = cone.tip - cone.height;
 	const vec3 sphereMaxPoint = cone.tip + cone.height;
 
@@ -227,7 +229,6 @@ bool lightIntersectAABB(in cone_t cone, in nbl_glsl_shapes_AABB_t aabb)
 
 	if (cone.cosHalfAngle <= -(1.f - 1e-3f))
 		return false;
-#endif
 
 	return !cullCone(cone, aabb);
 }

examples_tests/60.ClusteredRendering/main.cpp

@@ -9,7 +9,7 @@
 using namespace nbl;
 
 // #define SYNC_DEBUG
-// #define DEBUG_VIZ
+#define DEBUG_VIZ
 
 #define CLIPMAP
 // #define OCTREE
@@ -1857,7 +1857,7 @@ class ClusteredRenderingSampleApp : public ApplicationBase
 						if ((ev.keyCode == ui::EKC_F) && (ev.action == ui::SKeyboardEvent::ECA_RELEASED))
 						{
 							const core::vectorSIMDf aabbCenter = camera.getPosition();
-							const float extent = 500.f;
+							const float extent = 100.f;
 							nbl_glsl_shapes_AABB_t aabb;
 							aabb.minVx = { aabbCenter.x - (extent / 2.f), aabbCenter.y - (extent / 2.f), aabbCenter.z - (extent / 2.f) };
 							aabb.maxVx = { aabbCenter.x + (extent / 2.f), aabbCenter.y + (extent / 2.f), aabbCenter.z + (extent / 2.f) };
@@ -1872,7 +1872,7 @@ class ClusteredRenderingSampleApp : public ApplicationBase
 						if ((ev.keyCode == ui::EKC_G) && (ev.action == ui::SKeyboardEvent::ECA_RELEASED))
 						{
 							const core::vectorSIMDf aabbCenter = camera.getPosition();
-							const float extent = 500.f;
+							const float extent = 100.f;
 							nbl_glsl_shapes_AABB_t aabb;
 
 							aabb.minVx = { aabbCenter.x - (extent / 2.f), aabbCenter.y - (extent / 2.f), aabbCenter.z - (extent / 2.f) };
@@ -2889,20 +2889,15 @@ class ClusteredRenderingSampleApp : public ApplicationBase
 				const uint32_t y = (i >> 1) & 0x1u;
 				const uint32_t z = (i >> 2) & 0x1u;
 
-				printf("Vertex ID: [%d, %d, %d]\n", x, y, z);
 
 				const core::vectorSIMDf aabbVertex(
 					(1u - x) * aabb.minVx.x + x * aabb.maxVx.x,
 					(1u - y) * aabb.minVx.y + y * aabb.maxVx.y,
 					(1u - z) * aabb.minVx.z + z * aabb.maxVx.z);
 
-				printf("Vertex: [%f, %f, %f]\n", aabbVertex.x, aabbVertex.y, aabbVertex.z);
-
 				const core::vectorSIMDf waypoint = core::normalize(aabbVertex - cone.tip);
 
 				const core::vectorSIMDf normal = slerp_till_cosine(cone.direction, core::normalize(waypoint), core::sqrt(1.f - cone.cosHalfAngle * cone.cosHalfAngle));
-				printf("normal: [%f, %f, %f]\n", normal.x, normal.y, normal.z);
-				printf("dot(cone.direction, normal): %f\n\n", core::dot(cone.direction, normal).x);
 				if (core::dot(getFarthestPointInFront(aabb, normal) - cone.tip, normal).x < 0.f)
 					return true;
 			}